From: Jesper Dangaard Brouer <brouer@redhat.com>
To: David Ahern <dsahern@gmail.com>
Cc: netdev@vger.kernel.org, borkmann@iogearbox.net, ast@kernel.org,
davem@davemloft.net, shm@cumulusnetworks.com,
roopa@cumulusnetworks.com, toke@toke.dk,
john.fastabend@gmail.com, brouer@redhat.com
Subject: Re: [bpf-next v2 8/9] bpf: Provide helper to do forwarding lookups in kernel FIB table
Date: Mon, 7 May 2018 15:35:52 +0200 [thread overview]
Message-ID: <20180507153552.5063a4b2@redhat.com> (raw)
In-Reply-To: <20180504025432.23451-9-dsahern@gmail.com>
On Thu, 3 May 2018 19:54:31 -0700 David Ahern <dsahern@gmail.com> wrote:
> diff --git a/net/core/filter.c b/net/core/filter.c
> index 6877426c23a6..cf0d27acf1d1 100644
> --- a/net/core/filter.c
> +++ b/net/core/filter.c
[...]
> +static const struct bpf_func_proto bpf_xdp_fib_lookup_proto = {
> + .func = bpf_xdp_fib_lookup,
> + .gpl_only = true,
Is it a deliberate choice to require BPF-progs using this helper to be
GPL licensed?
Asking as this seems to be the first network related helper with this
requirement, while this is typical for tracing related helpers.
> + .ret_type = RET_INTEGER,
> + .arg1_type = ARG_PTR_TO_CTX,
> + .arg2_type = ARG_PTR_TO_MEM,
> + .arg3_type = ARG_CONST_SIZE,
> + .arg4_type = ARG_ANYTHING,
> +};
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Principal Kernel Engineer at Red Hat
LinkedIn: http://www.linkedin.com/in/brouer
next prev parent reply other threads:[~2018-05-07 13:36 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-04 2:54 [bpf-next v2 0/9] bpf: Add helper to do FIB lookups David Ahern
2018-05-04 2:54 ` [bpf-next v2 1/9] net/ipv6: Rename fib6_lookup to fib6_node_lookup David Ahern
2018-05-04 2:54 ` [bpf-next v2 2/9] net/ipv6: Rename rt6_multipath_select David Ahern
2018-05-04 2:54 ` [bpf-next v2 3/9] net/ipv6: Extract table lookup from ip6_pol_route David Ahern
2018-05-04 2:54 ` [bpf-next v2 4/9] net/ipv6: Refactor fib6_rule_action David Ahern
2018-05-04 2:54 ` [bpf-next v2 5/9] net/ipv6: Add fib6_lookup David Ahern
2018-05-04 2:54 ` [bpf-next v2 6/9] net/ipv6: Update fib6 tracepoint to take fib6_info David Ahern
2018-05-04 2:54 ` [bpf-next v2 7/9] net/ipv6: Add fib lookup stubs for use in bpf helper David Ahern
2018-05-04 2:54 ` [bpf-next v2 8/9] bpf: Provide helper to do forwarding lookups in kernel FIB table David Ahern
2018-05-07 13:35 ` Jesper Dangaard Brouer [this message]
2018-05-07 14:10 ` Daniel Borkmann
2018-05-07 14:26 ` David Ahern
2018-05-07 15:36 ` David Miller
2018-05-09 8:15 ` Daniel Borkmann
2018-05-09 16:05 ` David Ahern
2018-05-09 20:44 ` Daniel Borkmann
2018-05-09 21:29 ` David Ahern
2018-05-09 21:39 ` David Ahern
2018-05-09 21:49 ` Alexei Starovoitov
2018-05-09 21:49 ` Daniel Borkmann
2018-05-04 2:54 ` [bpf-next v2 9/9] samples/bpf: Add example of ipv4 and ipv6 forwarding in XDP David Ahern
2018-05-08 23:53 ` [bpf-next v2 0/9] bpf: Add helper to do FIB lookups Daniel Borkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180507153552.5063a4b2@redhat.com \
--to=brouer@redhat.com \
--cc=ast@kernel.org \
--cc=borkmann@iogearbox.net \
--cc=davem@davemloft.net \
--cc=dsahern@gmail.com \
--cc=john.fastabend@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=roopa@cumulusnetworks.com \
--cc=shm@cumulusnetworks.com \
--cc=toke@toke.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.