From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Date: Tue, 08 May 2018 09:26:50 +0000 Subject: [PATCH 1/3] drm/xen-front: checking for NULL instead of IS_ERR Message-Id: <20180508092650.GA661@mwanda> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Oleksandr Andrushchenko Cc: David Airlie , kernel-janitors@vger.kernel.org, dri-devel@lists.freedesktop.org, xen-devel@lists.xen.org drm_dev_alloc() returns error pointers, it never returns NULL. Fixes: c575b7eeb89f ("drm/xen-front: Add support for Xen PV display frontend") Signed-off-by: Dan Carpenter diff --git a/drivers/gpu/drm/xen/xen_drm_front.c b/drivers/gpu/drm/xen/xen_drm_front.c index 1b0ea9ac330e..8615e8522c7a 100644 --- a/drivers/gpu/drm/xen/xen_drm_front.c +++ b/drivers/gpu/drm/xen/xen_drm_front.c @@ -543,8 +543,8 @@ static int xen_drm_drv_init(struct xen_drm_front_info *front_info) front_info->drm_info = drm_info; drm_dev = drm_dev_alloc(&xen_drm_driver, dev); - if (!drm_dev) { - ret = -ENOMEM; + if (IS_ERR(drm_dev)) { + ret = PTR_ERR(drm_dev); goto fail; } From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Subject: [PATCH 1/3] drm/xen-front: checking for NULL instead of IS_ERR Date: Tue, 8 May 2018 12:26:50 +0300 Message-ID: <20180508092650.GA661@mwanda> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from aserp2130.oracle.com (aserp2130.oracle.com [141.146.126.79]) by gabe.freedesktop.org (Postfix) with ESMTPS id F32806E638 for ; Tue, 8 May 2018 09:27:06 +0000 (UTC) Content-Disposition: inline List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Oleksandr Andrushchenko Cc: David Airlie , kernel-janitors@vger.kernel.org, dri-devel@lists.freedesktop.org, xen-devel@lists.xen.org List-Id: dri-devel@lists.freedesktop.org ZHJtX2Rldl9hbGxvYygpIHJldHVybnMgZXJyb3IgcG9pbnRlcnMsIGl0IG5ldmVyIHJldHVybnMg TlVMTC4KCkZpeGVzOiBjNTc1YjdlZWI4OWYgKCJkcm0veGVuLWZyb250OiBBZGQgc3VwcG9ydCBm b3IgWGVuIFBWIGRpc3BsYXkgZnJvbnRlbmQiKQpTaWduZWQtb2ZmLWJ5OiBEYW4gQ2FycGVudGVy IDxkYW4uY2FycGVudGVyQG9yYWNsZS5jb20+CgpkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJt L3hlbi94ZW5fZHJtX2Zyb250LmMgYi9kcml2ZXJzL2dwdS9kcm0veGVuL3hlbl9kcm1fZnJvbnQu YwppbmRleCAxYjBlYTlhYzMzMGUuLjg2MTVlODUyMmM3YSAxMDA2NDQKLS0tIGEvZHJpdmVycy9n cHUvZHJtL3hlbi94ZW5fZHJtX2Zyb250LmMKKysrIGIvZHJpdmVycy9ncHUvZHJtL3hlbi94ZW5f ZHJtX2Zyb250LmMKQEAgLTU0Myw4ICs1NDMsOCBAQCBzdGF0aWMgaW50IHhlbl9kcm1fZHJ2X2lu aXQoc3RydWN0IHhlbl9kcm1fZnJvbnRfaW5mbyAqZnJvbnRfaW5mbykKIAlmcm9udF9pbmZvLT5k cm1faW5mbyA9IGRybV9pbmZvOwogCiAJZHJtX2RldiA9IGRybV9kZXZfYWxsb2MoJnhlbl9kcm1f ZHJpdmVyLCBkZXYpOwotCWlmICghZHJtX2RldikgewotCQlyZXQgPSAtRU5PTUVNOworCWlmIChJ U19FUlIoZHJtX2RldikpIHsKKwkJcmV0ID0gUFRSX0VSUihkcm1fZGV2KTsKIAkJZ290byBmYWls OwogCX0KIApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpk cmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0 cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK