From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Date: Tue, 08 May 2018 09:28:29 +0000 Subject: [PATCH 3/3] drm/xen-front: Fix loop timeout Message-Id: <20180508092829.GC661@mwanda> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Oleksandr Andrushchenko Cc: David Airlie , kernel-janitors@vger.kernel.org, dri-devel@lists.freedesktop.org, xen-devel@lists.xen.org If the loop times out then we want to exit with "to" set to zero, but in the current code it's set to -1. Fixes: c575b7eeb89f ("drm/xen-front: Add support for Xen PV display frontend") Signed-off-by: Dan Carpenter diff --git a/drivers/gpu/drm/xen/xen_drm_front.c b/drivers/gpu/drm/xen/xen_drm_front.c index 378cb7ce0db5..3345ac71b391 100644 --- a/drivers/gpu/drm/xen/xen_drm_front.c +++ b/drivers/gpu/drm/xen/xen_drm_front.c @@ -778,7 +778,7 @@ static int xen_drv_remove(struct xenbus_device *dev) */ while ((xenbus_read_unsigned(front_info->xb_dev->otherend, "state", XenbusStateUnknown) != XenbusStateInitWait) && - to--) + --to) msleep(10); if (!to) { From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Subject: [PATCH 3/3] drm/xen-front: Fix loop timeout Date: Tue, 8 May 2018 12:28:29 +0300 Message-ID: <20180508092829.GC661@mwanda> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from aserp2130.oracle.com (aserp2130.oracle.com [141.146.126.79]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4F10A6E63E for ; Tue, 8 May 2018 09:28:42 +0000 (UTC) Content-Disposition: inline List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Oleksandr Andrushchenko Cc: David Airlie , kernel-janitors@vger.kernel.org, dri-devel@lists.freedesktop.org, xen-devel@lists.xen.org List-Id: dri-devel@lists.freedesktop.org SWYgdGhlIGxvb3AgdGltZXMgb3V0IHRoZW4gd2Ugd2FudCB0byBleGl0IHdpdGggInRvIiBzZXQg dG8gemVybywgYnV0IGluCnRoZSBjdXJyZW50IGNvZGUgaXQncyBzZXQgdG8gLTEuCgpGaXhlczog YzU3NWI3ZWViODlmICgiZHJtL3hlbi1mcm9udDogQWRkIHN1cHBvcnQgZm9yIFhlbiBQViBkaXNw bGF5IGZyb250ZW5kIikKU2lnbmVkLW9mZi1ieTogRGFuIENhcnBlbnRlciA8ZGFuLmNhcnBlbnRl ckBvcmFjbGUuY29tPgoKZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS94ZW4veGVuX2RybV9m cm9udC5jIGIvZHJpdmVycy9ncHUvZHJtL3hlbi94ZW5fZHJtX2Zyb250LmMKaW5kZXggMzc4Y2I3 Y2UwZGI1Li4zMzQ1YWM3MWIzOTEgMTAwNjQ0Ci0tLSBhL2RyaXZlcnMvZ3B1L2RybS94ZW4veGVu X2RybV9mcm9udC5jCisrKyBiL2RyaXZlcnMvZ3B1L2RybS94ZW4veGVuX2RybV9mcm9udC5jCkBA IC03NzgsNyArNzc4LDcgQEAgc3RhdGljIGludCB4ZW5fZHJ2X3JlbW92ZShzdHJ1Y3QgeGVuYnVz X2RldmljZSAqZGV2KQogCSAqLwogCXdoaWxlICgoeGVuYnVzX3JlYWRfdW5zaWduZWQoZnJvbnRf aW5mby0+eGJfZGV2LT5vdGhlcmVuZCwgInN0YXRlIiwKIAkJCQkgICAgIFhlbmJ1c1N0YXRlVW5r bm93bikgIT0gWGVuYnVzU3RhdGVJbml0V2FpdCkgJiYKLQkJCQkgICAgIHRvLS0pCisJCQkJICAg ICAtLXRvKQogCQltc2xlZXAoMTApOwogCiAJaWYgKCF0bykgewpfX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1k ZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcv bWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK