Re: [Qemu-devel] [PATCH v4 3/4] monitor: more comments on lock-free fleids/funcs

[Peter Xu <peterx@redhat.com>]

On Tue, May 08, 2018 at 11:23:38AM +0100, Stefan Hajnoczi wrote:
> On Wed, May 02, 2018 at 06:04:21PM +0800, Peter Xu wrote:
> > Add some explicit comment for both Readline and cpu_set/cpu_get helpers
> > that they do not need the mon_lock protection.
> > 
> > Signed-off-by: Peter Xu <peterx@redhat.com>
> > ---
> >  monitor.c | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> > 
> > diff --git a/monitor.c b/monitor.c
> > index 9f361ec21e..6100ad44f8 100644
> > --- a/monitor.c
> > +++ b/monitor.c
> > @@ -207,6 +207,7 @@ struct Monitor {
> >      int suspend_cnt;            /* Needs to be accessed atomically */
> >      bool skip_flush;
> >      bool use_io_thr;
> > +    /* Only used in parser, so no lock needed. */
> >      ReadLineState *rs;
> >      MonitorQMP qmp;
> >      gchar *mon_cpu_path;
> 
> Which fields does this comment cover?

"rs" only.  Maybe I should move the comment to the end of line?

    ReadLineState *rs;       /* Only used in parser, so no lock needed. */

-- 
Peter Xu