From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com ([192.55.52.88]:46651 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750830AbeEHKri (ORCPT ); Tue, 8 May 2018 06:47:38 -0400 Date: Tue, 8 May 2018 13:47:36 +0300 From: Jarkko Sakkinen To: "David R. Bild" Cc: Greg Kroah-Hartman , Peter Huewe , linux-usb@vger.kernel.org, linux-integrity@vger.kernel.org Subject: Re: [PATCH v3 2/2] usb: misc: xapea00x: perform platform initialization of TPM Message-ID: <20180508104736.GA6132@linux.intel.com> References: <20180430125418.31344-1-david.bild@xaptum.com> <20180504130022.5231-3-david.bild@xaptum.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20180504130022.5231-3-david.bild@xaptum.com> Sender: linux-integrity-owner@vger.kernel.org List-ID: On Fri, May 04, 2018 at 08:00:22AM -0500, David R. Bild wrote: > Normally the system platform (i.e., BIOS/UEFI for x86) is responsible > for performing initialization of the TPM. For these modules, the host > kernel is the platform, so we perform the initialization in the driver > before registering the TPM with the kernel TPM subsystem. > > The initialization consists of issuing the TPM startup command, > running the TPM self-test, and setting the TPM platform hierarchy > authorization to a random, unsaved value so that it can never be used > after the driver has loaded. > > Signed-off-by: David R. Bild Have you checked what the TPM driver already does? /Jarkko From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v3,2/2] usb: misc: xapea00x: perform platform initialization of TPM From: Jarkko Sakkinen Message-Id: <20180508104736.GA6132@linux.intel.com> Date: Tue, 8 May 2018 13:47:36 +0300 To: "David R. Bild" Cc: Greg Kroah-Hartman , Peter Huewe , linux-usb@vger.kernel.org, linux-integrity@vger.kernel.org List-ID: T24gRnJpLCBNYXkgMDQsIDIwMTggYXQgMDg6MDA6MjJBTSAtMDUwMCwgRGF2aWQgUi4gQmlsZCB3 cm90ZToKPiBOb3JtYWxseSB0aGUgc3lzdGVtIHBsYXRmb3JtIChpLmUuLCBCSU9TL1VFRkkgZm9y IHg4NikgaXMgcmVzcG9uc2libGUKPiBmb3IgcGVyZm9ybWluZyBpbml0aWFsaXphdGlvbiBvZiB0 aGUgVFBNLiAgRm9yIHRoZXNlIG1vZHVsZXMsIHRoZSBob3N0Cj4ga2VybmVsIGlzIHRoZSBwbGF0 Zm9ybSwgc28gd2UgcGVyZm9ybSB0aGUgaW5pdGlhbGl6YXRpb24gaW4gdGhlIGRyaXZlcgo+IGJl Zm9yZSByZWdpc3RlcmluZyB0aGUgVFBNIHdpdGggdGhlIGtlcm5lbCBUUE0gc3Vic3lzdGVtLgo+ IAo+IFRoZSBpbml0aWFsaXphdGlvbiBjb25zaXN0cyBvZiBpc3N1aW5nIHRoZSBUUE0gc3RhcnR1 cCBjb21tYW5kLAo+IHJ1bm5pbmcgdGhlIFRQTSBzZWxmLXRlc3QsIGFuZCBzZXR0aW5nIHRoZSBU UE0gcGxhdGZvcm0gaGllcmFyY2h5Cj4gYXV0aG9yaXphdGlvbiB0byBhIHJhbmRvbSwgdW5zYXZl ZCB2YWx1ZSBzbyB0aGF0IGl0IGNhbiBuZXZlciBiZSB1c2VkCj4gYWZ0ZXIgdGhlIGRyaXZlciBo YXMgbG9hZGVkLgo+IAo+IFNpZ25lZC1vZmYtYnk6IERhdmlkIFIuIEJpbGQgPGRhdmlkLmJpbGRA eGFwdHVtLmNvbT4KCkhhdmUgeW91IGNoZWNrZWQgd2hhdCB0aGUgVFBNIGRyaXZlciBhbHJlYWR5 IGRvZXM/CgovSmFya2tvCi0tLQpUbyB1bnN1YnNjcmliZSBmcm9tIHRoaXMgbGlzdDogc2VuZCB0 aGUgbGluZSAidW5zdWJzY3JpYmUgbGludXgtdXNiIiBpbgp0aGUgYm9keSBvZiBhIG1lc3NhZ2Ug dG8gbWFqb3Jkb21vQHZnZXIua2VybmVsLm9yZwpNb3JlIG1ham9yZG9tbyBpbmZvIGF0ICBodHRw Oi8vdmdlci5rZXJuZWwub3JnL21ham9yZG9tby1pbmZvLmh0bWwK