Re: [PATCH 8/9] xfs: add some more debug checks to buffer log item reuse

[Brian Foster <bfoster@redhat.com>]

On Tue, May 08, 2018 at 01:42:01PM +1000, Dave Chinner wrote:
> From: Dave Chinner <dchinner@redhat.com>
> 
> Just to make sure the item isn't associated with another
> transaction when we try to reuse it.
> 
> Signed-Off-By: Dave Chinner <dchinner@redhat.com>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
> ---

Reviewed-by: Brian Foster <bfoster@redhat.com>

>  fs/xfs/xfs_buf_item.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/fs/xfs/xfs_buf_item.c b/fs/xfs/xfs_buf_item.c
> index df62082f2204..8d6ed045b643 100644
> --- a/fs/xfs/xfs_buf_item.c
> +++ b/fs/xfs/xfs_buf_item.c
> @@ -745,8 +745,10 @@ xfs_buf_item_init(
>  	 * nothing to do here so return.
>  	 */
>  	ASSERT(bp->b_target->bt_mount == mp);
> -	if (bip != NULL) {
> +	if (bip) {
>  		ASSERT(bip->bli_item.li_type == XFS_LI_BUF);
> +		ASSERT(!bp->b_transp);
> +		ASSERT(bip->bli_buf == bp);
>  		return 0;
>  	}
>  
> -- 
> 2.17.0
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html