From mboxrd@z Thu Jan 1 00:00:00 1970 From: keith.busch@linux.intel.com (Keith Busch) Date: Tue, 8 May 2018 10:22:26 -0600 Subject: [PATCH v2] nvme: add quirk to force medium priority for SQ creation In-Reply-To: <879357dd-937c-4496-84af-f804877562eb@kernel.dk> References: <879357dd-937c-4496-84af-f804877562eb@kernel.dk> Message-ID: <20180508162226.GA31027@localhost.localdomain> On Tue, May 08, 2018@09:54:20AM -0600, Jens Axboe wrote: > --- a/drivers/nvme/host/pci.c > +++ b/drivers/nvme/host/pci.c > @@ -1097,6 +1097,14 @@ static int adapter_alloc_sq(struct nvme_dev *dev, u16 qid, > int flags = NVME_QUEUE_PHYS_CONTIG; > > /* > + * Some drives have a bug that auto-enables WRRU if MEDIUM isn't > + * set. Since URGENT priority is zeroes, it makes all queues > + * URGENT. > + */ > + if (ctrl->quirks & NVME_QUIRK_MEDIUM_PRIO_SQ) > + flags |= NVME_SQ_PRIO_MEDIUM; 'ctrl' is undeclared in this function; must be 'dev->ctrl.quirks'.