From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boris Brezillon Subject: Re: [PATCH] drm/vc4: Fix scaling of uni-planar formats Date: Wed, 9 May 2018 09:43:24 +0200 Message-ID: <20180509094324.2139ce11@bbrezillon> References: <20180507121303.5610-1-boris.brezillon@bootlin.com> <87vabz1mu9.fsf@anholt.net> <20180507181102.47ea0060@bbrezillon> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail.bootlin.com (mail.bootlin.com [62.4.15.54]) by gabe.freedesktop.org (Postfix) with ESMTP id B43856EC7E for ; Wed, 9 May 2018 07:43:25 +0000 (UTC) In-Reply-To: <20180507181102.47ea0060@bbrezillon> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Eric Anholt Cc: David Airlie , stable@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gTW9uLCA3IE1heSAyMDE4IDE4OjExOjAyICswMjAwCkJvcmlzIEJyZXppbGxvbiA8Ym9yaXMu YnJlemlsbG9uQGJvb3RsaW4uY29tPiB3cm90ZToKCj4gT24gTW9uLCAwNyBNYXkgMjAxOCAwODo1 NjoxNCAtMDcwMAo+IEVyaWMgQW5ob2x0IDxlcmljQGFuaG9sdC5uZXQ+IHdyb3RlOgo+IAo+ID4g Qm9yaXMgQnJlemlsbG9uIDxib3Jpcy5icmV6aWxsb25AYm9vdGxpbi5jb20+IHdyaXRlczoKPiA+ ICAgCj4gPiA+IFdoZW4gdXNpbmcgdW5pLXBsYW5hciBmb3JtYXRzIChsaWtlIFJHQiksIHRoZSBz Y2FsaW5nIHBhcmFtZXRlcnMgYXJlCj4gPiA+IHN0b3JlZCBpbiBwbGFuZSAwLCBub3QgcGxhbmUg MS4KPiA+ID4KPiA+ID4gRml4ZXM6IGZjMDQwMjNmYWZlYyAoImRybS92YzQ6IEFkZCBzdXBwb3J0 IGZvciBZVVYgcGxhbmVzLiIpCj4gPiA+IENjOiBzdGFibGVAdmdlci5rZXJuZWwub3JnCj4gPiA+ IFNpZ25lZC1vZmYtYnk6IEJvcmlzIEJyZXppbGxvbiA8Ym9yaXMuYnJlemlsbG9uQGJvb3RsaW4u Y29tPiAgICAKPiA+IAo+ID4gUmV2aWV3ZWQtYnk6IEVyaWMgQW5ob2x0IDxlcmljQGFuaG9sdC5u ZXQ+Cj4gPiAKPiA+IExvb2tpbmcgYXQgdGhlIG90aGVyIGJyYW5jaCwgZGlkIEkgZ2V0IHRoZSBz Y2wwL3NjbDEgYmFja3dhcmRzPyAgSFZTCj4gPiBkb2NzIHNheSBmb3Igbm9uLTQ0NCBZQ0JDUjog IkluIHRoZXNlIGNhc2VzIENoYW5uZWwgMCBwZXJmb3JtcyBZL0FscGhhCj4gPiBzY2FsaW5nIGFu ZCBDaGFubmVsIDEgcGVyZm9ybXMgQ0IvQ1Igc2NhbGluZyBhbmQgc2hvdWxkIGJlIGNvbmZpZ3Vy ZWQgYXMKPiA+IGFwcHJvcHJpYXRlLiIgIAo+IAo+IERpZG4ndCB0ZXN0LCBidXQgSSB0aGluayBy ZXNjYWxpbmcgb2YgbXVsdGktcGxhbmFyIGZvcm1hdCBpcyBjb3JyZWN0LgoKSSBqdXN0IHRlc3Rl ZCwgYW5kIEkgY29uZmlybSB0aGUgb3RoZXIgYnJhbmNoIGlzIGNvcnJlY3QuCl9fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxp c3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNr dG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.bootlin.com ([62.4.15.54]:47524 "EHLO mail.bootlin.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933383AbeEIHn0 (ORCPT ); Wed, 9 May 2018 03:43:26 -0400 Date: Wed, 9 May 2018 09:43:24 +0200 From: Boris Brezillon To: Eric Anholt Cc: David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org, stable@vger.kernel.org Subject: Re: [PATCH] drm/vc4: Fix scaling of uni-planar formats Message-ID: <20180509094324.2139ce11@bbrezillon> In-Reply-To: <20180507181102.47ea0060@bbrezillon> References: <20180507121303.5610-1-boris.brezillon@bootlin.com> <87vabz1mu9.fsf@anholt.net> <20180507181102.47ea0060@bbrezillon> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: stable-owner@vger.kernel.org List-ID: On Mon, 7 May 2018 18:11:02 +0200 Boris Brezillon wrote: > On Mon, 07 May 2018 08:56:14 -0700 > Eric Anholt wrote: > > > Boris Brezillon writes: > > > > > When using uni-planar formats (like RGB), the scaling parameters are > > > stored in plane 0, not plane 1. > > > > > > Fixes: fc04023fafec ("drm/vc4: Add support for YUV planes.") > > > Cc: stable@vger.kernel.org > > > Signed-off-by: Boris Brezillon > > > > Reviewed-by: Eric Anholt > > > > Looking at the other branch, did I get the scl0/scl1 backwards? HVS > > docs say for non-444 YCBCR: "In these cases Channel 0 performs Y/Alpha > > scaling and Channel 1 performs CB/CR scaling and should be configured as > > appropriate." > > Didn't test, but I think rescaling of multi-planar format is correct. I just tested, and I confirm the other branch is correct.