From mboxrd@z Thu Jan 1 00:00:00 1970 From: anders.roxell at linaro.org (Anders Roxell) Date: Wed, 9 May 2018 11:46:52 +0200 Subject: [PATCH] selftests: memory-hotplug: delete RUN_TESTS and EMIT_TESTS overrides In-Reply-To: <20180502211848.22404-3-shuah@kernel.org> References: <20180502211848.22404-1-shuah@kernel.org> <20180502211848.22404-3-shuah@kernel.org> Message-ID: <20180509094652.GB10043@localhost.localdomain> On 2018-05-02 15:18, Shuah Khan (Samsung OSG) wrote: > Delete RUN_TESTS and EMIT_TESTS overrides and use common defines in > lib.mk. Common defines work after making the change the test to run > with ratio=2 as the default mode to be able to invoke the test without > the "-r 2" argument from the common RUN_TESTS and EMIT_TESTS. > > The run_full_tests target now calls the test with "-r 10". > > Signed-off-by: Shuah Khan (Samsung OSG) Reviewed-by: Anders Roxell > --- > tools/testing/selftests/memory-hotplug/Makefile | 5 +---- > tools/testing/selftests/memory-hotplug/mem-on-off-test.sh | 3 ++- > 2 files changed, 3 insertions(+), 5 deletions(-) > > diff --git a/tools/testing/selftests/memory-hotplug/Makefile b/tools/testing/selftests/memory-hotplug/Makefile > index 686da510f989..e0a625e34f40 100644 > --- a/tools/testing/selftests/memory-hotplug/Makefile > +++ b/tools/testing/selftests/memory-hotplug/Makefile > @@ -4,11 +4,8 @@ all: > include ../lib.mk > > TEST_PROGS := mem-on-off-test.sh > -override RUN_TESTS := @./mem-on-off-test.sh -r 2 && echo "selftests: memory-hotplug [PASS]" || echo "selftests: memory-hotplug [FAIL]" > - > -override EMIT_TESTS := echo "$(subst @,,$(RUN_TESTS))" > > run_full_test: > - @/bin/bash ./mem-on-off-test.sh && echo "memory-hotplug selftests: [PASS]" || echo "memory-hotplug selftests: [FAIL]" > + @/bin/bash ./mem-on-off-test.sh -r 10 && echo "memory-hotplug selftests: [PASS]" || echo "memory-hotplug selftests: [FAIL]" > > clean: > diff --git a/tools/testing/selftests/memory-hotplug/mem-on-off-test.sh b/tools/testing/selftests/memory-hotplug/mem-on-off-test.sh > index ae2c790d0880..ff4991704d07 100755 > --- a/tools/testing/selftests/memory-hotplug/mem-on-off-test.sh > +++ b/tools/testing/selftests/memory-hotplug/mem-on-off-test.sh > @@ -133,7 +133,8 @@ offline_memory_expect_fail() > > error=-12 > priority=0 > -ratio=10 > +# Run with default of ratio=2 for Kselftest run > +ratio=2 > retval=0 > > while getopts e:hp:r: opt; do > -- > 2.14.1 > -- To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in the body of a message to majordomo at vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: anders.roxell@linaro.org (Anders Roxell) Date: Wed, 9 May 2018 11:46:52 +0200 Subject: [PATCH] selftests: memory-hotplug: delete RUN_TESTS and EMIT_TESTS overrides In-Reply-To: <20180502211848.22404-3-shuah@kernel.org> References: <20180502211848.22404-1-shuah@kernel.org> <20180502211848.22404-3-shuah@kernel.org> Message-ID: <20180509094652.GB10043@localhost.localdomain> Content-Type: text/plain; charset="UTF-8" Message-ID: <20180509094652.AVY8fmHiHEvuxHhW6APb_GOrqMZv-lbRBcbfgFw15jQ@z> On 2018-05-02 15:18, Shuah Khan (Samsung OSG) wrote: > Delete RUN_TESTS and EMIT_TESTS overrides and use common defines in > lib.mk. Common defines work after making the change the test to run > with ratio=2 as the default mode to be able to invoke the test without > the "-r 2" argument from the common RUN_TESTS and EMIT_TESTS. > > The run_full_tests target now calls the test with "-r 10". > > Signed-off-by: Shuah Khan (Samsung OSG) Reviewed-by: Anders Roxell > --- > tools/testing/selftests/memory-hotplug/Makefile | 5 +---- > tools/testing/selftests/memory-hotplug/mem-on-off-test.sh | 3 ++- > 2 files changed, 3 insertions(+), 5 deletions(-) > > diff --git a/tools/testing/selftests/memory-hotplug/Makefile b/tools/testing/selftests/memory-hotplug/Makefile > index 686da510f989..e0a625e34f40 100644 > --- a/tools/testing/selftests/memory-hotplug/Makefile > +++ b/tools/testing/selftests/memory-hotplug/Makefile > @@ -4,11 +4,8 @@ all: > include ../lib.mk > > TEST_PROGS := mem-on-off-test.sh > -override RUN_TESTS := @./mem-on-off-test.sh -r 2 && echo "selftests: memory-hotplug [PASS]" || echo "selftests: memory-hotplug [FAIL]" > - > -override EMIT_TESTS := echo "$(subst @,,$(RUN_TESTS))" > > run_full_test: > - @/bin/bash ./mem-on-off-test.sh && echo "memory-hotplug selftests: [PASS]" || echo "memory-hotplug selftests: [FAIL]" > + @/bin/bash ./mem-on-off-test.sh -r 10 && echo "memory-hotplug selftests: [PASS]" || echo "memory-hotplug selftests: [FAIL]" > > clean: > diff --git a/tools/testing/selftests/memory-hotplug/mem-on-off-test.sh b/tools/testing/selftests/memory-hotplug/mem-on-off-test.sh > index ae2c790d0880..ff4991704d07 100755 > --- a/tools/testing/selftests/memory-hotplug/mem-on-off-test.sh > +++ b/tools/testing/selftests/memory-hotplug/mem-on-off-test.sh > @@ -133,7 +133,8 @@ offline_memory_expect_fail() > > error=-12 > priority=0 > -ratio=10 > +# Run with default of ratio=2 for Kselftest run > +ratio=2 > retval=0 > > while getopts e:hp:r: opt; do > -- > 2.14.1 > -- To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in the body of a message to majordomo at vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934278AbeEIKRE (ORCPT ); Wed, 9 May 2018 06:17:04 -0400 Received: from mail-lf0-f67.google.com ([209.85.215.67]:46784 "EHLO mail-lf0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934126AbeEIKRB (ORCPT ); Wed, 9 May 2018 06:17:01 -0400 X-Google-Smtp-Source: AB8JxZolGE+iXylTJNqC+HxCkki6+RMwi443zFof+RB5V//cwsujUR08Ztwv65Xi6sdtMUlw6g0vWw== Date: Wed, 9 May 2018 11:46:52 +0200 From: Anders Roxell To: "Shuah Khan (Samsung OSG)" Cc: lei.yang@windriver.com, po-hsu.lin@canonical.com, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] selftests: memory-hotplug: delete RUN_TESTS and EMIT_TESTS overrides Message-ID: <20180509094652.GB10043@localhost.localdomain> References: <20180502211848.22404-1-shuah@kernel.org> <20180502211848.22404-3-shuah@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20180502211848.22404-3-shuah@kernel.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2018-05-02 15:18, Shuah Khan (Samsung OSG) wrote: > Delete RUN_TESTS and EMIT_TESTS overrides and use common defines in > lib.mk. Common defines work after making the change the test to run > with ratio=2 as the default mode to be able to invoke the test without > the "-r 2" argument from the common RUN_TESTS and EMIT_TESTS. > > The run_full_tests target now calls the test with "-r 10". > > Signed-off-by: Shuah Khan (Samsung OSG) Reviewed-by: Anders Roxell > --- > tools/testing/selftests/memory-hotplug/Makefile | 5 +---- > tools/testing/selftests/memory-hotplug/mem-on-off-test.sh | 3 ++- > 2 files changed, 3 insertions(+), 5 deletions(-) > > diff --git a/tools/testing/selftests/memory-hotplug/Makefile b/tools/testing/selftests/memory-hotplug/Makefile > index 686da510f989..e0a625e34f40 100644 > --- a/tools/testing/selftests/memory-hotplug/Makefile > +++ b/tools/testing/selftests/memory-hotplug/Makefile > @@ -4,11 +4,8 @@ all: > include ../lib.mk > > TEST_PROGS := mem-on-off-test.sh > -override RUN_TESTS := @./mem-on-off-test.sh -r 2 && echo "selftests: memory-hotplug [PASS]" || echo "selftests: memory-hotplug [FAIL]" > - > -override EMIT_TESTS := echo "$(subst @,,$(RUN_TESTS))" > > run_full_test: > - @/bin/bash ./mem-on-off-test.sh && echo "memory-hotplug selftests: [PASS]" || echo "memory-hotplug selftests: [FAIL]" > + @/bin/bash ./mem-on-off-test.sh -r 10 && echo "memory-hotplug selftests: [PASS]" || echo "memory-hotplug selftests: [FAIL]" > > clean: > diff --git a/tools/testing/selftests/memory-hotplug/mem-on-off-test.sh b/tools/testing/selftests/memory-hotplug/mem-on-off-test.sh > index ae2c790d0880..ff4991704d07 100755 > --- a/tools/testing/selftests/memory-hotplug/mem-on-off-test.sh > +++ b/tools/testing/selftests/memory-hotplug/mem-on-off-test.sh > @@ -133,7 +133,8 @@ offline_memory_expect_fail() > > error=-12 > priority=0 > -ratio=10 > +# Run with default of ratio=2 for Kselftest run > +ratio=2 > retval=0 > > while getopts e:hp:r: opt; do > -- > 2.14.1 >