From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rodrigo Vivi Subject: Re: [RFC] drm/i915/dp: optimize eDP 1.4+ link config fast and narrow Date: Wed, 9 May 2018 05:21:25 -0700 Message-ID: <20180509122125.GB2552@intel.com> References: <20180509071321.28563-1-jani.nikula@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7DDBC6E002 for ; Wed, 9 May 2018 12:21:27 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20180509071321.28563-1-jani.nikula@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Jani Nikula , "Atwood, Matthew S" Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCBNYXkgMDksIDIwMTggYXQgMTA6MTM6MjFBTSArMDMwMCwgSmFuaSBOaWt1bGEgd3Jv dGU6Cj4gV2UndmUgb3B0ZWQgdG8gdXNlIHRoZSBtYXhpbXVtIGxpbmsgcmF0ZSBhbmQgbGFuZSBj b3VudCBmb3IgZURQIHBhbmVscywKPiBiZWNhdXNlIHR5cGljYWxseSB0aGUgbWF4aW11bSBzdXBw b3J0ZWQgY29uZmlndXJhdGlvbiByZXBvcnRlZCBieSB0aGUKPiBwYW5lbCBoYXMgbWF0Y2hlZCB0 aGUgbmF0aXZlIHJlc29sdXRpb24gcmVxdWlyZW1lbnRzIG9mIHRoZSBwYW5lbCwgYW5kCj4gb3B0 aW1pemluZyB0aGUgbGluayBoYXMgbGVhZCB0byBwcm9ibGVtcy4KPiAKPiBXaXRoIGVEUCAxLjQg cmF0ZSBzZWxlY3QgbWV0aG9kIGFuZCBEU0MgZmVhdHVyZXMsIHRoaXMgaXMgZGVjcmVhc2luZ2x5 Cj4gdGhlIGNhc2UuIFRoZXJlJ3MgYSBuZWVkIHRvIG9wdGltaXplIHRoZSBsaW5rIHBhcmFtZXRl cnMuIE1vcmVvdmVyLAo+IGFscmVhZHkgZURQIDEuMyBzdGF0ZXMgZmFzdCBsaW5rIHdpdGggZmV3 ZXIgbGFuZXMgaXMgcHJlZmVycmVkIG92ZXIgdGhlCj4gd2lkZSBhbmQgc2xvdy4gKFdpZGUgYW5k IHNsb3cgc2hvdWxkIHN0aWxsIGJlIG1vcmUgcmVsaWFibGUgZm9yIGxvbmdlcgo+IGNhYmxlIGxl bmd0aHMuKQo+IAo+IEFkZGl0aW9uYWxseSwgdGhlcmUgaGF2ZSBiZWVuIHJlcG9ydHMgb2YgcGFu ZWxzIGZhaWxpbmcgb24gYXJiaXRyYXJ5Cj4gbGluayBjb25maWd1cmF0aW9ucywgYWx0aG91Z2gg YXJndWFibHkgYWxsIGNvbmZpZ3VyYXRpb25zIHRoZXkgY2xhaW0gdG8KPiBzdXBwb3J0IHNob3Vs ZCB3b3JrLgo+IAo+IE9wdGltaXplIGVEUCAxLjQrIGxpbmsgY29uZmlnIGZhc3QgYW5kIG5hcnJv dy4KPiAKPiBTaWRlIG5vdGU6IFRoZSBpbXBsZW1lbnRhdGlvbiBoYXMgYSBuZWFyIGR1cGxpY2F0 ZSBvZiB0aGUgbGluayBjb25maWcKPiBmdW5jdGlvbiwgd2l0aCBqdXN0IHRoZSB0d28gaW5uZXIg Zm9yIGxvb3BzIHR1cm5lZCBpbnNpZGUgb3V0LiBQZXJoYXBzCj4gdGhlcmUnZCBiZSBhIHdheSB0 byBtYWtlIHRoaXMsIHNheSwgbW9yZSB0YWJsZSBkcml2ZW4gdG8gcmVkdWNlIHRoZQo+IGR1cGxp Y2F0aW9uLCBidXQgc2VlbXMgbGlrZSB0aGF0IHdvdWxkIGxlYWQgdG8gZHVwbGljYXRpb24gaW4g dGhlIHRhYmxlCj4gZ2VuZXJhdGlvbi4gV2UnbGwgYWxzbyBoYXZlIHRvIHNlZSBob3cgdGhlIGxp bmsgY29uZmlnIG9wdGltaXphdGlvbiBmb3IKPiBEU0MgdHVybnMgb3V0Lgo+IAo+IENjOiBWaWxs ZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwuY29tPgo+IENjOiBNYW5hc2kg TmF2YXJlIDxtYW5hc2kuZC5uYXZhcmVAaW50ZWwuY29tPgo+IENjOiBSb2RyaWdvIFZpdmkgPHJv ZHJpZ28udml2aUBpbnRlbC5jb20+CgpDYzogTWF0dCBBdHdvb2QgPG1hdHRoZXcucy5hdHdvb2RA aW50ZWwuY29tPgoKSSBiZWxpZXZlIE1hdHQgaXMgaW50ZXJlc3RlZCBvbiB0aGlzIGFuZCBrbm93 IHdobyBjb3VsZCB0ZXN0IHRoaXMgZm9yIHVzLgoKPiBCdWd6aWxsYTogaHR0cHM6Ly9idWdzLmZy ZWVkZXNrdG9wLm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA1MjY3Cj4gU2lnbmVkLW9mZi1ieTogSmFu aSBOaWt1bGEgPGphbmkubmlrdWxhQGludGVsLmNvbT4KClRoaXMgbWF0Y2hlcyBteSB1bmRlcnN0 YW5kIG9mIHRoZSBlRFAgMS40IHNwZWMgSSBiZWxpZXZlIHRoaXMgaXMgdGhlCndheSB0byBnbywg c28KCkFja2VkLWJ5OiBSb2RyaWdvIFZpdmkgPHJvZHJpZ28udml2aUBpbnRlbC5jb20+CgpidXQg cHJvYmFibHkgYmV0dGVyIHRvIGdldCBhIHByb3BlciByZXZpZXcgYW5kIHdhaXQgZm9yIHNvbWVv bmUKdG8gdGVzdC4uLgoKPiAKPiAtLS0KPiAKPiBVbnRlc3RlZC4gSXQncyBwb3NzaWJsZSB0aGlz IGhlbHBzIHRoZSByZWZlcmVuY2VkIGJ1Zy4gVGhlIGRvd25zaWRlIGlzCj4gdGhhdCB0aGlzIHBh dGNoIGhhcyBhIGJ1bmNoIG9mIGRlcGVuZGVuY2llcyB0aGF0IGFyZSB0b28gbXVjaCB0bwo+IGJh Y2twb3J0IHRvIHN0YWJsZSBrZXJuZWxzLiBJZiB0aGUgcGF0Y2ggd29ya3MsIHdlIG1heSBuZWVk IHRvIGNvbnNpZGVyCj4gaGFja2luZyB0b2dldGhlciBhbiB1Z2xpZXIgYmFja3BvcnQuCj4gLS0t Cj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwLmMgfCA3MyArKysrKysrKysrKysrKysr KysrKysrKysrKysrKysrKysrLS0tLS0tLQo+ICAxIGZpbGUgY2hhbmdlZCwgNjIgaW5zZXJ0aW9u cygrKSwgMTEgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9p OTE1L2ludGVsX2RwLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcC5jCj4gaW5kZXgg ZGRlOTJlNGFmNWQzLi4xZWM2Mjk2NWVjZTMgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJt L2k5MTUvaW50ZWxfZHAuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwLmMK PiBAQCAtMTc2OCw2ICsxNzY4LDQyIEBAIGludGVsX2RwX2NvbXB1dGVfbGlua19jb25maWdfd2lk ZShzdHJ1Y3QgaW50ZWxfZHAgKmludGVsX2RwLAo+ICAJcmV0dXJuIGZhbHNlOwo+ICB9Cj4gIAo+ ICsvKiBPcHRpbWl6ZSBsaW5rIGNvbmZpZyBpbiBvcmRlcjogbWF4IGJwcCwgbWluIGxhbmVzLCBt aW4gY2xvY2sgKi8KPiArc3RhdGljIGJvb2wKPiAraW50ZWxfZHBfY29tcHV0ZV9saW5rX2NvbmZp Z19mYXN0KHN0cnVjdCBpbnRlbF9kcCAqaW50ZWxfZHAsCj4gKwkJCQkgIHN0cnVjdCBpbnRlbF9j cnRjX3N0YXRlICpwaXBlX2NvbmZpZywKPiArCQkJCSAgY29uc3Qgc3RydWN0IGxpbmtfY29uZmln X2xpbWl0cyAqbGltaXRzKQo+ICt7Cj4gKwlzdHJ1Y3QgZHJtX2Rpc3BsYXlfbW9kZSAqYWRqdXN0 ZWRfbW9kZSA9ICZwaXBlX2NvbmZpZy0+YmFzZS5hZGp1c3RlZF9tb2RlOwo+ICsJaW50IGJwcCwg Y2xvY2ssIGxhbmVfY291bnQ7Cj4gKwlpbnQgbW9kZV9yYXRlLCBsaW5rX2Nsb2NrLCBsaW5rX2F2 YWlsOwo+ICsKPiArCWZvciAoYnBwID0gbGltaXRzLT5tYXhfYnBwOyBicHAgPj0gbGltaXRzLT5t aW5fYnBwOyBicHAgLT0gMiAqIDMpIHsKPiArCQltb2RlX3JhdGUgPSBpbnRlbF9kcF9saW5rX3Jl cXVpcmVkKGFkanVzdGVkX21vZGUtPmNydGNfY2xvY2ssCj4gKwkJCQkJCSAgIGJwcCk7Cj4gKwo+ ICsJCWZvciAobGFuZV9jb3VudCA9IGxpbWl0cy0+bWluX2xhbmVfY291bnQ7Cj4gKwkJICAgICBs YW5lX2NvdW50IDw9IGxpbWl0cy0+bWF4X2xhbmVfY291bnQ7Cj4gKwkJICAgICBsYW5lX2NvdW50 IDw8PSAxKSB7Cj4gKwkJCWZvciAoY2xvY2sgPSBsaW1pdHMtPm1pbl9jbG9jazsgY2xvY2sgPD0g bGltaXRzLT5tYXhfY2xvY2s7IGNsb2NrKyspIHsKPiArCQkJCWxpbmtfY2xvY2sgPSBpbnRlbF9k cC0+Y29tbW9uX3JhdGVzW2Nsb2NrXTsKPiArCQkJCWxpbmtfYXZhaWwgPSBpbnRlbF9kcF9tYXhf ZGF0YV9yYXRlKGxpbmtfY2xvY2ssCj4gKwkJCQkJCQkJICAgIGxhbmVfY291bnQpOwo+ICsKPiAr CQkJCWlmIChtb2RlX3JhdGUgPD0gbGlua19hdmFpbCkgewo+ICsJCQkJCXBpcGVfY29uZmlnLT5s YW5lX2NvdW50ID0gbGFuZV9jb3VudDsKPiArCQkJCQlwaXBlX2NvbmZpZy0+cGlwZV9icHAgPSBi cHA7Cj4gKwkJCQkJcGlwZV9jb25maWctPnBvcnRfY2xvY2sgPSBsaW5rX2Nsb2NrOwo+ICsKPiAr CQkJCQlyZXR1cm4gdHJ1ZTsKPiArCQkJCX0KPiArCQkJfQo+ICsJCX0KPiArCX0KPiArCj4gKwly ZXR1cm4gZmFsc2U7Cj4gK30KPiArCj4gIHN0YXRpYyBib29sCj4gIGludGVsX2RwX2NvbXB1dGVf bGlua19jb25maWcoc3RydWN0IGludGVsX2VuY29kZXIgKmVuY29kZXIsCj4gIAkJCSAgICAgc3Ry dWN0IGludGVsX2NydGNfc3RhdGUgKnBpcGVfY29uZmlnKQo+IEBAIC0xNzkyLDEzICsxODI4LDE1 IEBAIGludGVsX2RwX2NvbXB1dGVfbGlua19jb25maWcoc3RydWN0IGludGVsX2VuY29kZXIgKmVu Y29kZXIsCj4gIAlsaW1pdHMubWluX2JwcCA9IDYgKiAzOwo+ICAJbGltaXRzLm1heF9icHAgPSBp bnRlbF9kcF9jb21wdXRlX2JwcChpbnRlbF9kcCwgcGlwZV9jb25maWcpOwo+ICAKPiAtCWlmIChp bnRlbF9kcF9pc19lZHAoaW50ZWxfZHApKSB7Cj4gKwlpZiAoaW50ZWxfZHBfaXNfZWRwKGludGVs X2RwKSAmJiBpbnRlbF9kcC0+ZWRwX2RwY2RbMF0gPCBEUF9FRFBfMTQpIHsKPiAgCQkvKgo+ICAJ CSAqIFVzZSB0aGUgbWF4aW11bSBjbG9jayBhbmQgbnVtYmVyIG9mIGxhbmVzIHRoZSBlRFAgcGFu ZWwKPiAtCQkgKiBhZHZlcnRpemVzIGJlaW5nIGNhcGFibGUgb2YuIFRoZSBwYW5lbHMgYXJlIGdl bmVyYWxseQo+IC0JCSAqIGRlc2lnbmVkIHRvIHN1cHBvcnQgb25seSBhIHNpbmdsZSBjbG9jayBh bmQgbGFuZQo+IC0JCSAqIGNvbmZpZ3VyYXRpb24sIGFuZCB0eXBpY2FsbHkgdGhlc2UgdmFsdWVz IGNvcnJlc3BvbmQgdG8gdGhlCj4gLQkJICogbmF0aXZlIHJlc29sdXRpb24gb2YgdGhlIHBhbmVs Lgo+ICsJCSAqIGFkdmVydGl6ZXMgYmVpbmcgY2FwYWJsZSBvZi4gVGhlIGVEUCAxLjMgYW5kIGVh cmxpZXIgcGFuZWxzCj4gKwkJICogYXJlIGdlbmVyYWxseSBkZXNpZ25lZCB0byBzdXBwb3J0IG9u bHkgYSBzaW5nbGUgY2xvY2sgYW5kCj4gKwkJICogbGFuZSBjb25maWd1cmF0aW9uLCBhbmQgdHlw aWNhbGx5IHRoZXNlIHZhbHVlcyBjb3JyZXNwb25kIHRvCj4gKwkJICogdGhlIG5hdGl2ZSByZXNv bHV0aW9uIG9mIHRoZSBwYW5lbC4gV2l0aCBlRFAgMS40IHJhdGUgc2VsZWN0Cj4gKwkJICogYW5k IERTQywgdGhpcyBpcyBkZWNyZWFzaW5nbHkgdGhlIGNhc2UsIGFuZCB3ZSBuZWVkIHRvIGJlCj4g KwkJICogYWJsZSB0byBzZWxlY3QgbGVzcyB0aGFuIG1heGltdW0gbGluayBjb25maWcuCj4gIAkJ ICovCj4gIAkJbGltaXRzLm1pbl9sYW5lX2NvdW50ID0gbGltaXRzLm1heF9sYW5lX2NvdW50Owo+ ICAJCWxpbWl0cy5taW5fY2xvY2sgPSBsaW1pdHMubWF4X2Nsb2NrOwo+IEBAIC0xODEyLDEyICsx ODUwLDI1IEBAIGludGVsX2RwX2NvbXB1dGVfbGlua19jb25maWcoc3RydWN0IGludGVsX2VuY29k ZXIgKmVuY29kZXIsCj4gIAkJICAgICAgaW50ZWxfZHAtPmNvbW1vbl9yYXRlc1tsaW1pdHMubWF4 X2Nsb2NrXSwKPiAgCQkgICAgICBsaW1pdHMubWF4X2JwcCwgYWRqdXN0ZWRfbW9kZS0+Y3J0Y19j bG9jayk7Cj4gIAo+IC0JLyoKPiAtCSAqIE9wdGltaXplIGZvciBzbG93IGFuZCB3aWRlLiBUaGlz IGlzIHRoZSBwbGFjZSB0byBhZGQgYWx0ZXJuYXRpdmUKPiAtCSAqIG9wdGltaXphdGlvbiBwb2xp Y3kuCj4gLQkgKi8KPiAtCWlmICghaW50ZWxfZHBfY29tcHV0ZV9saW5rX2NvbmZpZ193aWRlKGlu dGVsX2RwLCBwaXBlX2NvbmZpZywgJmxpbWl0cykpCj4gLQkJcmV0dXJuIGZhbHNlOwo+ICsJaWYg KGludGVsX2RwX2lzX2VkcChpbnRlbF9kcCkpIHsKPiArCQkvKgo+ICsJCSAqIE9wdGltaXplIGZv ciBmYXN0IGFuZCBuYXJyb3cuIGVEUCAxLjMgc2VjdGlvbiAzLjMgYW5kIGVEUCAxLjQKPiArCQkg KiBzZWN0aW9uIEEuMTogIkl0IGlzIHJlY29tbWVuZGVkIHRoYXQgdGhlIG1pbmltdW0gbnVtYmVy IG9mCj4gKwkJICogbGFuZXMgYmUgdXNlZCwgdXNpbmcgdGhlIG1pbmltdW0gbGluayByYXRlIGFs bG93ZWQgZm9yIHRoYXQKPiArCQkgKiBsYW5lIGNvbmZpZ3VyYXRpb24uIgo+ICsJCSAqCj4gKwkJ ICogTm90ZSB0aGF0IHdlIHVzZSB0aGUgbWF4IGNsb2NrIGFuZCBsYW5lIGNvdW50IGZvciBlRFAg MS4zIGFuZAo+ICsJCSAqIGVhcmxpZXIsIGFuZCBmYXN0IHZzLiB3aWRlIGlzIGlycmVsZXZhbnQu Cj4gKwkJICovCj4gKwkJaWYgKCFpbnRlbF9kcF9jb21wdXRlX2xpbmtfY29uZmlnX2Zhc3QoaW50 ZWxfZHAsIHBpcGVfY29uZmlnLAo+ICsJCQkJCQkgICAgICAgJmxpbWl0cykpCj4gKwkJCXJldHVy biBmYWxzZTsKPiArCX0gZWxzZSB7Cj4gKwkJLyogT3B0aW1pemUgZm9yIHNsb3cgYW5kIHdpZGUu ICovCj4gKwkJaWYgKCFpbnRlbF9kcF9jb21wdXRlX2xpbmtfY29uZmlnX3dpZGUoaW50ZWxfZHAs IHBpcGVfY29uZmlnLAo+ICsJCQkJCQkgICAgICAgJmxpbWl0cykpCj4gKwkJCXJldHVybiBmYWxz ZTsKPiArCX0KPiAgCj4gIAlEUk1fREVCVUdfS01TKCJEUCBsYW5lIGNvdW50ICVkIGNsb2NrICVk IGJwcCAlZFxuIiwKPiAgCQkgICAgICBwaXBlX2NvbmZpZy0+bGFuZV9jb3VudCwgcGlwZV9jb25m aWctPnBvcnRfY2xvY2ssCj4gLS0gCj4gMi4xMS4wCj4gCl9fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4 QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWls bWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=