From: Andrew Lunn <andrew@lunn.ch>
To: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel@savoirfairelinux.com, davem@davemloft.net,
f.fainelli@gmail.com
Subject: Re: [PATCH net-next 1/3] net: dsa: mv88e6xxx: add a cascade port op
Date: Wed, 9 May 2018 21:05:36 +0200 [thread overview]
Message-ID: <20180509190536.GD21718@lunn.ch> (raw)
In-Reply-To: <20180509153851.10207-2-vivien.didelot@savoirfairelinux.com>
On Wed, May 09, 2018 at 11:38:49AM -0400, Vivien Didelot wrote:
> Only the 88E6185 family has bits 15:12 Cascade Port bits in the Global
> Control 2 register. Hence inconsistent values are actually written in
> this register for other families.
>
> Add a .set_cascade_port operation to isolate the 88E6185 case, and call
> it from the device mapping setup function.
>
> Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
next prev parent reply other threads:[~2018-05-09 19:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-09 15:38 [PATCH net-next 0/3] net: dsa: mv88e6xxx: cleanup Global Control 2 register Vivien Didelot
2018-05-09 15:38 ` [PATCH net-next 1/3] net: dsa: mv88e6xxx: add a cascade port op Vivien Didelot
2018-05-09 19:05 ` Andrew Lunn [this message]
2018-05-09 15:38 ` [PATCH net-next 2/3] net: dsa: mv88e6xxx: set device number Vivien Didelot
2018-05-09 19:06 ` Andrew Lunn
2018-05-09 15:38 ` [PATCH net-next 3/3] net: dsa: mv88e6xxx: add RMU disable op Vivien Didelot
2018-05-09 19:08 ` Andrew Lunn
2018-05-10 20:13 ` [PATCH net-next 0/3] net: dsa: mv88e6xxx: cleanup Global Control 2 register David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180509190536.GD21718@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=kernel@savoirfairelinux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.