From: Halil Pasic <pasic@linux.ibm.com>
To: Cornelia Huck <cohuck@redhat.com>,
qemu-s390x@nongnu.org, qemu-devel@nongnu.org
Cc: Halil Pasic <pasic@linux.ibm.com>,
Dong Jia Shi <bjsdjshi@linux.ibm.com>,
"Jason J. Herne" <jjherne@linux.ibm.com>,
Pierre Morel <pmorel@linux.ibm.com>
Subject: [Qemu-devel] [PATCH 2/2] vfio-ccw: remove orb.c64 (64 bit data addresses) check
Date: Thu, 10 May 2018 02:07:12 +0200 [thread overview]
Message-ID: <20180510000712.6472-3-pasic@linux.ibm.com> (raw)
In-Reply-To: <20180510000712.6472-1-pasic@linux.ibm.com>
The vfio-ccw module does the check too, and there is actually no
technical obstacle for supporting fmt 1 idaws. Let us be ready for the
beautiful day when fmt 1 idaws become supported by the vfio-ccw kernel
module. QEMU does not have to do a thing for that, except not insisting
on this check.
Signed-off-by: Halil Pasic <pasic@linux.ibm.com>
Acked-by: Jason J. Herne <jjherne@linux.ibm.com>
Tested-by: Jason J. Herne <jjherne@linux.ibm.com>
---
hw/s390x/css.c | 11 -----------
1 file changed, 11 deletions(-)
diff --git a/hw/s390x/css.c b/hw/s390x/css.c
index 32f1b2820d..1554b4c2f5 100644
--- a/hw/s390x/css.c
+++ b/hw/s390x/css.c
@@ -1191,17 +1191,6 @@ static IOInstEnding sch_handle_start_func_passthrough(SubchDev *sch)
assert(orb != NULL);
p->intparm = orb->intparm;
}
-
- /*
- * Only support prefetch enable mode.
- * Only support 64bit addressing idal.
- */
- if (!(orb->ctrl0 & ORB_CTRL0_MASK_C64)) {
- warn_report("vfio-ccw requires PFCH and C64 flags set");
- sch_gen_unit_exception(sch);
- css_inject_io_interrupt(sch);
- return IOINST_CC_EXPECTED;
- }
return s390_ccw_cmd_request(sch);
}
--
2.16.3
next prev parent reply other threads:[~2018-05-10 0:09 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-10 0:07 [Qemu-devel] [PATCH 0/2] vfio-ccw: loosen orb flags checks Halil Pasic
2018-05-10 0:07 ` [Qemu-devel] [PATCH 1/2] vfio-ccw: add force unlimited prefetch property Halil Pasic
2018-05-14 12:18 ` Cornelia Huck
2018-05-14 12:40 ` Halil Pasic
2018-05-14 13:45 ` Cornelia Huck
2018-05-14 14:22 ` Halil Pasic
2018-05-14 16:04 ` Cornelia Huck
2018-05-16 16:42 ` [Qemu-devel] [qemu-s390x] " Halil Pasic
2018-05-17 14:21 ` Cornelia Huck
2018-05-17 18:02 ` Halil Pasic
2018-05-10 0:07 ` Halil Pasic [this message]
2018-05-14 12:19 ` [Qemu-devel] [PATCH 2/2] vfio-ccw: remove orb.c64 (64 bit data addresses) check Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180510000712.6472-3-pasic@linux.ibm.com \
--to=pasic@linux.ibm.com \
--cc=bjsdjshi@linux.ibm.com \
--cc=cohuck@redhat.com \
--cc=jjherne@linux.ibm.com \
--cc=pmorel@linux.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.