From: "Michael Büsch" <m@bues.ch>
To: "Rafał Miłecki" <zajec5@gmail.com>
Cc: "Kalle Valo" <kvalo@codeaurora.org>,
"Larry Finger" <larry.finger@lwfinger.net>,
"Matt Redfearn" <matt.redfearn@mips.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"Hauke Mehrtens" <hauke@hauke-m.de>,
LKML <linux-kernel@vger.kernel.org>,
"Rafał Miłecki" <rafal@milecki.pl>
Subject: Re: [PATCH 4.17 2/2] ssb: make SSB_PCICORE_HOSTMODE depend on SSB = y
Date: Thu, 10 May 2018 13:26:12 +0200 [thread overview]
Message-ID: <20180510132612.25c8c20e@wiggum> (raw)
In-Reply-To: <CACna6ryWUCnrw9w4yhfiNXFHy1hFjVV-BqH07i7DQqxq8FtjMw@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2057 bytes --]
On Thu, 10 May 2018 13:20:01 +0200
Rafał Miłecki <zajec5@gmail.com> wrote:
> On 10 May 2018 at 13:17, Michael Büsch <m@bues.ch> wrote:
> > On Thu, 10 May 2018 13:14:01 +0200
> > Rafał Miłecki <zajec5@gmail.com> wrote:
> >
> >> From: Rafał Miłecki <rafal@milecki.pl>
> >>
> >> SSB_PCICORE_HOSTMODE protects MIPS specific code that calls not exported
> >> symbols pcibios_enable_device and register_pci_controller. This code is
> >> supposed to be compiled only with ssb builtin.
> >>
> >> This fixes:
> >> ERROR: "pcibios_enable_device" [drivers/ssb/ssb.ko] undefined!
> >> ERROR: "register_pci_controller" [drivers/ssb/ssb.ko] undefined!
> >> make[1]: *** [scripts/Makefile.modpost:92: __modpost] Error 1
> >>
> >> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
> >> ---
> >> drivers/ssb/Kconfig | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/drivers/ssb/Kconfig b/drivers/ssb/Kconfig
> >> index b3f5cae98ea6..c574dd210500 100644
> >> --- a/drivers/ssb/Kconfig
> >> +++ b/drivers/ssb/Kconfig
> >> @@ -131,7 +131,7 @@ config SSB_DRIVER_PCICORE
> >>
> >> config SSB_PCICORE_HOSTMODE
> >> bool "Hostmode support for SSB PCI core"
> >> - depends on SSB_DRIVER_PCICORE && SSB_DRIVER_MIPS
> >> + depends on SSB_DRIVER_PCICORE && SSB_DRIVER_MIPS && SSB = y
> >> help
> >> PCIcore hostmode operation (external PCI bus).
> >>
> >
> >
> > I think we also need to depend on PCI_DRIVERS_LEGACY.
> > See the other patch that floats around.
>
> I believe it's already handled by SSB_PCIHOST_POSSIBLE's dependency on
> PCI_DRIVERS_LEGACY.
That dependency seems to be wrong there.
Was it added among some other "let's just unbreak some random
build" change as well?
SSB_PCIHOST enables support for SSB on top of PCI. (Which is 99% of it
uses). I don't see how this uses the legacy API.
SSB_PCICORE_HOSTMODE enables PCI on top of SSB. Which is a MIPS corner
case. This uses the legacy MIPS API to register a PCI bus.
--
Michael
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2018-05-10 11:26 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-10 11:14 [PATCH 4.17 1/2] Revert "ssb: Prevent build of PCI host features in module" Rafał Miłecki
2018-05-10 11:14 ` [PATCH 4.17 2/2] ssb: make SSB_PCICORE_HOSTMODE depend on SSB = y Rafał Miłecki
2018-05-10 11:17 ` Michael Büsch
2018-05-10 11:20 ` Rafał Miłecki
2018-05-10 11:20 ` Rafał Miłecki
2018-05-10 11:26 ` Michael Büsch [this message]
2018-05-10 11:35 ` Matt Redfearn
2018-05-10 11:35 ` Rafał Miłecki
2018-05-10 11:35 ` Rafał Miłecki
2018-05-10 16:07 ` Larry Finger
2018-05-11 10:18 ` Kalle Valo
2018-05-11 10:18 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180510132612.25c8c20e@wiggum \
--to=m@bues.ch \
--cc=hauke@hauke-m.de \
--cc=kvalo@codeaurora.org \
--cc=larry.finger@lwfinger.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=matt.redfearn@mips.com \
--cc=rafal@milecki.pl \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.