From: Jeremy Allison <jra@samba.org>
To: ronnie sahlberg <ronniesahlberg@gmail.com>
Cc: Steve French <smfrench@gmail.com>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
CIFS <linux-cifs@vger.kernel.org>,
Pavel Shilovsky <pavel.shilovsky@gmail.com>,
samba-technical <samba-technical@lists.samba.org>,
jra@samba.org
Subject: Re: [PATCH] cifs/smb3: directory sync should not return an error
Date: Thu, 10 May 2018 15:12:48 -0700 [thread overview]
Message-ID: <20180510221248.GA203322@jra3> (raw)
In-Reply-To: <CAN05THQPHAGYPipJ6TERhcrW55vUBn-edjBr6ZRKQjd0_c3VPw@mail.gmail.com>
On Fri, May 11, 2018 at 08:08:46AM +1000, ronnie sahlberg wrote:
> SMB2 FLUSH ?
>
> MS-SMB2.pdf is pretty clear that FLUSH can only be used on files or pipes.
> If we start using it for directory handles we would need some
> clarifications about this use in the spec.
Yes. MS-SMB2 is also wrong :-).
I have test code that proves FLUSH works against any directory
handle opened with FILE_ADD|DIRECTORY_ADD access mask granted.
(Steve thought this might be special cased to just the root
directory handle on a share, this turns out not to be the
case - any directory handle with the required access works
OK).
> I would wait until MS-SMB2 is updated before we start sending FLUSH on
> directory handles.
We need to deal with the protocol as it really is,
not as the documentation would like it to be :-).
Jeremy.
next prev parent reply other threads:[~2018-05-10 22:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-10 16:04 [PATCH] cifs/smb3: directory sync should not return an error Steve French
2018-05-10 16:37 ` Jeremy Allison
2018-05-10 17:11 ` Pavel Shilovsky
2018-05-10 18:48 ` Jeremy Allison
2018-05-10 20:28 ` Steve French
2018-05-10 21:56 ` Steve French
2018-05-10 22:08 ` ronnie sahlberg
2018-05-10 22:12 ` Jeremy Allison [this message]
2018-05-10 22:25 ` Steve French
2018-05-10 23:06 ` Jeremy Allison
2018-05-10 21:01 ` ronnie sahlberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180510221248.GA203322@jra3 \
--to=jra@samba.org \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=pavel.shilovsky@gmail.com \
--cc=ronniesahlberg@gmail.com \
--cc=samba-technical@lists.samba.org \
--cc=smfrench@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.