From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH v2 2/4] drm/vc4: Take underscan setup into account when updating planes Date: Fri, 11 May 2018 18:34:50 +0300 Message-ID: <20180511153450.GS23723@intel.com> References: <20180511145919.22447-1-boris.brezillon@bootlin.com> <20180511145919.22447-3-boris.brezillon@bootlin.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20180511145919.22447-3-boris.brezillon-LDxbnhwyfcJBDgjK7y7TUQ@public.gmane.org> List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: Boris Brezillon Cc: David Airlie , nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, Daniel Vetter , Alex Deucher , Christian =?iso-8859-1?Q?K=F6nig?= , Ben Skeggs T24gRnJpLCBNYXkgMTEsIDIwMTggYXQgMDQ6NTk6MTdQTSArMDIwMCwgQm9yaXMgQnJlemlsbG9u IHdyb3RlOgo+IEFwcGx5aW5nIGFuIHVuZGVyc2NhbiBzZXR1cCBpcyBqdXN0IGEgbWF0dGVyIG9m IHNjYWxpbmcgYWxsIHBsYW5lcwo+IGFwcHJvcHJpYXRlbHkgYW5kIGFkanVzdGluZyB0aGUgQ1JU QyBYL1kgb2Zmc2V0IHRvIGFjY291bnQgZm9yIHRoZQo+IGhvcml6b250YWwgYW5kIHZlcnRpY2Fs IGJvcmRlci4KPiAKPiBDcmVhdGUgYW4gdmM0X3BsYW5lX3VuZGVyc2Nhbl9hZGooKSBmdW5jdGlv biBkb2luZyB0aGF0IGFuZCBjYWxsIGl0IGZyb20KPiB2YzRfcGxhbmVfc2V0dXBfY2xpcHBpbmdf YW5kX3NjYWxpbmcoKSBzbyB0aGF0IHdlIGFyZSByZWFkeSB0byBhdHRhY2gKPiB1bmRlcnNjYW4g cHJvcGVydGllcyB0byB0aGUgSERNSSBjb25uZWN0b3IuCj4gCj4gU2lnbmVkLW9mZi1ieTogQm9y aXMgQnJlemlsbG9uIDxib3Jpcy5icmV6aWxsb25AYm9vdGxpbi5jb20+Cj4gLS0tCj4gQ2hhbmdl cyBpbiB2MjoKPiAtIFRha2UgY2hhbmdlcyBvbiBoYm9yZGVyL3Zib3JkZXIgbWVhbmluZyBpbnRv IGFjY291bnQKPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL3ZjNC92YzRfcGxhbmUuYyB8IDQ5ICsr KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKystCj4gIDEgZmlsZSBjaGFuZ2Vk LCA0OCBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9uKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZl cnMvZ3B1L2RybS92YzQvdmM0X3BsYW5lLmMgYi9kcml2ZXJzL2dwdS9kcm0vdmM0L3ZjNF9wbGFu ZS5jCj4gaW5kZXggNzFkNDRjMzU3ZDM1Li42MWVkNjA4NDFjZDYgMTAwNjQ0Cj4gLS0tIGEvZHJp dmVycy9ncHUvZHJtL3ZjNC92YzRfcGxhbmUuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS92YzQv dmM0X3BsYW5lLmMKPiBAQCAtMjU4LDYgKzI1OCw0OSBAQCBzdGF0aWMgdTMyIHZjNF9nZXRfc2Ns X2ZpZWxkKHN0cnVjdCBkcm1fcGxhbmVfc3RhdGUgKnN0YXRlLCBpbnQgcGxhbmUpCj4gIAl9Cj4g IH0KPiAgCj4gK3N0YXRpYyBpbnQgdmM0X3BsYW5lX3VuZGVyc2Nhbl9hZGooc3RydWN0IGRybV9w bGFuZV9zdGF0ZSAqcHN0YXRlKQo+ICt7Cj4gKwlzdHJ1Y3QgdmM0X3BsYW5lX3N0YXRlICp2YzRf cHN0YXRlID0gdG9fdmM0X3BsYW5lX3N0YXRlKHBzdGF0ZSk7Cj4gKwlzdHJ1Y3QgZHJtX2Nvbm5l Y3Rvcl9zdGF0ZSAqY29ubl9zdGF0ZSA9IE5VTEw7Cj4gKwlzdHJ1Y3QgZHJtX2Nvbm5lY3RvciAq Y29ubjsKPiArCXN0cnVjdCBkcm1fY3J0Y19zdGF0ZSAqY3J0Y19zdGF0ZTsKPiArCWludCBpOwo+ ICsKPiArCWZvcl9lYWNoX25ld19jb25uZWN0b3JfaW5fc3RhdGUocHN0YXRlLT5zdGF0ZSwgY29u biwgY29ubl9zdGF0ZSwgaSkgewo+ICsJCWlmIChjb25uX3N0YXRlLT5jcnRjID09IHBzdGF0ZS0+ Y3J0YykKPiArCQkJYnJlYWs7Cj4gKwl9Cj4gKwo+ICsJaWYgKGkgPT0gcHN0YXRlLT5zdGF0ZS0+ bnVtX2Nvbm5lY3RvcikKPiArCQlyZXR1cm4gMDsKPiArCj4gKwlpZiAoY29ubl9zdGF0ZS0+dW5k ZXJzY2FuLm1vZGUgIT0gRFJNX1VOREVSU0NBTl9PTikKPiArCQlyZXR1cm4gMDsKPiArCj4gKwlj cnRjX3N0YXRlID0gZHJtX2F0b21pY19nZXRfbmV3X2NydGNfc3RhdGUocHN0YXRlLT5zdGF0ZSwK PiArCQkJCQkJICAgcHN0YXRlLT5jcnRjKTsKPiArCj4gKwlpZiAoY29ubl9zdGF0ZS0+dW5kZXJz Y2FuLmhib3JkZXIgPj0gY3J0Y19zdGF0ZS0+bW9kZS5oZGlzcGxheSB8fAo+ICsJICAgIGNvbm5f c3RhdGUtPnVuZGVyc2Nhbi52Ym9yZGVyID49IGNydGNfc3RhdGUtPm1vZGUudmRpc3BsYXkpCj4g KwkJcmV0dXJuIC1FSU5WQUw7Cgpib3JkZXIgKiAyID8KCj4gKwo+ICsJdmM0X3BzdGF0ZS0+Y3J0 Y194ICs9IGNvbm5fc3RhdGUtPnVuZGVyc2Nhbi5oYm9yZGVyOwo+ICsJdmM0X3BzdGF0ZS0+Y3J0 Y195ICs9IGNvbm5fc3RhdGUtPnVuZGVyc2Nhbi52Ym9yZGVyOwo+ICsJdmM0X3BzdGF0ZS0+Y3J0 Y193ID0gKHZjNF9wc3RhdGUtPmNydGNfdyAqCj4gKwkJCSAgICAgIChjcnRjX3N0YXRlLT5tb2Rl LmhkaXNwbGF5IC0KPiArCQkJICAgICAgIChjb25uX3N0YXRlLT51bmRlcnNjYW4uaGJvcmRlciAq IDIpKSkgLwo+ICsJCQkgICAgIGNydGNfc3RhdGUtPm1vZGUuaGRpc3BsYXk7Cj4gKwl2YzRfcHN0 YXRlLT5jcnRjX2ggPSAodmM0X3BzdGF0ZS0+Y3J0Y19oICoKPiArCQkJICAgICAgKGNydGNfc3Rh dGUtPm1vZGUudmRpc3BsYXkgLQo+ICsJCQkgICAgICAgKGNvbm5fc3RhdGUtPnVuZGVyc2Nhbi52 Ym9yZGVyICogMikpKSAvCj4gKwkJCSAgICAgY3J0Y19zdGF0ZS0+bW9kZS52ZGlzcGxheTsKClNv IHlvdSdyZSBub3cgc2NhbGluZyBhbGwgcGxhbmVzPyBUaGUgY29kZSBzZWVtcyB0byByZWplY3Qg c2NhbGluZyBmb3IKdGhlIGN1cnNvciBwbGFuZSwgaG93IGFyZSB5b3UgZGVhbGluZyB3aXRoIHRo YXQ/IE9yIGp1c3Qgbm8gY3Vyc29yCmFsbG93ZWQgd2hlbiB1bmRlcnNjYW5uaW5nPwoKSSdtIGFs c28gd29uZGVyaW5nIGlmIHRoZXJlJ3MgYW55IHdheSB3ZSBjYW4gcmVjb25jaWxlIHRoZXNlIGJv cmRlcgpwcm9wcyB3aXRoIHRoZSBzY2FsaW5nIG1vZGUgcHJvcCwgc2hvdWxkIHdlIGV2ZXIgd2lz aCB0byBleHBvc2UKdGhlc2UgcHJvcHMgb24gY29ubmVjdG9ycyB0aGF0IGFscmVhZHkgaGF2ZSB0 aGUgc2NhbGluZyBtb2RlIHByb3AuCk1heWJlIHdlIGp1c3QgaGF2ZSB0byByZXF1aXJlIHRoZSBz Y2FsaW5nIG1vZGUgdG8gYmUgc2V0IHRvIGZ1bGxzY3JlZW4gCnRvIGFsbG93IGJvcmRlcnMgdG8g YmUgc3BlY2lmaWVkIGV4cGxpY3RseT8KCj4gKwo+ICsJaWYgKCF2YzRfcHN0YXRlLT5jcnRjX3cg fHwgIXZjNF9wc3RhdGUtPmNydGNfaCkKPiArCQlyZXR1cm4gLUVJTlZBTDsKPiArCj4gKwlyZXR1 cm4gMDsKPiArfQo+ICsKPiAgc3RhdGljIGludCB2YzRfcGxhbmVfc2V0dXBfY2xpcHBpbmdfYW5k X3NjYWxpbmcoc3RydWN0IGRybV9wbGFuZV9zdGF0ZSAqc3RhdGUpCj4gIHsKPiAgCXN0cnVjdCBk cm1fcGxhbmUgKnBsYW5lID0gc3RhdGUtPnBsYW5lOwo+IEBAIC0yNjksNyArMzEyLDcgQEAgc3Rh dGljIGludCB2YzRfcGxhbmVfc2V0dXBfY2xpcHBpbmdfYW5kX3NjYWxpbmcoc3RydWN0IGRybV9w bGFuZV9zdGF0ZSAqc3RhdGUpCj4gIAlpbnQgbnVtX3BsYW5lcyA9IGZiLT5mb3JtYXQtPm51bV9w bGFuZXM7Cj4gIAl1MzIgaF9zdWJzYW1wbGUgPSAxOwo+ICAJdTMyIHZfc3Vic2FtcGxlID0gMTsK PiAtCWludCBpOwo+ICsJaW50IGksIHJldDsKPiAgCj4gIAlmb3IgKGkgPSAwOyBpIDwgbnVtX3Bs YW5lczsgaSsrKQo+ICAJCXZjNF9zdGF0ZS0+b2Zmc2V0c1tpXSA9IGJvLT5wYWRkciArIGZiLT5v ZmZzZXRzW2ldOwo+IEBAIC0yOTIsNiArMzM1LDEwIEBAIHN0YXRpYyBpbnQgdmM0X3BsYW5lX3Nl dHVwX2NsaXBwaW5nX2FuZF9zY2FsaW5nKHN0cnVjdCBkcm1fcGxhbmVfc3RhdGUgKnN0YXRlKQo+ ICAJdmM0X3N0YXRlLT5jcnRjX3cgPSBzdGF0ZS0+Y3J0Y193Owo+ICAJdmM0X3N0YXRlLT5jcnRj X2ggPSBzdGF0ZS0+Y3J0Y19oOwo+ICAKPiArCXJldCA9IHZjNF9wbGFuZV91bmRlcnNjYW5fYWRq KHN0YXRlKTsKPiArCWlmIChyZXQpCj4gKwkJcmV0dXJuIHJldDsKPiArCj4gIAl2YzRfc3RhdGUt Pnhfc2NhbGluZ1swXSA9IHZjNF9nZXRfc2NhbGluZ19tb2RlKHZjNF9zdGF0ZS0+c3JjX3dbMF0s Cj4gIAkJCQkJCSAgICAgICB2YzRfc3RhdGUtPmNydGNfdyk7Cj4gIAl2YzRfc3RhdGUtPnlfc2Nh bGluZ1swXSA9IHZjNF9nZXRfc2NhbGluZ19tb2RlKHZjNF9zdGF0ZS0+c3JjX2hbMF0sCj4gLS0g Cj4gMi4xNC4xCj4gCj4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KPiBkcmktZGV2ZWwgbWFpbGluZyBsaXN0Cj4gZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNr dG9wLm9yZwo+IGh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8v ZHJpLWRldmVsCgotLSAKVmlsbGUgU3lyasOkbMOkCkludGVsCl9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fCmFtZC1nZnggbWFpbGluZyBsaXN0CmFtZC1nZnhA bGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxt YW4vbGlzdGluZm8vYW1kLWdmeAo=