From mboxrd@z Thu Jan 1 00:00:00 1970 From: Borislav Petkov Subject: Re: [RFC PATCH v4 2/3] acpi: apei: Rename ghes_severity() to ghes_cper_severity() Date: Fri, 11 May 2018 17:58:33 +0200 Message-ID: <20180511155833.GE12705@pd.tnic> References: <20180430212836.7807-1-mr.nuke.me@gmail.com> <20180430213358.8319-1-mr.nuke.me@gmail.com> <20180430213358.8319-2-mr.nuke.me@gmail.com> <20180511153947.GC12705@pd.tnic> <56d445b2-ace3-6ee2-9699-f2a684518de9@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Return-path: Content-Disposition: inline In-Reply-To: <56d445b2-ace3-6ee2-9699-f2a684518de9@gmail.com> Sender: linux-kernel-owner@vger.kernel.org To: "Alex G." Cc: alex_gagniuc@dellteam.com, austin_bolen@dell.com, shyam_iyer@dell.com, "Rafael J. Wysocki" , Len Brown , Tony Luck , Mauro Carvalho Chehab , Robert Moore , Erik Schmauss , Tyler Baicar , Will Deacon , James Morse , Shiju Jose , "Jonathan (Zhixiong) Zhang" , Dongjiu Geng , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-edac@vger.kernel.org, devel@acpica.org List-Id: linux-acpi@vger.kernel.org On Fri, May 11, 2018 at 10:45:49AM -0500, Alex G. wrote: > > > On 05/11/2018 10:39 AM, Borislav Petkov wrote: > > On Mon, Apr 30, 2018 at 04:33:51PM -0500, Alexandru Gagniuc wrote: > >> ghes_severity() is a misnomer in this case, as it implies the severity > >> of the entire GHES structure. Instead, it maps one CPER value to a > >> monotonically increasing number. > > > > ... as opposed to CPER severity which is something else or what is this > > formulation trying to express? > > > > CPER madness goes like this: Let's slow down first. Why is it a "CPER madness"? Maybe this is clear in your head but I'm not in it. > 0 - Recoverable > 1 - Fatal > 2 - Corrected > 3 - None If you're quoting this: enum { CPER_SEV_RECOVERABLE, CPER_SEV_FATAL, CPER_SEV_CORRECTED, CPER_SEV_INFORMATIONAL, }; that last 3 is informational. > As you can see, the numbering was created by crackmonkeys. GHES_* is an > internal enum that goes up in order of severity, as you'd expect. So what are you trying to tell me - that those CPER numbers are not increasing?! Why does that even matter? -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply. From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [RFC,v4,2/3] acpi: apei: Rename ghes_severity() to ghes_cper_severity() From: Borislav Petkov Message-Id: <20180511155833.GE12705@pd.tnic> Date: Fri, 11 May 2018 17:58:33 +0200 To: "Alex G." Cc: alex_gagniuc@dellteam.com, austin_bolen@dell.com, shyam_iyer@dell.com, "Rafael J. Wysocki" , Len Brown , Tony Luck , Mauro Carvalho Chehab , Robert Moore , Erik Schmauss , Tyler Baicar , Will Deacon , James Morse , Shiju Jose , "Jonathan (Zhixiong) Zhang" , Dongjiu Geng , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-edac@vger.kernel.org, devel@acpica.org List-ID: T24gRnJpLCBNYXkgMTEsIDIwMTggYXQgMTA6NDU6NDlBTSAtMDUwMCwgQWxleCBHLiB3cm90ZToK PiAKPiAKPiBPbiAwNS8xMS8yMDE4IDEwOjM5IEFNLCBCb3Jpc2xhdiBQZXRrb3Ygd3JvdGU6Cj4g PiBPbiBNb24sIEFwciAzMCwgMjAxOCBhdCAwNDozMzo1MVBNIC0wNTAwLCBBbGV4YW5kcnUgR2Fn bml1YyB3cm90ZToKPiA+PiBnaGVzX3NldmVyaXR5KCkgaXMgYSBtaXNub21lciBpbiB0aGlzIGNh c2UsIGFzIGl0IGltcGxpZXMgdGhlIHNldmVyaXR5Cj4gPj4gb2YgdGhlIGVudGlyZSBHSEVTIHN0 cnVjdHVyZS4gSW5zdGVhZCwgaXQgbWFwcyBvbmUgQ1BFUiB2YWx1ZSB0byBhCj4gPj4gbW9ub3Rv bmljYWxseSBpbmNyZWFzaW5nIG51bWJlci4KPiA+IAo+ID4gLi4uIGFzIG9wcG9zZWQgdG8gQ1BF UiBzZXZlcml0eSB3aGljaCBpcyBzb21ldGhpbmcgZWxzZSBvciB3aGF0IGlzIHRoaXMKPiA+IGZv cm11bGF0aW9uIHRyeWluZyB0byBleHByZXNzPwo+ID4gCj4gCj4gQ1BFUiBtYWRuZXNzIGdvZXMg bGlrZSB0aGlzOgoKTGV0J3Mgc2xvdyBkb3duIGZpcnN0LiBXaHkgaXMgaXQgYSAiQ1BFUiBtYWRu ZXNzIj8gTWF5YmUgdGhpcyBpcyBjbGVhcgppbiB5b3VyIGhlYWQgYnV0IEknbSBub3QgaW4gaXQu Cgo+IAkwIC0gUmVjb3ZlcmFibGUKPiAJMSAtIEZhdGFsCj4gCTIgLSBDb3JyZWN0ZWQKPiAJMyAt IE5vbmUKCklmIHlvdSdyZSBxdW90aW5nIHRoaXM6CgplbnVtIHsKICAgICAgICBDUEVSX1NFVl9S RUNPVkVSQUJMRSwKICAgICAgICBDUEVSX1NFVl9GQVRBTCwKICAgICAgICBDUEVSX1NFVl9DT1JS RUNURUQsCiAgICAgICAgQ1BFUl9TRVZfSU5GT1JNQVRJT05BTCwKfTsKCnRoYXQgbGFzdCAzIGlz IGluZm9ybWF0aW9uYWwuCgo+IEFzIHlvdSBjYW4gc2VlLCB0aGUgbnVtYmVyaW5nIHdhcyBjcmVh dGVkIGJ5IGNyYWNrbW9ua2V5cy4gR0hFU18qIGlzIGFuCj4gaW50ZXJuYWwgZW51bSB0aGF0IGdv ZXMgdXAgaW4gb3JkZXIgb2Ygc2V2ZXJpdHksIGFzIHlvdSdkIGV4cGVjdC4KClNvIHdoYXQgYXJl IHlvdSB0cnlpbmcgdG8gdGVsbCBtZSAtIHRoYXQgdGhvc2UgQ1BFUiBudW1iZXJzIGFyZSBub3QK aW5jcmVhc2luZz8hCgpXaHkgZG9lcyB0aGF0IGV2ZW4gbWF0dGVyPwo=