From mboxrd@z Thu Jan 1 00:00:00 1970 From: Borislav Petkov Subject: Re: [RFC PATCH v4 3/3] acpi: apei: Do not panic() on PCIe errors reported through GHES Date: Fri, 11 May 2018 18:02:53 +0200 Message-ID: <20180511160253.GF12705@pd.tnic> References: <20180430212836.7807-1-mr.nuke.me@gmail.com> <20180430213358.8319-1-mr.nuke.me@gmail.com> <20180430213358.8319-3-mr.nuke.me@gmail.com> <20180511154039.GD12705@pd.tnic> <8e3c0cc6-9c5c-85ce-650c-8f498f5907da@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Return-path: Content-Disposition: inline In-Reply-To: <8e3c0cc6-9c5c-85ce-650c-8f498f5907da@gmail.com> Sender: linux-kernel-owner@vger.kernel.org To: "Alex G." Cc: alex_gagniuc@dellteam.com, austin_bolen@dell.com, shyam_iyer@dell.com, "Rafael J. Wysocki" , Len Brown , Tony Luck , Mauro Carvalho Chehab , Robert Moore , Erik Schmauss , Tyler Baicar , Will Deacon , James Morse , Shiju Jose , "Jonathan (Zhixiong) Zhang" , Dongjiu Geng , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-edac@vger.kernel.org, devel@acpica.org List-Id: linux-acpi@vger.kernel.org On Fri, May 11, 2018 at 10:54:09AM -0500, Alex G. wrote: > That being clarified, should I replace "crackmonkey" with "broken" in > the commit message? Keep your opinion *outside* of commit messages - their goal is to explain *why* the change is being made in strictly technical language so that when someone looks at git history, someone can know *why*. > Borislav, I sense some confusion. AER is not a "reporting" driver. It > handles the errors. You can't leave these errors unhandled. They > propagate to the root complex and can cause fatal MCEs when not handled. > The window to handle the error is pretty large, so it's not a concern > when you're handling it. I think *you* didn't get it: IS_ENABLED(CONFIG_ACPI_APEI_PCIEAER) is not enough of a check to confirm that there actually *is* an AER driver to handle the errors. If you really want to make sure the driver is loaded and functioning, then you need an explicit registering mechanism or some other way of checking it really is there and handling errors. -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply. From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [RFC,v4,3/3] acpi: apei: Do not panic() on PCIe errors reported through GHES From: Borislav Petkov Message-Id: <20180511160253.GF12705@pd.tnic> Date: Fri, 11 May 2018 18:02:53 +0200 To: "Alex G." Cc: alex_gagniuc@dellteam.com, austin_bolen@dell.com, shyam_iyer@dell.com, "Rafael J. Wysocki" , Len Brown , Tony Luck , Mauro Carvalho Chehab , Robert Moore , Erik Schmauss , Tyler Baicar , Will Deacon , James Morse , Shiju Jose , "Jonathan (Zhixiong) Zhang" , Dongjiu Geng , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-edac@vger.kernel.org, devel@acpica.org List-ID: T24gRnJpLCBNYXkgMTEsIDIwMTggYXQgMTA6NTQ6MDlBTSAtMDUwMCwgQWxleCBHLiB3cm90ZToK PiBUaGF0IGJlaW5nIGNsYXJpZmllZCwgc2hvdWxkIEkgcmVwbGFjZSAiY3JhY2ttb25rZXkiIHdp dGggImJyb2tlbiIgaW4KPiB0aGUgY29tbWl0IG1lc3NhZ2U/CgpLZWVwIHlvdXIgb3BpbmlvbiAq b3V0c2lkZSogb2YgY29tbWl0IG1lc3NhZ2VzIC0gdGhlaXIgZ29hbCBpcyB0bwpleHBsYWluICp3 aHkqIHRoZSBjaGFuZ2UgaXMgYmVpbmcgbWFkZSBpbiBzdHJpY3RseSB0ZWNobmljYWwgbGFuZ3Vh Z2Ugc28KdGhhdCB3aGVuIHNvbWVvbmUgbG9va3MgYXQgZ2l0IGhpc3RvcnksIHNvbWVvbmUgY2Fu IGtub3cgKndoeSouCgo+IEJvcmlzbGF2LCBJIHNlbnNlIHNvbWUgY29uZnVzaW9uLiBBRVIgaXMg bm90IGEgInJlcG9ydGluZyIgZHJpdmVyLiBJdAo+IGhhbmRsZXMgdGhlIGVycm9ycy4gWW91IGNh bid0IGxlYXZlIHRoZXNlIGVycm9ycyB1bmhhbmRsZWQuIFRoZXkKPiBwcm9wYWdhdGUgdG8gdGhl IHJvb3QgY29tcGxleCBhbmQgY2FuIGNhdXNlIGZhdGFsIE1DRXMgd2hlbiBub3QgaGFuZGxlZC4K PiBUaGUgd2luZG93IHRvIGhhbmRsZSB0aGUgZXJyb3IgaXMgcHJldHR5IGxhcmdlLCBzbyBpdCdz IG5vdCBhIGNvbmNlcm4KPiB3aGVuIHlvdSdyZSBoYW5kbGluZyBpdC4KCkkgdGhpbmsgKnlvdSog ZGlkbid0IGdldCBpdDogSVNfRU5BQkxFRChDT05GSUdfQUNQSV9BUEVJX1BDSUVBRVIpIGlzIG5v dAplbm91Z2ggb2YgYSBjaGVjayB0byBjb25maXJtIHRoYXQgdGhlcmUgYWN0dWFsbHkgKmlzKiBh biBBRVIgZHJpdmVyIHRvCmhhbmRsZSB0aGUgZXJyb3JzLiBJZiB5b3UgcmVhbGx5IHdhbnQgdG8g bWFrZSBzdXJlIHRoZSBkcml2ZXIgaXMgbG9hZGVkCmFuZCBmdW5jdGlvbmluZywgdGhlbiB5b3Ug bmVlZCBhbiBleHBsaWNpdCByZWdpc3RlcmluZyBtZWNoYW5pc20gb3Igc29tZQpvdGhlciB3YXkg b2YgY2hlY2tpbmcgaXQgcmVhbGx5IGlzIHRoZXJlIGFuZCBoYW5kbGluZyBlcnJvcnMuCg==