From mboxrd@z Thu Jan 1 00:00:00 1970 From: Borislav Petkov Subject: Re: [RFC PATCH v4 2/3] acpi: apei: Rename ghes_severity() to ghes_cper_severity() Date: Fri, 11 May 2018 18:19:33 +0200 Message-ID: <20180511161933.GG12705@pd.tnic> References: <20180430212836.7807-1-mr.nuke.me@gmail.com> <20180430213358.8319-1-mr.nuke.me@gmail.com> <20180430213358.8319-2-mr.nuke.me@gmail.com> <20180511153947.GC12705@pd.tnic> <56d445b2-ace3-6ee2-9699-f2a684518de9@gmail.com> <20180511155833.GE12705@pd.tnic> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: "Alex G." Cc: alex_gagniuc@dellteam.com, austin_bolen@dell.com, shyam_iyer@dell.com, "Rafael J. Wysocki" , Len Brown , Tony Luck , Mauro Carvalho Chehab , Robert Moore , Erik Schmauss , Tyler Baicar , Will Deacon , James Morse , Shiju Jose , "Jonathan (Zhixiong) Zhang" , Dongjiu Geng , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-edac@vger.kernel.org, devel@acpica.org List-Id: linux-acpi@vger.kernel.org On Fri, May 11, 2018 at 11:12:24AM -0500, Alex G. wrote: > Because the GHES structure uses CPER values, but all the code is written > to use GHES_SEV_ values. GHES_SEV_ is a made up enum, specifically for > linux. Again, what does that even matter? They're defines in both cases. The *actual* value means shit. Ah, I see it: ... sec_sev = ghes_sec_pcie_severity(gdata); worst_sev = max(worst_sev, sec_sev); Yeah, no, you can't do that. No apples and oranges comparisons. -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply. From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [RFC,v4,2/3] acpi: apei: Rename ghes_severity() to ghes_cper_severity() From: Borislav Petkov Message-Id: <20180511161933.GG12705@pd.tnic> Date: Fri, 11 May 2018 18:19:33 +0200 To: "Alex G." Cc: alex_gagniuc@dellteam.com, austin_bolen@dell.com, shyam_iyer@dell.com, "Rafael J. Wysocki" , Len Brown , Tony Luck , Mauro Carvalho Chehab , Robert Moore , Erik Schmauss , Tyler Baicar , Will Deacon , James Morse , Shiju Jose , "Jonathan (Zhixiong) Zhang" , Dongjiu Geng , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-edac@vger.kernel.org, devel@acpica.org List-ID: T24gRnJpLCBNYXkgMTEsIDIwMTggYXQgMTE6MTI6MjRBTSAtMDUwMCwgQWxleCBHLiB3cm90ZToK PiBCZWNhdXNlIHRoZSBHSEVTIHN0cnVjdHVyZSB1c2VzIENQRVIgdmFsdWVzLCBidXQgYWxsIHRo ZSBjb2RlIGlzIHdyaXR0ZW4KPiB0byB1c2UgR0hFU19TRVZfIHZhbHVlcy4gR0hFU19TRVZfIGlz IGEgbWFkZSB1cCBlbnVtLCBzcGVjaWZpY2FsbHkgZm9yCj4gbGludXguCgpBZ2Fpbiwgd2hhdCBk b2VzIHRoYXQgZXZlbiBtYXR0ZXI/CgpUaGV5J3JlIGRlZmluZXMgaW4gYm90aCBjYXNlcy4gVGhl ICphY3R1YWwqIHZhbHVlIG1lYW5zIHNoaXQuCgpBaCwgSSBzZWUgaXQ6CgoJLi4uCgkJc2VjX3Nl diA9IGdoZXNfc2VjX3BjaWVfc2V2ZXJpdHkoZ2RhdGEpOwoKCXdvcnN0X3NldiA9IG1heCh3b3Jz dF9zZXYsIHNlY19zZXYpOwoKClllYWgsIG5vLCB5b3UgY2FuJ3QgZG8gdGhhdC4gTm8gYXBwbGVz IGFuZCBvcmFuZ2VzIGNvbXBhcmlzb25zLgo=