From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH v2 2/4] drm/vc4: Take underscan setup into account when updating planes Date: Fri, 11 May 2018 19:54:02 +0300 Message-ID: <20180511165402.GU23723@intel.com> References: <20180511145919.22447-1-boris.brezillon@bootlin.com> <20180511145919.22447-3-boris.brezillon@bootlin.com> <20180511153450.GS23723@intel.com> <20180511175256.53a3966a@bbrezillon> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20180511175256.53a3966a@bbrezillon> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Boris Brezillon Cc: David Airlie , nouveau@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Alex Deucher , Christian =?iso-8859-1?Q?K=F6nig?= , Ben Skeggs List-Id: amd-gfx.lists.freedesktop.org T24gRnJpLCBNYXkgMTEsIDIwMTggYXQgMDU6NTI6NTZQTSArMDIwMCwgQm9yaXMgQnJlemlsbG9u IHdyb3RlOgo+IE9uIEZyaSwgMTEgTWF5IDIwMTggMTg6MzQ6NTAgKzAzMDAKPiBWaWxsZSBTeXJq w6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwuY29tPiB3cm90ZToKPiAKPiA+IE9uIEZy aSwgTWF5IDExLCAyMDE4IGF0IDA0OjU5OjE3UE0gKzAyMDAsIEJvcmlzIEJyZXppbGxvbiB3cm90 ZToKPiA+ID4gQXBwbHlpbmcgYW4gdW5kZXJzY2FuIHNldHVwIGlzIGp1c3QgYSBtYXR0ZXIgb2Yg c2NhbGluZyBhbGwgcGxhbmVzCj4gPiA+IGFwcHJvcHJpYXRlbHkgYW5kIGFkanVzdGluZyB0aGUg Q1JUQyBYL1kgb2Zmc2V0IHRvIGFjY291bnQgZm9yIHRoZQo+ID4gPiBob3Jpem9udGFsIGFuZCB2 ZXJ0aWNhbCBib3JkZXIuCj4gPiA+IAo+ID4gPiBDcmVhdGUgYW4gdmM0X3BsYW5lX3VuZGVyc2Nh bl9hZGooKSBmdW5jdGlvbiBkb2luZyB0aGF0IGFuZCBjYWxsIGl0IGZyb20KPiA+ID4gdmM0X3Bs YW5lX3NldHVwX2NsaXBwaW5nX2FuZF9zY2FsaW5nKCkgc28gdGhhdCB3ZSBhcmUgcmVhZHkgdG8g YXR0YWNoCj4gPiA+IHVuZGVyc2NhbiBwcm9wZXJ0aWVzIHRvIHRoZSBIRE1JIGNvbm5lY3Rvci4K PiA+ID4gCj4gPiA+IFNpZ25lZC1vZmYtYnk6IEJvcmlzIEJyZXppbGxvbiA8Ym9yaXMuYnJlemls bG9uQGJvb3RsaW4uY29tPgo+ID4gPiAtLS0KPiA+ID4gQ2hhbmdlcyBpbiB2MjoKPiA+ID4gLSBU YWtlIGNoYW5nZXMgb24gaGJvcmRlci92Ym9yZGVyIG1lYW5pbmcgaW50byBhY2NvdW50Cj4gPiA+ IC0tLQo+ID4gPiAgZHJpdmVycy9ncHUvZHJtL3ZjNC92YzRfcGxhbmUuYyB8IDQ5ICsrKysrKysr KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKystCj4gPiA+ICAxIGZpbGUgY2hhbmdlZCwg NDggaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbigtKQo+ID4gPiAKPiA+ID4gZGlmZiAtLWdpdCBh L2RyaXZlcnMvZ3B1L2RybS92YzQvdmM0X3BsYW5lLmMgYi9kcml2ZXJzL2dwdS9kcm0vdmM0L3Zj NF9wbGFuZS5jCj4gPiA+IGluZGV4IDcxZDQ0YzM1N2QzNS4uNjFlZDYwODQxY2Q2IDEwMDY0NAo+ ID4gPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vdmM0L3ZjNF9wbGFuZS5jCj4gPiA+ICsrKyBiL2Ry aXZlcnMvZ3B1L2RybS92YzQvdmM0X3BsYW5lLmMKPiA+ID4gQEAgLTI1OCw2ICsyNTgsNDkgQEAg c3RhdGljIHUzMiB2YzRfZ2V0X3NjbF9maWVsZChzdHJ1Y3QgZHJtX3BsYW5lX3N0YXRlICpzdGF0 ZSwgaW50IHBsYW5lKQo+ID4gPiAgCX0KPiA+ID4gIH0KPiA+ID4gIAo+ID4gPiArc3RhdGljIGlu dCB2YzRfcGxhbmVfdW5kZXJzY2FuX2FkaihzdHJ1Y3QgZHJtX3BsYW5lX3N0YXRlICpwc3RhdGUp Cj4gPiA+ICt7Cj4gPiA+ICsJc3RydWN0IHZjNF9wbGFuZV9zdGF0ZSAqdmM0X3BzdGF0ZSA9IHRv X3ZjNF9wbGFuZV9zdGF0ZShwc3RhdGUpOwo+ID4gPiArCXN0cnVjdCBkcm1fY29ubmVjdG9yX3N0 YXRlICpjb25uX3N0YXRlID0gTlVMTDsKPiA+ID4gKwlzdHJ1Y3QgZHJtX2Nvbm5lY3RvciAqY29u bjsKPiA+ID4gKwlzdHJ1Y3QgZHJtX2NydGNfc3RhdGUgKmNydGNfc3RhdGU7Cj4gPiA+ICsJaW50 IGk7Cj4gPiA+ICsKPiA+ID4gKwlmb3JfZWFjaF9uZXdfY29ubmVjdG9yX2luX3N0YXRlKHBzdGF0 ZS0+c3RhdGUsIGNvbm4sIGNvbm5fc3RhdGUsIGkpIHsKPiA+ID4gKwkJaWYgKGNvbm5fc3RhdGUt PmNydGMgPT0gcHN0YXRlLT5jcnRjKQo+ID4gPiArCQkJYnJlYWs7Cj4gPiA+ICsJfQo+ID4gPiAr Cj4gPiA+ICsJaWYgKGkgPT0gcHN0YXRlLT5zdGF0ZS0+bnVtX2Nvbm5lY3RvcikKPiA+ID4gKwkJ cmV0dXJuIDA7Cj4gPiA+ICsKPiA+ID4gKwlpZiAoY29ubl9zdGF0ZS0+dW5kZXJzY2FuLm1vZGUg IT0gRFJNX1VOREVSU0NBTl9PTikKPiA+ID4gKwkJcmV0dXJuIDA7Cj4gPiA+ICsKPiA+ID4gKwlj cnRjX3N0YXRlID0gZHJtX2F0b21pY19nZXRfbmV3X2NydGNfc3RhdGUocHN0YXRlLT5zdGF0ZSwK PiA+ID4gKwkJCQkJCSAgIHBzdGF0ZS0+Y3J0Yyk7Cj4gPiA+ICsKPiA+ID4gKwlpZiAoY29ubl9z dGF0ZS0+dW5kZXJzY2FuLmhib3JkZXIgPj0gY3J0Y19zdGF0ZS0+bW9kZS5oZGlzcGxheSB8fAo+ ID4gPiArCSAgICBjb25uX3N0YXRlLT51bmRlcnNjYW4udmJvcmRlciA+PSBjcnRjX3N0YXRlLT5t b2RlLnZkaXNwbGF5KQo+ID4gPiArCQlyZXR1cm4gLUVJTlZBTDsgIAo+ID4gCj4gPiBib3JkZXIg KiAyID8KPiAKPiBPb3BzLCBpbmRlZWQuIEknbGwgZml4IHRoYXQuCj4gCj4gPiAKPiA+ID4gKwo+ ID4gPiArCXZjNF9wc3RhdGUtPmNydGNfeCArPSBjb25uX3N0YXRlLT51bmRlcnNjYW4uaGJvcmRl cjsKPiA+ID4gKwl2YzRfcHN0YXRlLT5jcnRjX3kgKz0gY29ubl9zdGF0ZS0+dW5kZXJzY2FuLnZi b3JkZXI7Cj4gPiA+ICsJdmM0X3BzdGF0ZS0+Y3J0Y193ID0gKHZjNF9wc3RhdGUtPmNydGNfdyAq Cj4gPiA+ICsJCQkgICAgICAoY3J0Y19zdGF0ZS0+bW9kZS5oZGlzcGxheSAtCj4gPiA+ICsJCQkg ICAgICAgKGNvbm5fc3RhdGUtPnVuZGVyc2Nhbi5oYm9yZGVyICogMikpKSAvCj4gPiA+ICsJCQkg ICAgIGNydGNfc3RhdGUtPm1vZGUuaGRpc3BsYXk7Cj4gPiA+ICsJdmM0X3BzdGF0ZS0+Y3J0Y19o ID0gKHZjNF9wc3RhdGUtPmNydGNfaCAqCj4gPiA+ICsJCQkgICAgICAoY3J0Y19zdGF0ZS0+bW9k ZS52ZGlzcGxheSAtCj4gPiA+ICsJCQkgICAgICAgKGNvbm5fc3RhdGUtPnVuZGVyc2Nhbi52Ym9y ZGVyICogMikpKSAvCj4gPiA+ICsJCQkgICAgIGNydGNfc3RhdGUtPm1vZGUudmRpc3BsYXk7ICAK PiA+IAo+ID4gU28geW91J3JlIG5vdyBzY2FsaW5nIGFsbCBwbGFuZXM/IFRoZSBjb2RlIHNlZW1z IHRvIHJlamVjdCBzY2FsaW5nIGZvcgo+ID4gdGhlIGN1cnNvciBwbGFuZSwgaG93IGFyZSB5b3Ug ZGVhbGluZyB3aXRoIHRoYXQ/IE9yIGp1c3Qgbm8gY3Vyc29yCj4gPiBhbGxvd2VkIHdoZW4gdW5k ZXJzY2FubmluZz8KPiAKPiBObywgSSBqdXN0IGRpZG4ndCB0ZXN0IHdpdGggYSBjdXJzb3IgcGxh bmUuIFdlIHNob3VsZCBwcm9iYWJseSBhdm9pZAo+IHNjYWxpbmcgdGhlIGN1cnNvciBwbGFuZSBh bmQganVzdCBhZGp1c3QgaXRzIHBvc2l0aW9uLiBFcmljIGFueSBvcGluaW9uCj4gb24gdGhhdD8K CkkgZG9uJ3QgdGhpbmsgeW91IGNhbiBqdXN0IG5vdCBzY2FsZSBpdC4gVGhlIHVzZXIgYXNrZWQg Zm9yIHRoZSBjdXJzb3IKdG8gYmUgYXQgYSBzcGVjaWZpYyBwbGFjZSB3aXRoIGEgc3BlY2lmaWMg c2l6ZS4gQ2FuJ3QganVzdCBpZ25vcmUKdGhhdCBhbmQgZG8gc29tZXRoaW5nIGVsc2UuIEFsc28g ZWcuIGk5MTUgd291bGQgZGVmaW5pdGVseSBzY2FsZSB0aGUKY3Vyc29yIHNpbmNlIHdlJ2QganVz dCBzY2FsZSB0aGUgZW50aXJlIGNydGMgaW5zdGVhZCBvZiBzY2FsaW5nCmluZGl2aWR1YWwgcGxh bmVzLiBEaWZmZXJlbnQgZHJpdmVycyBkb2luZyBkaWZmZXJlbnQgdGhpbmdzIHdvdWxkbid0CmJl IGdvb2QuCgo+IAo+ID4gCj4gPiBJJ20gYWxzbyB3b25kZXJpbmcgaWYgdGhlcmUncyBhbnkgd2F5 IHdlIGNhbiByZWNvbmNpbGUgdGhlc2UgYm9yZGVyCj4gPiBwcm9wcyB3aXRoIHRoZSBzY2FsaW5n IG1vZGUgcHJvcCwgc2hvdWxkIHdlIGV2ZXIgd2lzaCB0byBleHBvc2UKPiA+IHRoZXNlIHByb3Bz IG9uIGNvbm5lY3RvcnMgdGhhdCBhbHJlYWR5IGhhdmUgdGhlIHNjYWxpbmcgbW9kZSBwcm9wLgo+ IAo+IE5vdXZlYXUgc2VlbXMgdG8gZXhwb3NlIGJvdGgsIGFuZCBJIGRvbid0IHNlZSB3aHkgd2Ug Y291bGRuJ3QuCgpGaXJzdCBvZiBhbGwgdGhlIGludGVyYWN0aW9uIG9mIHRoZXNlIGJvcmRlcnMg d2l0aCBwYW5lbHMgdGhhdCBoYXZlCmEgZml4ZWQgbW9kZSB3b3VsZCBuZWVkIHRvIGJlIHByb3Bl cmx5IHNwZWNpZmllZC4gRG8gd2UgYXBwbHkgdGhlCmJvcmRlcnMgYWdhaW5zdCB0aGUgdXNlciBt b2RlIG9yIHRoZSBwYW5lbCdzIG5hdGl2ZSBtb2RlPyBJIGd1ZXNzCnRoZSBsYXR0ZXIgd291bGQg YmUgYSBiaXQgZWFzaWVyICh3b3VsZCBhbHNvIG1hdGNoIGhvdyB0aGUgVFYgbWFyZ2lucwpiZWhh dmUgSSBzdXBwb3NlKS4gQnV0IHRoYXQgZG9lcyBsZWF2ZSBvcGVuIHRoZSBxdWVzdGlvbiBvZiBo b3cKd291bGQgZ2VuZXJpYyB1c2Vyc3BhY2Uga25vdyB3aGljaCBjYXNlIGl0J3MgZGVhbGluZyB3 aXRoPyBFZy4gaWYgaXQKd2FudHMgdG8gdW5kZXJzY2FuIGJ5IHNvbWUgc3BlY2lmaWMgcGVyY2Vu dGFnZSBpdCBoYXMgdG8gY2FsY3VsYXRlCnRoZSBib3JkZXJzIGJhc2VkIG9uIHRoZSBjb3JyZWN0 IG1vZGUsIG90aGVyd2lzZSB0aGUgcmVzdWx0cyBhcmVuJ3QKZ29pbmcgdG8gbWF0Y2ggdGhlIGV4 cGVjdGF0aW9ucy4KCj4gCj4gPiBNYXliZSB3ZSBqdXN0IGhhdmUgdG8gcmVxdWlyZSB0aGUgc2Nh bGluZyBtb2RlIHRvIGJlIHNldCB0byBmdWxsc2NyZWVuIAo+ID4gdG8gYWxsb3cgYm9yZGVycyB0 byBiZSBzcGVjaWZpZWQgZXhwbGljdGx5Pwo+ID4gCj4gPiA+ICsKPiA+ID4gKwlpZiAoIXZjNF9w c3RhdGUtPmNydGNfdyB8fCAhdmM0X3BzdGF0ZS0+Y3J0Y19oKQo+ID4gPiArCQlyZXR1cm4gLUVJ TlZBTDsKPiA+ID4gKwo+ID4gPiArCXJldHVybiAwOwo+ID4gPiArfQo+ID4gPiArCj4gPiA+ICBz dGF0aWMgaW50IHZjNF9wbGFuZV9zZXR1cF9jbGlwcGluZ19hbmRfc2NhbGluZyhzdHJ1Y3QgZHJt X3BsYW5lX3N0YXRlICpzdGF0ZSkKPiA+ID4gIHsKPiA+ID4gIAlzdHJ1Y3QgZHJtX3BsYW5lICpw bGFuZSA9IHN0YXRlLT5wbGFuZTsKPiA+ID4gQEAgLTI2OSw3ICszMTIsNyBAQCBzdGF0aWMgaW50 IHZjNF9wbGFuZV9zZXR1cF9jbGlwcGluZ19hbmRfc2NhbGluZyhzdHJ1Y3QgZHJtX3BsYW5lX3N0 YXRlICpzdGF0ZSkKPiA+ID4gIAlpbnQgbnVtX3BsYW5lcyA9IGZiLT5mb3JtYXQtPm51bV9wbGFu ZXM7Cj4gPiA+ICAJdTMyIGhfc3Vic2FtcGxlID0gMTsKPiA+ID4gIAl1MzIgdl9zdWJzYW1wbGUg PSAxOwo+ID4gPiAtCWludCBpOwo+ID4gPiArCWludCBpLCByZXQ7Cj4gPiA+ICAKPiA+ID4gIAlm b3IgKGkgPSAwOyBpIDwgbnVtX3BsYW5lczsgaSsrKQo+ID4gPiAgCQl2YzRfc3RhdGUtPm9mZnNl dHNbaV0gPSBiby0+cGFkZHIgKyBmYi0+b2Zmc2V0c1tpXTsKPiA+ID4gQEAgLTI5Miw2ICszMzUs MTAgQEAgc3RhdGljIGludCB2YzRfcGxhbmVfc2V0dXBfY2xpcHBpbmdfYW5kX3NjYWxpbmcoc3Ry dWN0IGRybV9wbGFuZV9zdGF0ZSAqc3RhdGUpCj4gPiA+ICAJdmM0X3N0YXRlLT5jcnRjX3cgPSBz dGF0ZS0+Y3J0Y193Owo+ID4gPiAgCXZjNF9zdGF0ZS0+Y3J0Y19oID0gc3RhdGUtPmNydGNfaDsK PiA+ID4gIAo+ID4gPiArCXJldCA9IHZjNF9wbGFuZV91bmRlcnNjYW5fYWRqKHN0YXRlKTsKPiA+ ID4gKwlpZiAocmV0KQo+ID4gPiArCQlyZXR1cm4gcmV0Owo+ID4gPiArCj4gPiA+ICAJdmM0X3N0 YXRlLT54X3NjYWxpbmdbMF0gPSB2YzRfZ2V0X3NjYWxpbmdfbW9kZSh2YzRfc3RhdGUtPnNyY193 WzBdLAo+ID4gPiAgCQkJCQkJICAgICAgIHZjNF9zdGF0ZS0+Y3J0Y193KTsKPiA+ID4gIAl2YzRf c3RhdGUtPnlfc2NhbGluZ1swXSA9IHZjNF9nZXRfc2NhbGluZ19tb2RlKHZjNF9zdGF0ZS0+c3Jj X2hbMF0sCj4gPiA+IC0tIAo+ID4gPiAyLjE0LjEKPiA+ID4gCj4gPiA+IF9fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4gPiA+IGRyaS1kZXZlbCBtYWlsaW5n IGxpc3QKPiA+ID4gZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+ID4gPiBodHRwczov L2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbCAgCj4gPiAK Ci0tIApWaWxsZSBTeXJqw6Rsw6QKSW50ZWwKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMu ZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlz dGluZm8vZHJpLWRldmVsCg==