From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH v2 2/4] drm/vc4: Take underscan setup into account when updating planes Date: Fri, 11 May 2018 20:29:48 +0300 Message-ID: <20180511172948.GV23723@intel.com> References: <20180511145919.22447-1-boris.brezillon@bootlin.com> <20180511145919.22447-3-boris.brezillon@bootlin.com> <20180511153450.GS23723@intel.com> <20180511175256.53a3966a@bbrezillon> <20180511165402.GU23723@intel.com> <20180511191221.185f9e94@bbrezillon> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20180511191221.185f9e94@bbrezillon> List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: Boris Brezillon Cc: David Airlie , nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, Daniel Vetter , Alex Deucher , Christian =?iso-8859-1?Q?K=F6nig?= , Ben Skeggs T24gRnJpLCBNYXkgMTEsIDIwMTggYXQgMDc6MTI6MjFQTSArMDIwMCwgQm9yaXMgQnJlemlsbG9u IHdyb3RlOgo+IE9uIEZyaSwgMTEgTWF5IDIwMTggMTk6NTQ6MDIgKzAzMDAKPiBWaWxsZSBTeXJq w6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwuY29tPiB3cm90ZToKPiAKPiA+IE9uIEZy aSwgTWF5IDExLCAyMDE4IGF0IDA1OjUyOjU2UE0gKzAyMDAsIEJvcmlzIEJyZXppbGxvbiB3cm90 ZToKPiA+ID4gT24gRnJpLCAxMSBNYXkgMjAxOCAxODozNDo1MCArMDMwMAo+ID4gPiBWaWxsZSBT eXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwuY29tPiB3cm90ZToKPiA+ID4gICAK PiA+ID4gPiBPbiBGcmksIE1heSAxMSwgMjAxOCBhdCAwNDo1OToxN1BNICswMjAwLCBCb3JpcyBC cmV6aWxsb24gd3JvdGU6ICAKPiA+ID4gPiA+IEFwcGx5aW5nIGFuIHVuZGVyc2NhbiBzZXR1cCBp cyBqdXN0IGEgbWF0dGVyIG9mIHNjYWxpbmcgYWxsIHBsYW5lcwo+ID4gPiA+ID4gYXBwcm9wcmlh dGVseSBhbmQgYWRqdXN0aW5nIHRoZSBDUlRDIFgvWSBvZmZzZXQgdG8gYWNjb3VudCBmb3IgdGhl Cj4gPiA+ID4gPiBob3Jpem9udGFsIGFuZCB2ZXJ0aWNhbCBib3JkZXIuCj4gPiA+ID4gPiAKPiA+ ID4gPiA+IENyZWF0ZSBhbiB2YzRfcGxhbmVfdW5kZXJzY2FuX2FkaigpIGZ1bmN0aW9uIGRvaW5n IHRoYXQgYW5kIGNhbGwgaXQgZnJvbQo+ID4gPiA+ID4gdmM0X3BsYW5lX3NldHVwX2NsaXBwaW5n X2FuZF9zY2FsaW5nKCkgc28gdGhhdCB3ZSBhcmUgcmVhZHkgdG8gYXR0YWNoCj4gPiA+ID4gPiB1 bmRlcnNjYW4gcHJvcGVydGllcyB0byB0aGUgSERNSSBjb25uZWN0b3IuCj4gPiA+ID4gPiAKPiA+ ID4gPiA+IFNpZ25lZC1vZmYtYnk6IEJvcmlzIEJyZXppbGxvbiA8Ym9yaXMuYnJlemlsbG9uQGJv b3RsaW4uY29tPgo+ID4gPiA+ID4gLS0tCj4gPiA+ID4gPiBDaGFuZ2VzIGluIHYyOgo+ID4gPiA+ ID4gLSBUYWtlIGNoYW5nZXMgb24gaGJvcmRlci92Ym9yZGVyIG1lYW5pbmcgaW50byBhY2NvdW50 Cj4gPiA+ID4gPiAtLS0KPiA+ID4gPiA+ICBkcml2ZXJzL2dwdS9kcm0vdmM0L3ZjNF9wbGFuZS5j IHwgNDkgKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKy0KPiA+ID4gPiA+ ICAxIGZpbGUgY2hhbmdlZCwgNDggaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbigtKQo+ID4gPiA+ ID4gCj4gPiA+ID4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL3ZjNC92YzRfcGxhbmUu YyBiL2RyaXZlcnMvZ3B1L2RybS92YzQvdmM0X3BsYW5lLmMKPiA+ID4gPiA+IGluZGV4IDcxZDQ0 YzM1N2QzNS4uNjFlZDYwODQxY2Q2IDEwMDY0NAo+ID4gPiA+ID4gLS0tIGEvZHJpdmVycy9ncHUv ZHJtL3ZjNC92YzRfcGxhbmUuYwo+ID4gPiA+ID4gKysrIGIvZHJpdmVycy9ncHUvZHJtL3ZjNC92 YzRfcGxhbmUuYwo+ID4gPiA+ID4gQEAgLTI1OCw2ICsyNTgsNDkgQEAgc3RhdGljIHUzMiB2YzRf Z2V0X3NjbF9maWVsZChzdHJ1Y3QgZHJtX3BsYW5lX3N0YXRlICpzdGF0ZSwgaW50IHBsYW5lKQo+ ID4gPiA+ID4gIAl9Cj4gPiA+ID4gPiAgfQo+ID4gPiA+ID4gIAo+ID4gPiA+ID4gK3N0YXRpYyBp bnQgdmM0X3BsYW5lX3VuZGVyc2Nhbl9hZGooc3RydWN0IGRybV9wbGFuZV9zdGF0ZSAqcHN0YXRl KQo+ID4gPiA+ID4gK3sKPiA+ID4gPiA+ICsJc3RydWN0IHZjNF9wbGFuZV9zdGF0ZSAqdmM0X3Bz dGF0ZSA9IHRvX3ZjNF9wbGFuZV9zdGF0ZShwc3RhdGUpOwo+ID4gPiA+ID4gKwlzdHJ1Y3QgZHJt X2Nvbm5lY3Rvcl9zdGF0ZSAqY29ubl9zdGF0ZSA9IE5VTEw7Cj4gPiA+ID4gPiArCXN0cnVjdCBk cm1fY29ubmVjdG9yICpjb25uOwo+ID4gPiA+ID4gKwlzdHJ1Y3QgZHJtX2NydGNfc3RhdGUgKmNy dGNfc3RhdGU7Cj4gPiA+ID4gPiArCWludCBpOwo+ID4gPiA+ID4gKwo+ID4gPiA+ID4gKwlmb3Jf ZWFjaF9uZXdfY29ubmVjdG9yX2luX3N0YXRlKHBzdGF0ZS0+c3RhdGUsIGNvbm4sIGNvbm5fc3Rh dGUsIGkpIHsKPiA+ID4gPiA+ICsJCWlmIChjb25uX3N0YXRlLT5jcnRjID09IHBzdGF0ZS0+Y3J0 YykKPiA+ID4gPiA+ICsJCQlicmVhazsKPiA+ID4gPiA+ICsJfQo+ID4gPiA+ID4gKwo+ID4gPiA+ ID4gKwlpZiAoaSA9PSBwc3RhdGUtPnN0YXRlLT5udW1fY29ubmVjdG9yKQo+ID4gPiA+ID4gKwkJ cmV0dXJuIDA7Cj4gPiA+ID4gPiArCj4gPiA+ID4gPiArCWlmIChjb25uX3N0YXRlLT51bmRlcnNj YW4ubW9kZSAhPSBEUk1fVU5ERVJTQ0FOX09OKQo+ID4gPiA+ID4gKwkJcmV0dXJuIDA7Cj4gPiA+ ID4gPiArCj4gPiA+ID4gPiArCWNydGNfc3RhdGUgPSBkcm1fYXRvbWljX2dldF9uZXdfY3J0Y19z dGF0ZShwc3RhdGUtPnN0YXRlLAo+ID4gPiA+ID4gKwkJCQkJCSAgIHBzdGF0ZS0+Y3J0Yyk7Cj4g PiA+ID4gPiArCj4gPiA+ID4gPiArCWlmIChjb25uX3N0YXRlLT51bmRlcnNjYW4uaGJvcmRlciA+ PSBjcnRjX3N0YXRlLT5tb2RlLmhkaXNwbGF5IHx8Cj4gPiA+ID4gPiArCSAgICBjb25uX3N0YXRl LT51bmRlcnNjYW4udmJvcmRlciA+PSBjcnRjX3N0YXRlLT5tb2RlLnZkaXNwbGF5KQo+ID4gPiA+ ID4gKwkJcmV0dXJuIC1FSU5WQUw7ICAgIAo+ID4gPiA+IAo+ID4gPiA+IGJvcmRlciAqIDIgPyAg Cj4gPiA+IAo+ID4gPiBPb3BzLCBpbmRlZWQuIEknbGwgZml4IHRoYXQuCj4gPiA+ICAgCj4gPiA+ ID4gICAKPiA+ID4gPiA+ICsKPiA+ID4gPiA+ICsJdmM0X3BzdGF0ZS0+Y3J0Y194ICs9IGNvbm5f c3RhdGUtPnVuZGVyc2Nhbi5oYm9yZGVyOwo+ID4gPiA+ID4gKwl2YzRfcHN0YXRlLT5jcnRjX3kg Kz0gY29ubl9zdGF0ZS0+dW5kZXJzY2FuLnZib3JkZXI7Cj4gPiA+ID4gPiArCXZjNF9wc3RhdGUt PmNydGNfdyA9ICh2YzRfcHN0YXRlLT5jcnRjX3cgKgo+ID4gPiA+ID4gKwkJCSAgICAgIChjcnRj X3N0YXRlLT5tb2RlLmhkaXNwbGF5IC0KPiA+ID4gPiA+ICsJCQkgICAgICAgKGNvbm5fc3RhdGUt PnVuZGVyc2Nhbi5oYm9yZGVyICogMikpKSAvCj4gPiA+ID4gPiArCQkJICAgICBjcnRjX3N0YXRl LT5tb2RlLmhkaXNwbGF5Owo+ID4gPiA+ID4gKwl2YzRfcHN0YXRlLT5jcnRjX2ggPSAodmM0X3Bz dGF0ZS0+Y3J0Y19oICoKPiA+ID4gPiA+ICsJCQkgICAgICAoY3J0Y19zdGF0ZS0+bW9kZS52ZGlz cGxheSAtCj4gPiA+ID4gPiArCQkJICAgICAgIChjb25uX3N0YXRlLT51bmRlcnNjYW4udmJvcmRl ciAqIDIpKSkgLwo+ID4gPiA+ID4gKwkJCSAgICAgY3J0Y19zdGF0ZS0+bW9kZS52ZGlzcGxheTsg ICAgCj4gPiA+ID4gCj4gPiA+ID4gU28geW91J3JlIG5vdyBzY2FsaW5nIGFsbCBwbGFuZXM/IFRo ZSBjb2RlIHNlZW1zIHRvIHJlamVjdCBzY2FsaW5nIGZvcgo+ID4gPiA+IHRoZSBjdXJzb3IgcGxh bmUsIGhvdyBhcmUgeW91IGRlYWxpbmcgd2l0aCB0aGF0PyBPciBqdXN0IG5vIGN1cnNvcgo+ID4g PiA+IGFsbG93ZWQgd2hlbiB1bmRlcnNjYW5uaW5nPyAgCj4gPiA+IAo+ID4gPiBObywgSSBqdXN0 IGRpZG4ndCB0ZXN0IHdpdGggYSBjdXJzb3IgcGxhbmUuIFdlIHNob3VsZCBwcm9iYWJseSBhdm9p ZAo+ID4gPiBzY2FsaW5nIHRoZSBjdXJzb3IgcGxhbmUgYW5kIGp1c3QgYWRqdXN0IGl0cyBwb3Np dGlvbi4gRXJpYyBhbnkgb3Bpbmlvbgo+ID4gPiBvbiB0aGF0PyAgCj4gPiAKPiA+IEkgZG9uJ3Qg dGhpbmsgeW91IGNhbiBqdXN0IG5vdCBzY2FsZSBpdC4gVGhlIHVzZXIgYXNrZWQgZm9yIHRoZSBj dXJzb3IKPiA+IHRvIGJlIGF0IGEgc3BlY2lmaWMgcGxhY2Ugd2l0aCBhIHNwZWNpZmljIHNpemUu IENhbid0IGp1c3QgaWdub3JlCj4gPiB0aGF0IGFuZCBkbyBzb21ldGhpbmcgZWxzZS4gQWxzbyBl Zy4gaTkxNSB3b3VsZCBkZWZpbml0ZWx5IHNjYWxlIHRoZQo+ID4gY3Vyc29yIHNpbmNlIHdlJ2Qg anVzdCBzY2FsZSB0aGUgZW50aXJlIGNydGMgaW5zdGVhZCBvZiBzY2FsaW5nCj4gPiBpbmRpdmlk dWFsIHBsYW5lcy4gRGlmZmVyZW50IGRyaXZlcnMgZG9pbmcgZGlmZmVyZW50IHRoaW5ncyB3b3Vs ZG4ndAo+ID4gYmUgZ29vZC4KPiAKPiBFeGNlcHQgaW4gb3VyIGNhc2UgdGhlIHNjYWxpbmcgdGFr ZXMgcGxhY2UgYmVmb3JlIHRoZSBjb21wb3NpdGlvbiwgc28KPiB3ZSBkb24ndCBoYXZlIGEgY2hv aWNlLgoKVGhlIGNob2ljZSBpcyB0byBlaXRoZXIgZG8gd2hhdCB1c2Vyc3BhY2UgYXNrZWQsIG9y IHJldHVybiBhbiBlcnJvci4KCj4gCj4gPiAKPiA+ID4gICAKPiA+ID4gPiAKPiA+ID4gPiBJJ20g YWxzbyB3b25kZXJpbmcgaWYgdGhlcmUncyBhbnkgd2F5IHdlIGNhbiByZWNvbmNpbGUgdGhlc2Ug Ym9yZGVyCj4gPiA+ID4gcHJvcHMgd2l0aCB0aGUgc2NhbGluZyBtb2RlIHByb3AsIHNob3VsZCB3 ZSBldmVyIHdpc2ggdG8gZXhwb3NlCj4gPiA+ID4gdGhlc2UgcHJvcHMgb24gY29ubmVjdG9ycyB0 aGF0IGFscmVhZHkgaGF2ZSB0aGUgc2NhbGluZyBtb2RlIHByb3AuICAKPiA+ID4gCj4gPiA+IE5v dXZlYXUgc2VlbXMgdG8gZXhwb3NlIGJvdGgsIGFuZCBJIGRvbid0IHNlZSB3aHkgd2UgY291bGRu J3QuICAKPiA+IAo+ID4gRmlyc3Qgb2YgYWxsIHRoZSBpbnRlcmFjdGlvbiBvZiB0aGVzZSBib3Jk ZXJzIHdpdGggcGFuZWxzIHRoYXQgaGF2ZQo+ID4gYSBmaXhlZCBtb2RlIHdvdWxkIG5lZWQgdG8g YmUgcHJvcGVybHkgc3BlY2lmaWVkLiBEbyB3ZSBhcHBseSB0aGUKPiA+IGJvcmRlcnMgYWdhaW5z dCB0aGUgdXNlciBtb2RlIG9yIHRoZSBwYW5lbCdzIG5hdGl2ZSBtb2RlPwo+IAo+IEhtLCBJJ20g YSBiaXQgbG9zdC4gSXNuJ3QgY3J0Y19zdGF0ZS0+bW9kZSBzdXBwb3NlZCB0byBjb250YWluIHRo ZSBtb2RlCj4gdGhhdCBpcyBhYm91dCB0byBiZSBhcHBsaWVkLCBubyBtYXR0ZXIgaWYgaXQncyBh IHVzZXJtb2RlIG9yIG9uZSBvZiB0aGUKPiBtb2RlIHJldHVybmVkIGJ5IHRoZSBkaXNwbGF5PyAK Ck5vLiBXaXRoIGZpeGVkIG1vZGUgcGFuZWxzIHRoZSB1c2VyIG1vZGUgaXMgYSBsaWUuIE9ubHkK aGRpc3BsYXkvdmRpc3BsYXkgbWVhbiBhbnl0aGluZy4gVGhlIGFjdHVhbCB0aW1pbmdzIGFyZSBr bm93biBvbmx5IHRvCnRoZSBrZXJuZWwuIFdlbGwsIHVzZXJzcGFjZSBjYW4gcGVyaGFwcyBtYWtl IGFuIGVkdWNhdGVkIGd1ZXNzIGJhc2VkIG9uCnRoZSBjb25uZWN0b3IncyBtb2RlIGxpc3QgYW5k IHRoZSBwcmVzZW5jZSBvZiB0aGUgc2NhbGluZyBtb2RlIHByb3BlcnR5LgoKPiAKPiA+IEkgZ3Vl c3MKPiA+IHRoZSBsYXR0ZXIgd291bGQgYmUgYSBiaXQgZWFzaWVyICh3b3VsZCBhbHNvIG1hdGNo IGhvdyB0aGUgVFYgbWFyZ2lucwo+ID4gYmVoYXZlIEkgc3VwcG9zZSkuIEJ1dCB0aGF0IGRvZXMg bGVhdmUgb3BlbiB0aGUgcXVlc3Rpb24gb2YgaG93Cj4gPiB3b3VsZCBnZW5lcmljIHVzZXJzcGFj ZSBrbm93IHdoaWNoIGNhc2UgaXQncyBkZWFsaW5nIHdpdGg/IEVnLiBpZiBpdAo+ID4gd2FudHMg dG8gdW5kZXJzY2FuIGJ5IHNvbWUgc3BlY2lmaWMgcGVyY2VudGFnZSBpdCBoYXMgdG8gY2FsY3Vs YXRlCj4gPiB0aGUgYm9yZGVycyBiYXNlZCBvbiB0aGUgY29ycmVjdCBtb2RlLCBvdGhlcndpc2Ug dGhlIHJlc3VsdHMgYXJlbid0Cj4gPiBnb2luZyB0byBtYXRjaCB0aGUgZXhwZWN0YXRpb25zLgo+ IAo+IEkgZG9uJ3QgZ2V0IGl0LCBzb3JyeS4gQm9yZGVycyBhcmUgcmVsYXRpdmUgdG8gdGhlIG1v ZGUgYXBwbGllZCBieQo+IHVzZXJzcGFjZS4gU28gaWYgaXQgbmVlZHMgdG8gZXhwcmVzcyBib3Jk ZXJzIGFzIGEgcmF0aW8gb2YgdGhlCj4gcmVzb2x1dGlvbiwgdGhlbiBmb3Igc3VyZSB1c2Vyc3Bh Y2Ugd2lsbCBoYXZlIHRvIGRvIHRoZSBtYXRoLCBidXQgSQo+IGRvbid0IHNlZSB0aGUgcHJvYmxl bSBoZXJlLgoKLS0gClZpbGxlIFN5cmrDpGzDpApJbnRlbApfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXwphbWQtZ2Z4IG1haWxpbmcgbGlzdAphbWQtZ2Z4QGxp c3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFu L2xpc3RpbmZvL2FtZC1nZngK