From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boris Brezillon Subject: Re: [PATCH v2 2/4] drm/vc4: Take underscan setup into account when updating planes Date: Fri, 11 May 2018 17:52:56 +0200 Message-ID: <20180511175256.53a3966a@bbrezillon> References: <20180511145919.22447-1-boris.brezillon@bootlin.com> <20180511145919.22447-3-boris.brezillon@bootlin.com> <20180511153450.GS23723@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20180511153450.GS23723-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: Ville =?UTF-8?B?U3lyasOkbMOk?= Cc: David Airlie , nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, Daniel Vetter , Alex Deucher , Christian =?UTF-8?B?S8O2bmln?= , Ben Skeggs T24gRnJpLCAxMSBNYXkgMjAxOCAxODozNDo1MCArMDMwMApWaWxsZSBTeXJqw6Rsw6QgPHZpbGxl LnN5cmphbGFAbGludXguaW50ZWwuY29tPiB3cm90ZToKCj4gT24gRnJpLCBNYXkgMTEsIDIwMTgg YXQgMDQ6NTk6MTdQTSArMDIwMCwgQm9yaXMgQnJlemlsbG9uIHdyb3RlOgo+ID4gQXBwbHlpbmcg YW4gdW5kZXJzY2FuIHNldHVwIGlzIGp1c3QgYSBtYXR0ZXIgb2Ygc2NhbGluZyBhbGwgcGxhbmVz Cj4gPiBhcHByb3ByaWF0ZWx5IGFuZCBhZGp1c3RpbmcgdGhlIENSVEMgWC9ZIG9mZnNldCB0byBh Y2NvdW50IGZvciB0aGUKPiA+IGhvcml6b250YWwgYW5kIHZlcnRpY2FsIGJvcmRlci4KPiA+IAo+ ID4gQ3JlYXRlIGFuIHZjNF9wbGFuZV91bmRlcnNjYW5fYWRqKCkgZnVuY3Rpb24gZG9pbmcgdGhh dCBhbmQgY2FsbCBpdCBmcm9tCj4gPiB2YzRfcGxhbmVfc2V0dXBfY2xpcHBpbmdfYW5kX3NjYWxp bmcoKSBzbyB0aGF0IHdlIGFyZSByZWFkeSB0byBhdHRhY2gKPiA+IHVuZGVyc2NhbiBwcm9wZXJ0 aWVzIHRvIHRoZSBIRE1JIGNvbm5lY3Rvci4KPiA+IAo+ID4gU2lnbmVkLW9mZi1ieTogQm9yaXMg QnJlemlsbG9uIDxib3Jpcy5icmV6aWxsb25AYm9vdGxpbi5jb20+Cj4gPiAtLS0KPiA+IENoYW5n ZXMgaW4gdjI6Cj4gPiAtIFRha2UgY2hhbmdlcyBvbiBoYm9yZGVyL3Zib3JkZXIgbWVhbmluZyBp bnRvIGFjY291bnQKPiA+IC0tLQo+ID4gIGRyaXZlcnMvZ3B1L2RybS92YzQvdmM0X3BsYW5lLmMg fCA0OSArKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrLQo+ID4gIDEgZmls ZSBjaGFuZ2VkLCA0OCBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9uKC0pCj4gPiAKPiA+IGRpZmYg LS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vdmM0L3ZjNF9wbGFuZS5jIGIvZHJpdmVycy9ncHUvZHJt L3ZjNC92YzRfcGxhbmUuYwo+ID4gaW5kZXggNzFkNDRjMzU3ZDM1Li42MWVkNjA4NDFjZDYgMTAw NjQ0Cj4gPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vdmM0L3ZjNF9wbGFuZS5jCj4gPiArKysgYi9k cml2ZXJzL2dwdS9kcm0vdmM0L3ZjNF9wbGFuZS5jCj4gPiBAQCAtMjU4LDYgKzI1OCw0OSBAQCBz dGF0aWMgdTMyIHZjNF9nZXRfc2NsX2ZpZWxkKHN0cnVjdCBkcm1fcGxhbmVfc3RhdGUgKnN0YXRl LCBpbnQgcGxhbmUpCj4gPiAgCX0KPiA+ICB9Cj4gPiAgCj4gPiArc3RhdGljIGludCB2YzRfcGxh bmVfdW5kZXJzY2FuX2FkaihzdHJ1Y3QgZHJtX3BsYW5lX3N0YXRlICpwc3RhdGUpCj4gPiArewo+ ID4gKwlzdHJ1Y3QgdmM0X3BsYW5lX3N0YXRlICp2YzRfcHN0YXRlID0gdG9fdmM0X3BsYW5lX3N0 YXRlKHBzdGF0ZSk7Cj4gPiArCXN0cnVjdCBkcm1fY29ubmVjdG9yX3N0YXRlICpjb25uX3N0YXRl ID0gTlVMTDsKPiA+ICsJc3RydWN0IGRybV9jb25uZWN0b3IgKmNvbm47Cj4gPiArCXN0cnVjdCBk cm1fY3J0Y19zdGF0ZSAqY3J0Y19zdGF0ZTsKPiA+ICsJaW50IGk7Cj4gPiArCj4gPiArCWZvcl9l YWNoX25ld19jb25uZWN0b3JfaW5fc3RhdGUocHN0YXRlLT5zdGF0ZSwgY29ubiwgY29ubl9zdGF0 ZSwgaSkgewo+ID4gKwkJaWYgKGNvbm5fc3RhdGUtPmNydGMgPT0gcHN0YXRlLT5jcnRjKQo+ID4g KwkJCWJyZWFrOwo+ID4gKwl9Cj4gPiArCj4gPiArCWlmIChpID09IHBzdGF0ZS0+c3RhdGUtPm51 bV9jb25uZWN0b3IpCj4gPiArCQlyZXR1cm4gMDsKPiA+ICsKPiA+ICsJaWYgKGNvbm5fc3RhdGUt PnVuZGVyc2Nhbi5tb2RlICE9IERSTV9VTkRFUlNDQU5fT04pCj4gPiArCQlyZXR1cm4gMDsKPiA+ ICsKPiA+ICsJY3J0Y19zdGF0ZSA9IGRybV9hdG9taWNfZ2V0X25ld19jcnRjX3N0YXRlKHBzdGF0 ZS0+c3RhdGUsCj4gPiArCQkJCQkJICAgcHN0YXRlLT5jcnRjKTsKPiA+ICsKPiA+ICsJaWYgKGNv bm5fc3RhdGUtPnVuZGVyc2Nhbi5oYm9yZGVyID49IGNydGNfc3RhdGUtPm1vZGUuaGRpc3BsYXkg fHwKPiA+ICsJICAgIGNvbm5fc3RhdGUtPnVuZGVyc2Nhbi52Ym9yZGVyID49IGNydGNfc3RhdGUt Pm1vZGUudmRpc3BsYXkpCj4gPiArCQlyZXR1cm4gLUVJTlZBTDsgIAo+IAo+IGJvcmRlciAqIDIg PwoKT29wcywgaW5kZWVkLiBJJ2xsIGZpeCB0aGF0LgoKPiAKPiA+ICsKPiA+ICsJdmM0X3BzdGF0 ZS0+Y3J0Y194ICs9IGNvbm5fc3RhdGUtPnVuZGVyc2Nhbi5oYm9yZGVyOwo+ID4gKwl2YzRfcHN0 YXRlLT5jcnRjX3kgKz0gY29ubl9zdGF0ZS0+dW5kZXJzY2FuLnZib3JkZXI7Cj4gPiArCXZjNF9w c3RhdGUtPmNydGNfdyA9ICh2YzRfcHN0YXRlLT5jcnRjX3cgKgo+ID4gKwkJCSAgICAgIChjcnRj X3N0YXRlLT5tb2RlLmhkaXNwbGF5IC0KPiA+ICsJCQkgICAgICAgKGNvbm5fc3RhdGUtPnVuZGVy c2Nhbi5oYm9yZGVyICogMikpKSAvCj4gPiArCQkJICAgICBjcnRjX3N0YXRlLT5tb2RlLmhkaXNw bGF5Owo+ID4gKwl2YzRfcHN0YXRlLT5jcnRjX2ggPSAodmM0X3BzdGF0ZS0+Y3J0Y19oICoKPiA+ ICsJCQkgICAgICAoY3J0Y19zdGF0ZS0+bW9kZS52ZGlzcGxheSAtCj4gPiArCQkJICAgICAgIChj b25uX3N0YXRlLT51bmRlcnNjYW4udmJvcmRlciAqIDIpKSkgLwo+ID4gKwkJCSAgICAgY3J0Y19z dGF0ZS0+bW9kZS52ZGlzcGxheTsgIAo+IAo+IFNvIHlvdSdyZSBub3cgc2NhbGluZyBhbGwgcGxh bmVzPyBUaGUgY29kZSBzZWVtcyB0byByZWplY3Qgc2NhbGluZyBmb3IKPiB0aGUgY3Vyc29yIHBs YW5lLCBob3cgYXJlIHlvdSBkZWFsaW5nIHdpdGggdGhhdD8gT3IganVzdCBubyBjdXJzb3IKPiBh bGxvd2VkIHdoZW4gdW5kZXJzY2FubmluZz8KCk5vLCBJIGp1c3QgZGlkbid0IHRlc3Qgd2l0aCBh IGN1cnNvciBwbGFuZS4gV2Ugc2hvdWxkIHByb2JhYmx5IGF2b2lkCnNjYWxpbmcgdGhlIGN1cnNv ciBwbGFuZSBhbmQganVzdCBhZGp1c3QgaXRzIHBvc2l0aW9uLiBFcmljIGFueSBvcGluaW9uCm9u IHRoYXQ/Cgo+IAo+IEknbSBhbHNvIHdvbmRlcmluZyBpZiB0aGVyZSdzIGFueSB3YXkgd2UgY2Fu IHJlY29uY2lsZSB0aGVzZSBib3JkZXIKPiBwcm9wcyB3aXRoIHRoZSBzY2FsaW5nIG1vZGUgcHJv cCwgc2hvdWxkIHdlIGV2ZXIgd2lzaCB0byBleHBvc2UKPiB0aGVzZSBwcm9wcyBvbiBjb25uZWN0 b3JzIHRoYXQgYWxyZWFkeSBoYXZlIHRoZSBzY2FsaW5nIG1vZGUgcHJvcC4KCk5vdXZlYXUgc2Vl bXMgdG8gZXhwb3NlIGJvdGgsIGFuZCBJIGRvbid0IHNlZSB3aHkgd2UgY291bGRuJ3QuCgo+IE1h eWJlIHdlIGp1c3QgaGF2ZSB0byByZXF1aXJlIHRoZSBzY2FsaW5nIG1vZGUgdG8gYmUgc2V0IHRv IGZ1bGxzY3JlZW4gCj4gdG8gYWxsb3cgYm9yZGVycyB0byBiZSBzcGVjaWZpZWQgZXhwbGljdGx5 Pwo+IAo+ID4gKwo+ID4gKwlpZiAoIXZjNF9wc3RhdGUtPmNydGNfdyB8fCAhdmM0X3BzdGF0ZS0+ Y3J0Y19oKQo+ID4gKwkJcmV0dXJuIC1FSU5WQUw7Cj4gPiArCj4gPiArCXJldHVybiAwOwo+ID4g K30KPiA+ICsKPiA+ICBzdGF0aWMgaW50IHZjNF9wbGFuZV9zZXR1cF9jbGlwcGluZ19hbmRfc2Nh bGluZyhzdHJ1Y3QgZHJtX3BsYW5lX3N0YXRlICpzdGF0ZSkKPiA+ICB7Cj4gPiAgCXN0cnVjdCBk cm1fcGxhbmUgKnBsYW5lID0gc3RhdGUtPnBsYW5lOwo+ID4gQEAgLTI2OSw3ICszMTIsNyBAQCBz dGF0aWMgaW50IHZjNF9wbGFuZV9zZXR1cF9jbGlwcGluZ19hbmRfc2NhbGluZyhzdHJ1Y3QgZHJt X3BsYW5lX3N0YXRlICpzdGF0ZSkKPiA+ICAJaW50IG51bV9wbGFuZXMgPSBmYi0+Zm9ybWF0LT5u dW1fcGxhbmVzOwo+ID4gIAl1MzIgaF9zdWJzYW1wbGUgPSAxOwo+ID4gIAl1MzIgdl9zdWJzYW1w bGUgPSAxOwo+ID4gLQlpbnQgaTsKPiA+ICsJaW50IGksIHJldDsKPiA+ICAKPiA+ICAJZm9yIChp ID0gMDsgaSA8IG51bV9wbGFuZXM7IGkrKykKPiA+ICAJCXZjNF9zdGF0ZS0+b2Zmc2V0c1tpXSA9 IGJvLT5wYWRkciArIGZiLT5vZmZzZXRzW2ldOwo+ID4gQEAgLTI5Miw2ICszMzUsMTAgQEAgc3Rh dGljIGludCB2YzRfcGxhbmVfc2V0dXBfY2xpcHBpbmdfYW5kX3NjYWxpbmcoc3RydWN0IGRybV9w bGFuZV9zdGF0ZSAqc3RhdGUpCj4gPiAgCXZjNF9zdGF0ZS0+Y3J0Y193ID0gc3RhdGUtPmNydGNf dzsKPiA+ICAJdmM0X3N0YXRlLT5jcnRjX2ggPSBzdGF0ZS0+Y3J0Y19oOwo+ID4gIAo+ID4gKwly ZXQgPSB2YzRfcGxhbmVfdW5kZXJzY2FuX2FkaihzdGF0ZSk7Cj4gPiArCWlmIChyZXQpCj4gPiAr CQlyZXR1cm4gcmV0Owo+ID4gKwo+ID4gIAl2YzRfc3RhdGUtPnhfc2NhbGluZ1swXSA9IHZjNF9n ZXRfc2NhbGluZ19tb2RlKHZjNF9zdGF0ZS0+c3JjX3dbMF0sCj4gPiAgCQkJCQkJICAgICAgIHZj NF9zdGF0ZS0+Y3J0Y193KTsKPiA+ICAJdmM0X3N0YXRlLT55X3NjYWxpbmdbMF0gPSB2YzRfZ2V0 X3NjYWxpbmdfbW9kZSh2YzRfc3RhdGUtPnNyY19oWzBdLAo+ID4gLS0gCj4gPiAyLjE0LjEKPiA+ IAo+ID4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiA+ IGRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKPiA+IGRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5v cmcKPiA+IGh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJp LWRldmVsICAKPiAKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fCmFtZC1nZnggbWFpbGluZyBsaXN0CmFtZC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0 dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vYW1kLWdmeAo=