All of lore.kernel.org
 help / color / mirror / Atom feed
From: tj at kernel.org (Tejun Heo)
Subject: [PATCH v2] selftests/cgroup: memory controller self-tests
Date: Fri, 11 May 2018 13:02:50 -0700	[thread overview]
Message-ID: <20180511200250.GW2368884@devbig577.frc2.facebook.com> (raw)
In-Reply-To: <fb835740-cee8-83f8-880c-ea6eea8c7c63@kernel.org>

On Fri, May 11, 2018 at 01:33:26PM -0600, Shuah Khan wrote:
> Yeah. I see that. You have a switch for the KSFT_ values. Since there is no
> dependency on the cgroup tree, I would recommend having this patch go through
> kselftest tree which is the normal process for tests anyway.
> 
> This version is good and I can apply this to linux-kselftest next. I ran a
> quick test and the Skip case looks good.
> 
> TAP version 13
> selftests: cgroup: test_memcontrol
> ========================================
> 1..0 # Skipped: memory controller isn't available
> not ok 1..1 selftests: cgroup: test_memcontrol [SKIP]
> 
> 
> Tejun! Please send me your Ack.

Sure, please feel free to add my ack.  I'll revert the original patch
from cgroup tree.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: tj@kernel.org (Tejun Heo)
Subject: [PATCH v2] selftests/cgroup: memory controller self-tests
Date: Fri, 11 May 2018 13:02:50 -0700	[thread overview]
Message-ID: <20180511200250.GW2368884@devbig577.frc2.facebook.com> (raw)
Message-ID: <20180511200250.hKi5F2f8pPKzRFRTgba07aNH2NM8pfU9K1iEH5B0_oo@z> (raw)
In-Reply-To: <fb835740-cee8-83f8-880c-ea6eea8c7c63@kernel.org>

On Fri, May 11, 2018@01:33:26PM -0600, Shuah Khan wrote:
> Yeah. I see that. You have a switch for the KSFT_ values. Since there is no
> dependency on the cgroup tree, I would recommend having this patch go through
> kselftest tree which is the normal process for tests anyway.
> 
> This version is good and I can apply this to linux-kselftest next. I ran a
> quick test and the Skip case looks good.
> 
> TAP version 13
> selftests: cgroup: test_memcontrol
> ========================================
> 1..0 # Skipped: memory controller isn't available
> not ok 1..1 selftests: cgroup: test_memcontrol [SKIP]
> 
> 
> Tejun! Please send me your Ack.

Sure, please feel free to add my ack.  I'll revert the original patch
from cgroup tree.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: Tejun Heo <tj@kernel.org>
To: Shuah Khan <shuah@kernel.org>
Cc: Roman Gushchin <guro@fb.com>,
	Johannes Weiner <hannes@cmpxchg.org>,
	Michal Hocko <mhocko@suse.com>,
	Mike Rapoport <rppt@linux.vnet.ibm.com>,
	kernel-team@fb.com, linux-kselftest@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] selftests/cgroup: memory controller self-tests
Date: Fri, 11 May 2018 13:02:50 -0700	[thread overview]
Message-ID: <20180511200250.GW2368884@devbig577.frc2.facebook.com> (raw)
In-Reply-To: <fb835740-cee8-83f8-880c-ea6eea8c7c63@kernel.org>

On Fri, May 11, 2018 at 01:33:26PM -0600, Shuah Khan wrote:
> Yeah. I see that. You have a switch for the KSFT_ values. Since there is no
> dependency on the cgroup tree, I would recommend having this patch go through
> kselftest tree which is the normal process for tests anyway.
> 
> This version is good and I can apply this to linux-kselftest next. I ran a
> quick test and the Skip case looks good.
> 
> TAP version 13
> selftests: cgroup: test_memcontrol
> ========================================
> 1..0 # Skipped: memory controller isn't available
> not ok 1..1 selftests: cgroup: test_memcontrol [SKIP]
> 
> 
> Tejun! Please send me your Ack.

Sure, please feel free to add my ack.  I'll revert the original patch
from cgroup tree.

Thanks.

-- 
tejun

  reply	other threads:[~2018-05-11 20:02 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-10 16:37 [PATCH v2] selftests/cgroup: memory controller self-tests guro
2018-05-10 16:37 ` Roman Gushchin
2018-05-10 16:37 ` Roman Gushchin
2018-05-10 18:32 ` tj
2018-05-10 18:32   ` Tejun Heo
2018-05-10 18:32   ` Tejun Heo
2018-05-10 19:29   ` shuah
2018-05-10 19:29     ` Shuah Khan
2018-05-10 19:29     ` Shuah Khan
2018-05-11 14:32     ` tj
2018-05-11 14:32       ` Tejun Heo
2018-05-11 14:32       ` Tejun Heo
2018-05-11 14:55       ` shuah
2018-05-11 14:55         ` Shuah Khan
2018-05-11 14:55         ` Shuah Khan
2018-05-11 16:29         ` tj
2018-05-11 16:29           ` Tejun Heo
2018-05-11 16:29           ` Tejun Heo
2018-05-11 16:58           ` shuah
2018-05-11 16:58             ` Shuah Khan
2018-05-11 16:58             ` Shuah Khan
2018-05-11 18:03             ` guro
2018-05-11 18:03               ` Roman Gushchin
2018-05-11 18:03               ` Roman Gushchin
2018-05-11 19:33               ` shuah
2018-05-11 19:33                 ` Shuah Khan
2018-05-11 19:33                 ` Shuah Khan
2018-05-11 20:02                 ` tj [this message]
2018-05-11 20:02                   ` Tejun Heo
2018-05-11 20:02                   ` Tejun Heo
2018-05-11 20:22                   ` shuah
2018-05-11 20:22                     ` Shuah Khan
2018-05-11 20:22                     ` Shuah Khan
2018-05-18 19:24                     ` shuah
2018-05-18 19:24                       ` Shuah Khan
2018-05-18 19:24                       ` Shuah Khan
2018-05-10 19:45 ` shuah
2018-05-10 19:45   ` Shuah Khan
2018-05-10 19:45   ` Shuah Khan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180511200250.GW2368884@devbig577.frc2.facebook.com \
    --to=unknown@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.