From: Martin Jansa <martin.jansa@gmail.com>
To: Chris Patterson <cjp256@gmail.com>
Cc: Chris Patterson <pattersonc@ainfosec.com>,
Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] qemu: add gettext to DEPENDS
Date: Fri, 11 May 2018 23:32:10 +0200 [thread overview]
Message-ID: <20180511213210.GC2141@jama> (raw)
In-Reply-To: <CABZSBQeN+mx7Y8oQ8fhPf=xeuqLa2RpjwHLkVAPD2qoSzvzQMg@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1344 bytes --]
On Fri, May 11, 2018 at 05:21:09PM -0400, Chris Patterson wrote:
> On Fri, May 11, 2018 at 3:10 PM, Christopher Larson <kergoth@gmail.com> wrote:
> > This is not a correct fix. We have a gettext bbclass for a reason.
> >
>
> I did look at that prior to doing this. It was my initial approach,
> but inheriting gettext causes qemu build to fail when it modifies the
> EXTRA_OECONF options with the nls flag (that qemu doesn't process).
> There are quite a few other recipes using gettext-native in their
> DEPENDS, and the reason for one over the other isn't quite clear.
>
> In the other thread (v2), Khem requested it only be added
> conditionally if the gtk packageconfig flag is enabled. Do you think
> it would be appropriate to check packageconfig flag, then
> conditionally inherit, then resolve (scrub) the unsupported configure
> flags? Or modify the class such that modifying the OECONF is prevented
> to begin with?
Are you using gtk PACKAGECONFIG for qemu-native (or nativesdk-qemu)?
Last time I've tried I've found that there are many things missing to
make it usable, see last few commits at:
http://git.openembedded.org/openembedded-core-contrib/log/?h=jansa/qemu
I haven't tried gtk(3) for target build, it probably works better there.
--
Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 201 bytes --]
next prev parent reply other threads:[~2018-05-11 21:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-11 16:35 [PATCH] qemu: add gettext to DEPENDS Chris Patterson
2018-05-11 19:10 ` Christopher Larson
2018-05-11 21:21 ` Chris Patterson
2018-05-11 21:32 ` Martin Jansa [this message]
2018-05-11 21:37 ` Chris Patterson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180511213210.GC2141@jama \
--to=martin.jansa@gmail.com \
--cc=cjp256@gmail.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=pattersonc@ainfosec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.