From: Kalle Valo <kvalo@codeaurora.org>
To: Erik Stromdahl <erik.stromdahl@gmail.com>
Cc: kvalo@qca.qualcomm.com, linux-wireless@vger.kernel.org,
ath10k@lists.infradead.org,
Erik Stromdahl <erik.stromdahl@gmail.com>
Subject: Re: ath10k: fix return value check in wake_tx_q op
Date: Sat, 12 May 2018 09:03:32 +0000 (UTC) [thread overview]
Message-ID: <20180512090332.895FF6079C@smtp.codeaurora.org> (raw)
In-Reply-To: <20180506132500.16888-1-erik.stromdahl@gmail.com>
Erik Stromdahl <erik.stromdahl@gmail.com> wrote:
> ath10k_mac_tx_push_txq returns either a postive integer (length) on
> success or a negative error code on error.
>
> The "if (ret) break;" statement will thus always break out of the loop
> immediately after ath10k_mac_tx_push_txq has returned (making the loop
> pointless).
>
> A side effect of this fix is that we will iterate the queue until
> ath10k_mac_tx_push_txq returns -ENOENT. This will make sure the queue is
> not added back to ar->txqs when it is empty. This could potentially
> improve performance somewhat (I have seen a small improvement with SDIO
> devices).
>
> Signed-off-by: Erik Stromdahl <erik.stromdahl@gmail.com>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Patch applied to ath-next branch of ath.git, thanks.
e3148cc5fecf ath10k: fix return value check in wake_tx_q op
--
https://patchwork.kernel.org/patch/10382789/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2018-05-12 9:03 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-06 13:25 [PATCH] ath10k: fix return value check in wake_tx_q op Erik Stromdahl
2018-05-06 13:25 ` Erik Stromdahl
2018-05-12 9:03 ` Kalle Valo [this message]
2018-05-12 9:03 ` Kalle Valo
[not found] ` <6dc00772b826410e930306891fd13ed9@euamsexm01f.eu.qualcomm.com>
[not found] ` <c77a1c0961f34ee68b7266444d2207f5@aptaiexm02e.ap.qualcomm.com>
2019-01-28 7:01 ` FW: [PATCH] " yiboz
2019-01-28 7:01 ` yiboz
2019-02-07 14:25 ` Kalle Valo
2019-02-07 14:25 ` Kalle Valo
2019-02-25 4:40 ` Yibo Zhao
2019-02-25 4:40 ` Yibo Zhao
2019-03-04 1:56 ` Yibo Zhao
2019-03-04 1:56 ` Yibo Zhao
2019-03-11 6:44 ` Erik Stromdahl
2019-03-11 6:44 ` Erik Stromdahl
2019-03-12 2:23 ` Yibo Zhao
2019-03-12 2:23 ` Yibo Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180512090332.895FF6079C@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=ath10k@lists.infradead.org \
--cc=erik.stromdahl@gmail.com \
--cc=kvalo@qca.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.