From: Al Viro <viro@ZenIV.linux.org.uk>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: linux-fsdevel <linux-fsdevel@vger.kernel.org>,
NeilBrown <neilb@suse.com>
Subject: Re: [RFC][PATCH] fix breakage caused by d_find_alias() semantics change
Date: Sun, 13 May 2018 19:56:46 +0100 [thread overview]
Message-ID: <20180513185646.GS30522@ZenIV.linux.org.uk> (raw)
In-Reply-To: <CA+55aFxwaTbqxbmLk3WNthtqC4wg+Nn3=jqLYY-_r=rYTZ_R8g@mail.gmail.com>
On Sun, May 13, 2018 at 11:35:15AM -0700, Linus Torvalds wrote:
> On Sun, May 13, 2018 at 9:18 AM Al Viro <viro@zeniv.linux.org.uk> wrote:
>
> > /* Called from selinux_complete_init, try to find
> a dentry. */
> > dentry = d_find_alias(inode);
> > + if (!dentry)
> > + dentry = d_find_any_alias(inode);
>
> Can you please explain why this isn't just
>
> dentry = d_find_any_alias(inode);
>
> without the initial "try to find a hashed alias"?
The whole reason why that thing is getting a dentry is that some filesystems
really want a *connected* dentry for getxattr. Sure, saner ones will be
happy with disconnected dentry, but...
If you want to rearchitect the shitpile under security/* so that it would
not rely upon accidental properties of filesystems, you are welcome to that
and to the resulting psychiatrist bills ;-/
next prev parent reply other threads:[~2018-05-13 18:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-13 15:51 [RFC][PATCH] fix breakage caused by d_find_alias() semantics change Al Viro
2018-05-13 18:35 ` Linus Torvalds
2018-05-13 18:56 ` Al Viro [this message]
2018-05-13 18:59 ` Linus Torvalds
2018-05-13 19:48 ` Al Viro
2018-05-13 20:24 ` Linus Torvalds
2018-05-13 22:02 ` NeilBrown
2018-05-13 22:17 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180513185646.GS30522@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=linux-fsdevel@vger.kernel.org \
--cc=neilb@suse.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.