From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ayan Halder Subject: Re: [PATCH v3 5/5] drm/arm/malidp: Added the late system pm functions Date: Mon, 14 May 2018 11:01:26 +0100 Message-ID: <20180514100126.GA24437@arm.com> References: <1524593567-5559-1-git-send-email-ayan.halder@arm.com> <1524593567-5559-6-git-send-email-ayan.halder@arm.com> <20180425071722.GN25142@phenom.ffwll.local> <20180425112604.GP14661@e110455-lin.cambridge.arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on0067.outbound.protection.outlook.com [104.47.2.67]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7DE0B89F5B for ; Mon, 14 May 2018 10:01:40 +0000 (UTC) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Daniel Vetter Cc: Dave Airlie , "Rafael J. Wysocki" , Liviu Dudau , Linux Kernel Mailing List , dri-devel , nd@arm.com List-Id: dri-devel@lists.freedesktop.org T24gV2VkLCBBcHIgMjUsIDIwMTggYXQgMDE6NDk6MzVQTSArMDIwMCwgRGFuaWVsIFZldHRlciB3 cm90ZToKSGkgRGFuaWVsLAo+IE9uIFdlZCwgQXByIDI1LCAyMDE4IGF0IDE6MjYgUE0sIExpdml1 IER1ZGF1IDxsaXZpdS5kdWRhdUBhcm0uY29tPiB3cm90ZToKPiA+IE9uIFdlZCwgQXByIDI1LCAy MDE4IGF0IDA5OjE3OjIyQU0gKzAyMDAsIERhbmllbCBWZXR0ZXIgd3JvdGU6Cj4gPj4gT24gVHVl LCBBcHIgMjQsIDIwMTggYXQgMDc6MTI6NDdQTSArMDEwMCwgQXlhbiBLdW1hciBIYWxkZXIgd3Jv dGU6Cj4gPj4gPiBtYWxpZHBfcG1fc3VzcGVuZF9sYXRlIGNoZWNrcyBpZiB0aGUgcnVudGltZSBz dGF0dXMgaXMgbm90IHN1c3BlbmRlZAo+ID4+ID4gYW5kIGlmIHNvLCBpbnZva2VzIG1hbGlkcF9y dW50aW1lX3BtX3N1c3BlbmQgd2hpY2ggZGlzYWJsZXMgdGhlCj4gPj4gPiBkaXNwbGF5IGVuZ2lu ZS9jb3JlIGludGVycnVwdHMgYW5kIHRoZSBjbG9ja3MuIEl0IHNldHMgdGhlIHJ1bnRpbWUgc3Rh dHVzCj4gPj4gPiBhcyBzdXNwZW5kZWQuCj4gPj4gPgo+ID4+ID4gVGhlIGRpZmZlcmVuY2UgYmV0 d2VlbiBzdXNwZW5kKCkgYW5kIHN1c3BlbmRfbGF0ZSgpIGlzIGFzIGZvbGxvd3M6LQo+ID4+ID4g MS4gc3VzcGVuZCgpIG1ha2VzIHRoZSBkZXZpY2UgcXVpZXNjZW50LiBJbiBvdXIgY2FzZSwgd2Ug aW52b2tlIHRoZSBEUk0KPiA+PiA+IGhlbHBlciB3aGljaCBkaXNhYmxlcyB0aGUgQ1JUQy4gVGhp cyB3b3VsZCBoYXZlIGludm9rZWQgcnVudGltZSBwbQo+ID4+ID4gc3VzcGVuZCBidXQgdGhlIHN5 c3RlbSBzdXNwZW5kIHByb2Nlc3MgZGlzYWJsZXMgcnVudGltZSBwbS4KPiA+PiA+IDIuIHN1c3Bl bmRfbGF0ZSgpIEl0IGNvbnRpbnVlcyB0aGUgc3VzcGVuZCBvcGVyYXRpb25zIG9mIHRoZSBkcm0g ZGV2aWNlCj4gPj4gPiB3aGljaCB3YXMgc3RhcnRlZCBieSBzdXNwZW5kKCkuIEluIG91ciBjYXNl LCBpdCBwZXJmb3JtcyB0aGUgc2FtZSBmdW5jdGlvbmFsaXR5Cj4gPj4gPiBhcyBydW50aW1lX3N1 c3BlbmQoKS4KPiA+PiA+Cj4gPj4gPiBUaGUgY29tcGxpbWVudGFyeSBmdW5jdGlvbnMgYXJlIHJl c3VtZSgpIGFuZCByZXN1bWVfZWFybHkoKS4gSW4gdGhlIGNhc2Ugb2YKPiA+PiA+IHJlc3VtZV9l YXJseSgpLCB3ZSBpbnZva2UgbWFsaWRwX3J1bnRpbWVfcG1fcmVzdW1lKCkgd2hpY2ggZW5hYmxl cyB0aGUgY2xvY2tzCj4gPj4gPiBhbmQgdGhlIGludGVycnVwdHMuIEl0IHNldHMgdGhlIHJ1bnRp bWUgc3RhdHVzIGFzIGFjdGl2ZS4gSWYgdGhlIGRldmljZSB3YXMKPiA+PiA+IGluIHJ1bnRpbWUg c3VzcGVuZCBtb2RlIGJlZm9yZSBzeXN0ZW0gc3VzcGVuZCB3YXMgY2FsbGVkLCBwbV9ydW50aW1l X3dvcmsoKQo+ID4+ID4gd2lsbCBwdXQgdGhlIGRldmljZSBiYWNrIGluIHJ1bnRpbWUgc3VzcGVu ZGVkIG1vZGUoIGFmdGVyIHRoZSBjb21wbGV0ZSBzeXN0ZW0KPiA+PiA+IGhhcyBiZWVuIHJlc3Vt ZWQpLgo+ID4+ID4KPiA+PiA+IFNpZ25lZC1vZmYtYnk6IEF5YW4gS3VtYXIgSGFsZGVyIDxheWFu LmhhbGRlckBhcm0uY29tPgo+ID4+ID4KPiA+Pgo+ID4+IEFmYWl1aSB3ZSBzdGlsbCBoYXZlbid0 IGJvdHRvbWVkIG91dCBvbiB0aGUgZGlzY3Vzc2lvbiBvbiB2MS4gRGlkIHlvdSBnZXQKPiA+PiBo b2xkIG9mIFJhZmFlbD8KPiA+Cj4gPiBObywgdGhlcmUgd2FzIG5vIHJlcGx5IGZyb20gaGltLiBM ZXRzIHRyeSBhZ2FpbjoKPiA+Cj4gPiBSYWZhZWwsIHdlIGFyZSBkZWJhdGluZyBvbiB3aGF0IHRo ZSBwcm9wZXIgYXBwcm9hY2ggaXMgZm9yIGhhbmRsaW5nIHRoZQo+ID4gc3VzcGVuZC9yZXN1bWUg Y2FsbGJhY2tzIGZvciBhIERSTSBkcml2ZXIgdGhhdCBpcyBsaWtlbHkgdG8gbm90IGJlCj4gPiBy dW50aW1lIHN1c3BlbmRlZCB3aGVuIHRoZSBwb3dlci1kb3duIGhhcHBlbnMgKGJlY2F1c2Ugd2Ug YXJlIGRyaXZpbmcKPiA+IHRoZSBkaXNwbGF5IG91dHB1dCkuIFdlIGFyZSB1c2luZyBpbiB0aGlz IHBhdGNoIHRoZSBMQVRFX1NZU1RFTV9TTEVFUF9QTV9PUFMKPiA+IGluIG9yZGVyIHRvIGRvIHRo ZSB3b3JrIHRoYXQgd2UgYWxzbyBkbyBkdXJpbmcgcnVudGltZSBzdXNwZW5kLCB3aGljaCBpcwo+ ID4gdHVybmluZyBvZmYgdGhlIG91dHB1dCBhbmQgdGhlIGNsb2NrcyBkcml2aW5nIGl0LiBUaGUg cmVhc29uIGZvciBkb2luZwo+ID4gdGhhdCBpcyBiZWNhdXNlIHRoZSBQTSBjb3JlIHRha2VzIGEg cnVudGltZSByZWZlcmVuY2UgZHVyaW5nIHN5c3RlbQo+ID4gc3VzcGVuZCBmb3IgYWxsIGRldmlj ZXMgdGhhdCBhcmUgbm90IGFscmVhZHkgcnVudGltZSBzdXNwZW5kZWQsIHNvIG91cgo+ID4gcnVu dGltZV9wbV9zdXNwZW5kKCkgaG9vayBpcyBuZXZlciBjYWxsZWQuCj4gPgo+ID4gRGFuaWVsJ3Mg YXJndW1lbnQgaXMgdGhhdCB3ZSBzaG91bGQgbm90IGJlIGRvaW5nIHRoaXMgZnJvbSBMQVRFIGhv b2tzLAo+ID4gYnV0IGZyb20gdGhlIG5vcm1hbCBzdXNwZW5kIGhvb2tzLCBob3dldmVyIGtlcm5l bCBkb2Mgc2VlbXMgdG8gc3VnZ2VzdAo+ID4gb3RoZXJ3aXNlLgo+IAo+IEZvciBtb3JlIGNvbnRl eHQ6IEkgdGhvdWdodCB0aGUgcmVhc29uIGJlaGluZCB0aGUgcmVjb21tZW5kYXRpb24gdG8KPiBz dHVmZiB0aGUgcnBtIGNhbGxiYWNrcyBpbnRvIHRoZSBsYXRlL2Vhcmx5IGhvb2tzIHdhcyB0byBz b2x2ZQo+IGNyb3NzLWRldmljZSBvcmRlcmluZyBpc3N1ZXMuIFRoYXQgd2F5IGV2ZXJ5b25lIHNo dXRzIGRvd24gdGhlIGRldmljZQo+IGZ1bmN0aW9uYWxpdHkgaW4gdGhlIG5vcm1hbCBob29rcywg YnV0IG9ubHkgcG93ZXJzIHRoZW0gb2ZmIGluIHRoZQo+IGxhdGUgaG9vayAodG8gYWxsb3cgb3Ro ZXIgZHJpdmVycyB0byBrZWVwIHVzaW5nIHRoZSBjbG9jay9pMmMKPiBtYXN0ZXIvd2hhdGV2ZXIp LiBCdXQgd2Ugbm93IGhhdmUgZGV2aWNlX2xpbmsgdG8gc29sdmUgdGhhdCBzaW5jZSBhCj4gd2hp bGUsIHNvIEknbSBub3Qgc3VyZSB0aGUgcmVjb21tZW5kYXRpb24gdG8gc3R1ZmYgdGhlIHJwbSBo b29rcyBpbnRvCj4gbGF0ZS9lYXJseSBjYWxsYmFja3MgaXMgc3RpbGwgY29ycmVjdC4KPiAtRGFu aWVsCj4gCkl0IGhhcyBiZWVuIG1vcmUgdGhhbiB0d28gd2Vla3MgYW5kIHdlIGhhdmUgbm90IGdv dCBhbnkgcmVzcG9uc2UgZnJvbQpSYWZhZWwuIENhbiB5b3UgcGluZyBoaW0gcGVyc29uYWxseSBv ciBzdWdnZXN0IGFueSB3YXkgYnkgd2hpY2ggYXNrCmhpbSB0byByZXNwb25kPwo+ID4KPiA+IEJl c3QgcmVnYXJkcywKPiA+IExpdml1Cj4gPgo+ID4KPiA+Cj4gPj4gLURhbmllbAo+ID4+Cj4gPj4g PiAtLS0KPiA+PiA+IENoYW5nZXMgaW4gdjM6LQo+ID4+ID4gLSBSZWJhc2VkIG9uIHRvcCBvZiBl YXJsaWVyIHYzIHBhdGNoZXMsCj4gPj4gPgo+ID4+ID4gQ2hhbmdlcyBpbiB2MjotCj4gPj4gPiAt IFJlbW92ZWQgdGhlIGNoYW5nZSBpZCBhbmQgbW9kaWZpZWQgdGhlIGNvbW1pdCBtZXNzYWdlCj4g Pj4gPiAtLS0KPiA+PiA+ICBkcml2ZXJzL2dwdS9kcm0vYXJtL21hbGlkcF9kcnYuYyB8IDE3ICsr KysrKysrKysrKysrKysrCj4gPj4gPiAgMSBmaWxlIGNoYW5nZWQsIDE3IGluc2VydGlvbnMoKykK PiA+PiA+Cj4gPj4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2FybS9tYWxpZHBfZHJ2 LmMgYi9kcml2ZXJzL2dwdS9kcm0vYXJtL21hbGlkcF9kcnYuYwo+ID4+ID4gaW5kZXggODIyMjFl YS4uYzUzYjQ2YSAxMDA2NDQKPiA+PiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9hcm0vbWFsaWRw X2Rydi5jCj4gPj4gPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vYXJtL21hbGlkcF9kcnYuYwo+ID4+ ID4gQEAgLTc2OCw4ICs3NjgsMjUgQEAgc3RhdGljIGludCBfX21heWJlX3VudXNlZCBtYWxpZHBf cG1fcmVzdW1lKHN0cnVjdCBkZXZpY2UgKmRldikKPiA+PiA+ICAgICByZXR1cm4gMDsKPiA+PiA+ ICB9Cj4gPj4gPgo+ID4+ID4gK3N0YXRpYyBpbnQgX19tYXliZV91bnVzZWQgbWFsaWRwX3BtX3N1 c3BlbmRfbGF0ZShzdHJ1Y3QgZGV2aWNlICpkZXYpCj4gPj4gPiArewo+ID4+ID4gKyAgIGlmICgh cG1fcnVudGltZV9zdGF0dXNfc3VzcGVuZGVkKGRldikpIHsKPiA+PiA+ICsgICAgICAgICAgIG1h bGlkcF9ydW50aW1lX3BtX3N1c3BlbmQoZGV2KTsKPiA+PiA+ICsgICAgICAgICAgIHBtX3J1bnRp bWVfc2V0X3N1c3BlbmRlZChkZXYpOwo+ID4+ID4gKyAgIH0KPiA+PiA+ICsgICByZXR1cm4gMDsK PiA+PiA+ICt9Cj4gPj4gPiArCj4gPj4gPiArc3RhdGljIGludCBfX21heWJlX3VudXNlZCBtYWxp ZHBfcG1fcmVzdW1lX2Vhcmx5KHN0cnVjdCBkZXZpY2UgKmRldikKPiA+PiA+ICt7Cj4gPj4gPiAr ICAgbWFsaWRwX3J1bnRpbWVfcG1fcmVzdW1lKGRldik7Cj4gPj4gPiArICAgcG1fcnVudGltZV9z ZXRfYWN0aXZlKGRldik7Cj4gPj4gPiArICAgcmV0dXJuIDA7Cj4gPj4gPiArfQo+ID4+ID4gKwo+ ID4+ID4gIHN0YXRpYyBjb25zdCBzdHJ1Y3QgZGV2X3BtX29wcyBtYWxpZHBfcG1fb3BzID0gewo+ ID4+ID4gICAgIFNFVF9TWVNURU1fU0xFRVBfUE1fT1BTKG1hbGlkcF9wbV9zdXNwZW5kLCBtYWxp ZHBfcG1fcmVzdW1lKSBcCj4gPj4gPiArICAgU0VUX0xBVEVfU1lTVEVNX1NMRUVQX1BNX09QUyht YWxpZHBfcG1fc3VzcGVuZF9sYXRlLCBtYWxpZHBfcG1fcmVzdW1lX2Vhcmx5KSBcCj4gPj4gPiAg ICAgU0VUX1JVTlRJTUVfUE1fT1BTKG1hbGlkcF9ydW50aW1lX3BtX3N1c3BlbmQsIG1hbGlkcF9y dW50aW1lX3BtX3Jlc3VtZSwgTlVMTCkKPiA+PiA+ICB9Owo+ID4+ID4KPiA+PiA+IC0tCj4gPj4g PiAyLjcuNAo+ID4+ID4KPiA+PiA+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fCj4gPj4gPiBkcmktZGV2ZWwgbWFpbGluZyBsaXN0Cj4gPj4gPiBkcmktZGV2 ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gPj4gPiBodHRwczovL2xpc3RzLmZyZWVkZXNrdG9w Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo+ID4+Cj4gPj4gLS0KPiA+PiBEYW5pZWwg VmV0dGVyCj4gPj4gU29mdHdhcmUgRW5naW5lZXIsIEludGVsIENvcnBvcmF0aW9uCj4gPj4gaHR0 cDovL2Jsb2cuZmZ3bGwuY2gKPiA+Cj4gPiAtLQo+ID4gPT09PT09PT09PT09PT09PT09PT0KPiA+ IHwgSSB3b3VsZCBsaWtlIHRvIHwKPiA+IHwgZml4IHRoZSB3b3JsZCwgIHwKPiA+IHwgYnV0IHRo ZXkncmUgbm90IHwKPiA+IHwgZ2l2aW5nIG1lIHRoZSAgIHwKPiA+ICBcIHNvdXJjZSBjb2RlISAg Lwo+ID4gICAtLS0tLS0tLS0tLS0tLS0KPiA+ICAgICA/P1xfKD8/PylfLz8/Cj4gPiBfX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+ID4gZHJpLWRldmVsIG1h aWxpbmcgbGlzdAo+ID4gZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+ID4gaHR0cHM6 Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwKPiAKPiAK PiAKPiAtLSAKPiBEYW5pZWwgVmV0dGVyCj4gU29mdHdhcmUgRW5naW5lZXIsIEludGVsIENvcnBv cmF0aW9uCj4gKzQxICgwKSA3OSAzNjUgNTcgNDggLSBodHRwOi8vYmxvZy5mZndsbC5jaApfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFp bGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5m cmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752200AbeENKBn (ORCPT ); Mon, 14 May 2018 06:01:43 -0400 Received: from mail-eopbgr10070.outbound.protection.outlook.com ([40.107.1.70]:46400 "EHLO EUR02-HE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751219AbeENKBl (ORCPT ); Mon, 14 May 2018 06:01:41 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Ayan.Halder@arm.com; Date: Mon, 14 May 2018 11:01:26 +0100 From: Ayan Halder To: Daniel Vetter Cc: Liviu Dudau , Brian Starkey , Dave Airlie , dri-devel , Linux Kernel Mailing List , "Rafael J. Wysocki" , nd@arm.com Subject: Re: [PATCH v3 5/5] drm/arm/malidp: Added the late system pm functions Message-ID: <20180514100126.GA24437@arm.com> References: <1524593567-5559-1-git-send-email-ayan.halder@arm.com> <1524593567-5559-6-git-send-email-ayan.halder@arm.com> <20180425071722.GN25142@phenom.ffwll.local> <20180425112604.GP14661@e110455-lin.cambridge.arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-Originating-IP: [217.140.96.140] X-ClientProxiedBy: CWLP265CA0057.GBRP265.PROD.OUTLOOK.COM (2603:10a6:401:12::21) To DB7PR08MB3034.eurprd08.prod.outlook.com (2603:10a6:5:1d::12) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(7020095)(4652020)(5600026)(48565401081)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020);SRVR:DB7PR08MB3034; X-Microsoft-Exchange-Diagnostics: 1;DB7PR08MB3034;3:jlV8NrAp5lZhBBz1ot4/nihauhUR3Q/V09uvG3kTWghD+XPBNCr7PzHzWb8pzo01tezlnTtSzfimvHolMpVjht8KGAjfpGuHqtvaGqQyOAFiZpARubEvrRGV9IwGWoaK/FBXe40FU7JOl9lVdw4R4RTBLX1TwkkypF0fZ2hwH9FLaIUABNjALzQq7SD8wAtDj6dffmdcJ/CJKSW1H9g3DOTGRrfb0PQn1r1ePlBL3lZusvZBEpVtbxAdvXCz1mRP;25:BTdnHYNrv0O4458iOpB5XDsP5ZlSohTD7Mf5lwJC6wzuFt9nspN6SocwGQL7Hl21i++ZdeTaWrW00yXON67P004ti2bhliJh+uKL6aO3A5rprpuhZjiF0Zb9Hl299wxdBLuFSoS5gNP5SH2JEp4y0UptDBWJDcb7AOOhNgxXQ9y/lqR39JcX292d/fPjChQ4jQ9sagr+/Hcqu8CRAj9s9RJKN1SlxQISP3spY4/mbXLwbdnTY7cqrS+vjLplFKByBMDe7RF+FkpYaofxaudUumpb4OB/GRU+O1RT7RoZaNRhinasDvG+xemiB9QjxpleSmoMk5mhSnZfpcbHO/jwsg==;31:A1wf9pPsEplVPiT2jFVrpVyfS/6P42j295nC+Sir1Bq16MSSVPfZHaJ90ZH5MxnJTUjC7VJiyN7wI+0s7cXM+JPwv1tyD2+Rd9dzOGExLpmmrJMJ5E7+HNwzwN83UgIgQTtQTj7F8qdOpcLBEuxIGFH7SKiaHycvO3XUmpvnpxMVfoqVi7o0TTf1kM3/abNk5aTmTINkgIcCq2j4k1SGZDyQXnqJ4Smms14UQ/ZCq14= X-MS-TrafficTypeDiagnostic: DB7PR08MB3034: NoDisclaimer: True X-Microsoft-Exchange-Diagnostics: 1;DB7PR08MB3034;20:m38SJD5rcZtzcdBk4WpzokHH99ztVnoFLDoH9EgEu0Qs0pog4FxDSIg62tR/mm+RWe2gRKJgL9T0qrG9YXWnHF1auXEOn8YS9bcDmS6hyeVB+i9fx8w1mmLF1fDZ7UvxwVni5nnLGCoiaPdlzWLw2vnD6sKKR3kiYVSx13FGITGCaf7GnlsOgy+abE+Hz4/TPq7/bYtMD5Kycsfvdw/sJ8SocDe6DDLjMC4sml/qr8H8F/hEJewuvwjdhNv02fp9;4:8Rr4MWBLSjVM0Nf3H+csCzIN0Q6qVRFdukXABKSUK/l4Dx2DMkGdFjtNgujgioXU9e0/RfOmvv02QgjvYYTyMngrDeiL9F2zzVkkp8G9RXTXAZ3lPa1BK0LOaQ6J/oE8tGvZ5Hmn/KiisKAbpgWrcdLmjVVCmh+5dd52ByWJfZ5bXac0uDQ61HgU+2Gdbb+c2dS2dneJ/KQ2JhzBwnSDyMnz0ZqwxxZJ6BzsUbxKgXWuYV0HKH9VLkejh5lzU2EXh5DwdZvddu5gbozjrrBEgfMiIc+B8d5wsW1XVynlWMm2xP6nPlvHBsc8qV0K7GTgplYpYvAIJwSkEqC42p1quSdd+2iWWNnb8HIbCzV++1E= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(180628864354917)(217544274631240); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(93006095)(93001095)(3002001)(3231254)(944501410)(52105095)(10201501046)(6055026)(149027)(150027)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(20161123562045)(20161123558120)(20161123560045)(6072148)(201708071742011);SRVR:DB7PR08MB3034;BCL:0;PCL:0;RULEID:;SRVR:DB7PR08MB3034; X-Forefront-PRVS: 067270ECAF X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6069001)(376002)(346002)(366004)(39380400002)(39860400002)(396003)(199004)(189003)(4326008)(6306002)(6486002)(966005)(72206003)(478600001)(16526019)(186003)(25786009)(7736002)(66066001)(587094005)(26005)(53936002)(53546011)(446003)(47776003)(305945005)(76176011)(11346002)(6916009)(59450400001)(44832011)(52116002)(6666003)(6246003)(86362001)(53386004)(956004)(486006)(6496006)(2616005)(50466002)(386003)(476003)(229853002)(1076002)(93886005)(33656002)(16586007)(23726003)(54906003)(6116002)(81166006)(58126008)(8676002)(5660300001)(81156014)(316002)(97736004)(8936002)(2906002)(105586002)(36756003)(76506005)(68736007)(3846002)(106356001)(18370500001);DIR:OUT;SFP:1101;SCL:1;SRVR:DB7PR08MB3034;H:localhost;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:3; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;DB7PR08MB3034;23:mEloQlrgnrODgNjf/Pzk5MrQodCvd6UHuk0F49yD+?= =?us-ascii?Q?tRU4K9roXZOj0CjFUGaxNHk36HEBFdxihbYXZiuh9xXAkJWlVXn+LBXnK8NO?= =?us-ascii?Q?QUjzIkYsU2DrFwB/T5JyyhQa8jyC+YiPLSeBLMa3WyrgwGSHsiBmpMPyW6ms?= =?us-ascii?Q?YkGx1h9nduqZijgXKDojw6dW2zgthOf+5lLwLZI0JVrJdX7267ikv8QADxgW?= =?us-ascii?Q?U+6UO7UNjMNndCjKlQvWRNYmy4oCxQg+uy47lTyue4K6Uh9sznkYuHhU2+zk?= =?us-ascii?Q?FufLjuepTY24Y9J5wGKIhXObjwqIFG7oE0ju4e6K+dQ0EO5yrX1dyTHLpUWq?= =?us-ascii?Q?miZEmKTesiOnJuQRy1AQ/cmZANCIesocPncy4/Fgfa2dzXlduRVKF13ATz6E?= =?us-ascii?Q?VZrG+MGzFN9K5QNN9v40Hyrlw4TogHKD9LKiMK5udTw5/PxZFxC8LHPiy5rw?= =?us-ascii?Q?dn74NfBbFHr1mfrTorJslZxWoJa95Zb6sH+bTdCrEF+wyj54Cw6W68yo1BgP?= =?us-ascii?Q?mGTDF9lkYll+6zvMNj9Y0yZBr0MwilEMi2s21JuH2X/bsnxUGH8Lb1NMgJUh?= =?us-ascii?Q?vKbYhXT6FpOwgMb6gzyWH9O63qs4TKnAGQKZvP4JBmz1V7KuvaQDhHFnw0/h?= =?us-ascii?Q?Wd1XvYQ/EXaPKWB9p4nytsw3Dk6FcRZNAV2zQrq3Qxkcu6JPIezzbm9duguA?= =?us-ascii?Q?eykuZOLbw69wHHq10WQoy+sBvAhAAAI/qoJiDkrFPF5hh+Zdl7E5NxPL6TGL?= =?us-ascii?Q?vgXsAvOnXMkbqezX+3ALgbCInNXapNuVqucRsEES+zD5480XfX9wTytdfPmM?= =?us-ascii?Q?+ur+JuWi2PvCwmN0UjKLE6+MYEt5q31PRP+QSQTKFMfCJ5+FsMvNxWbef3fG?= =?us-ascii?Q?fxXGAFBPZ1G1WwzB0h4HTD8Ht5kMbc+im8hh+PDArY3NQfhJob9sp+R0rhFN?= =?us-ascii?Q?baGDchK+Zh3JeClid79FpyTMpf9X7Z+W1t9IAqCLJ5J+oxPiyolNN2yVl98z?= =?us-ascii?Q?h4UIKTBNbSOzA7JXNR3YjYmKRtJaJxwQxUBkE/7YwYJ9QyJ67YRw6t5zJ3hr?= =?us-ascii?Q?mnxCv5j9saR5KsduM9UIY6ApJ5S06F6ZpLAuD0Y5MntP/+mZyc5ztZBzByca?= =?us-ascii?Q?Xh5l2rTSWAWg1dJ/v4YjIY/yBvh2zfAp3Y6PsJiNXE82FEIzjtA/qrEnIeNh?= =?us-ascii?Q?RQH90USh3sZYwHuQRPDL4ESlP3iNw9DZFfrqmw7veWKQ/+z5zxHRK941oayO?= =?us-ascii?Q?/1cPP6Nj10OwywvuiIl5He/BweQqc0qr2rOZCNlofeY8DAhkoek4hLkwY/ZO?= =?us-ascii?Q?BqzqS7a1q1kpPUUiq+M2k1B17NJycibeM+0xbpTdn3vBgLpKCblZlrpy1fY8?= =?us-ascii?Q?p40+SFiWk1TQAU9NfylNr0EMv/fAgreSPerG1rYxFq4weJUAPff8nHUz8XLG?= =?us-ascii?Q?TF3ONDVeqkD326un7mUdH1v6bqpvdobPkQPSL7lzU2MYKCwXExEcIJVIo96K?= =?us-ascii?Q?0dRL8z0tU0ReaHcZn+sq8L6T753/GOZnqU=3D?= X-Microsoft-Antispam-Message-Info: Dkrp7jhjuC9OjFSiT1CgFMDaZnKTIHyU3gmfG6/EgFuBsDxZ7Op06l2pRCzXK+FWfEPhQs8jzMFxVyJNeHSX8koZT/rG5hUw4Wx8IeS41Rb1YzOcB8hQPCS+wMrHzSIIlPbd68BL0PVw54Z+560qTJmVDUIhzKYpzdT24aOz8XQeun8dsPm6e3bqvu2sW9zf X-Microsoft-Exchange-Diagnostics: 1;DB7PR08MB3034;6:Pmkus3/WFQ7s2QQEaKzJBiMAzCRNHN2kBkRojOiK/TTPgATniBiDukg4eaAQG8yINB04Fx1UJyOVlt8hVmdmq7XPLmOOy8Xkh8z4yPFCO6i5Y2dYWdNvDCn8QpfjEwaxHtyoYikPnJMioofpk2gvgN/I0D+icP7d2rgISsHjGzBMzKD38c/H2FZAY3EhUGVdm/s/YByQqbzhxlXCT2q53PmsdFM968nwn8Gk34vPM3Lqyl4iJf3Mb2/fBLgvLclzkESicjxpOBcg8TvpOLDcO5aCniZ+9daAXJgO+YkdhKw15eOJ4062EOZwJxOKzVc8bvsJb7wbKrQpsepLJ5mPD0Xku9JxfOz5EZbe2yG5UelczqTJhz/LpY45o+QTnah0k8HzBV2xfThZKLa6wdYhfLPOcJXgx08jMzsbRyXHTwpYuVY2qMz4Gpm3Ks/n0aiQeEU1FJJmjjynwArXUS0GhA==;5:3xqdCdb7h2/SGurkojTzVIaGhqY37GZ4SwMbwmLeiQEomzN59A922wrquZGbKsbGDRfiZI+OoDUuZp3OepSqkMj44jBtskPNmnbj3qSJzrVeY72SUA6nG2hpyDwOKyxMFQwvX2QZ+H2CuRNHDUaqKr7i3KfIc1mcdufw7GC2aJc=;24:/lBL5r/KvC1CYsIYyGfeYfbGo+jShXjN7eVPR3tbp6LIWR/SCDXCs+WbNJmTVsZPdB4aZp7iKmnMWcbBHdnDUs9hFKUw4/xDU/1EnwufK5E= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;DB7PR08MB3034;7:snMhZ5XQxdBdEGCKxqbPLLb8P1gIaXrW2paJqFedlgSLu4iTJdtDnUu9q111lGsDlWiSKxQQxfQG9KgXWvl8QpdrS0AcYD+0ceqISMhgiSC9QzJfPAQi3f+lGwCJ9k7zafha/qPkFADJbpBmPx/gO9AYf2ZnWVrZ2I/MVIJiuTWjVpdvMyv0X/sSmRKMjovVkB2GhtJVjrJCbj6tyQDS/m0EXP5fOek8LSsJXaDtuEi6rcqbZIL6vWHFbZI+mk+u X-MS-Office365-Filtering-Correlation-Id: 9e49902e-6ea6-4109-58bd-08d5b981ae4f X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 May 2018 10:01:35.9148 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9e49902e-6ea6-4109-58bd-08d5b981ae4f X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR08MB3034 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 25, 2018 at 01:49:35PM +0200, Daniel Vetter wrote: Hi Daniel, > On Wed, Apr 25, 2018 at 1:26 PM, Liviu Dudau wrote: > > On Wed, Apr 25, 2018 at 09:17:22AM +0200, Daniel Vetter wrote: > >> On Tue, Apr 24, 2018 at 07:12:47PM +0100, Ayan Kumar Halder wrote: > >> > malidp_pm_suspend_late checks if the runtime status is not suspended > >> > and if so, invokes malidp_runtime_pm_suspend which disables the > >> > display engine/core interrupts and the clocks. It sets the runtime status > >> > as suspended. > >> > > >> > The difference between suspend() and suspend_late() is as follows:- > >> > 1. suspend() makes the device quiescent. In our case, we invoke the DRM > >> > helper which disables the CRTC. This would have invoked runtime pm > >> > suspend but the system suspend process disables runtime pm. > >> > 2. suspend_late() It continues the suspend operations of the drm device > >> > which was started by suspend(). In our case, it performs the same functionality > >> > as runtime_suspend(). > >> > > >> > The complimentary functions are resume() and resume_early(). In the case of > >> > resume_early(), we invoke malidp_runtime_pm_resume() which enables the clocks > >> > and the interrupts. It sets the runtime status as active. If the device was > >> > in runtime suspend mode before system suspend was called, pm_runtime_work() > >> > will put the device back in runtime suspended mode( after the complete system > >> > has been resumed). > >> > > >> > Signed-off-by: Ayan Kumar Halder > >> > > >> > >> Afaiui we still haven't bottomed out on the discussion on v1. Did you get > >> hold of Rafael? > > > > No, there was no reply from him. Lets try again: > > > > Rafael, we are debating on what the proper approach is for handling the > > suspend/resume callbacks for a DRM driver that is likely to not be > > runtime suspended when the power-down happens (because we are driving > > the display output). We are using in this patch the LATE_SYSTEM_SLEEP_PM_OPS > > in order to do the work that we also do during runtime suspend, which is > > turning off the output and the clocks driving it. The reason for doing > > that is because the PM core takes a runtime reference during system > > suspend for all devices that are not already runtime suspended, so our > > runtime_pm_suspend() hook is never called. > > > > Daniel's argument is that we should not be doing this from LATE hooks, > > but from the normal suspend hooks, however kernel doc seems to suggest > > otherwise. > > For more context: I thought the reason behind the recommendation to > stuff the rpm callbacks into the late/early hooks was to solve > cross-device ordering issues. That way everyone shuts down the device > functionality in the normal hooks, but only powers them off in the > late hook (to allow other drivers to keep using the clock/i2c > master/whatever). But we now have device_link to solve that since a > while, so I'm not sure the recommendation to stuff the rpm hooks into > late/early callbacks is still correct. > -Daniel > It has been more than two weeks and we have not got any response from Rafael. Can you ping him personally or suggest any way by which ask him to respond? > > > > Best regards, > > Liviu > > > > > > > >> -Daniel > >> > >> > --- > >> > Changes in v3:- > >> > - Rebased on top of earlier v3 patches, > >> > > >> > Changes in v2:- > >> > - Removed the change id and modified the commit message > >> > --- > >> > drivers/gpu/drm/arm/malidp_drv.c | 17 +++++++++++++++++ > >> > 1 file changed, 17 insertions(+) > >> > > >> > diff --git a/drivers/gpu/drm/arm/malidp_drv.c b/drivers/gpu/drm/arm/malidp_drv.c > >> > index 82221ea..c53b46a 100644 > >> > --- a/drivers/gpu/drm/arm/malidp_drv.c > >> > +++ b/drivers/gpu/drm/arm/malidp_drv.c > >> > @@ -768,8 +768,25 @@ static int __maybe_unused malidp_pm_resume(struct device *dev) > >> > return 0; > >> > } > >> > > >> > +static int __maybe_unused malidp_pm_suspend_late(struct device *dev) > >> > +{ > >> > + if (!pm_runtime_status_suspended(dev)) { > >> > + malidp_runtime_pm_suspend(dev); > >> > + pm_runtime_set_suspended(dev); > >> > + } > >> > + return 0; > >> > +} > >> > + > >> > +static int __maybe_unused malidp_pm_resume_early(struct device *dev) > >> > +{ > >> > + malidp_runtime_pm_resume(dev); > >> > + pm_runtime_set_active(dev); > >> > + return 0; > >> > +} > >> > + > >> > static const struct dev_pm_ops malidp_pm_ops = { > >> > SET_SYSTEM_SLEEP_PM_OPS(malidp_pm_suspend, malidp_pm_resume) \ > >> > + SET_LATE_SYSTEM_SLEEP_PM_OPS(malidp_pm_suspend_late, malidp_pm_resume_early) \ > >> > SET_RUNTIME_PM_OPS(malidp_runtime_pm_suspend, malidp_runtime_pm_resume, NULL) > >> > }; > >> > > >> > -- > >> > 2.7.4 > >> > > >> > _______________________________________________ > >> > dri-devel mailing list > >> > dri-devel@lists.freedesktop.org > >> > https://lists.freedesktop.org/mailman/listinfo/dri-devel > >> > >> -- > >> Daniel Vetter > >> Software Engineer, Intel Corporation > >> http://blog.ffwll.ch > > > > -- > > ==================== > > | I would like to | > > | fix the world, | > > | but they're not | > > | giving me the | > > \ source code! / > > --------------- > > ??\_(???)_/?? > > _______________________________________________ > > dri-devel mailing list > > dri-devel@lists.freedesktop.org > > https://lists.freedesktop.org/mailman/listinfo/dri-devel > > > > -- > Daniel Vetter > Software Engineer, Intel Corporation > +41 (0) 79 365 57 48 - http://blog.ffwll.ch