From: Christoph Hellwig <hch@infradead.org>
To: Martijn Coenen <maco@android.com>
Cc: "kbuild test robot" <lkp@intel.com>,
"Greg KH" <gregkh@linuxfoundation.org>,
kbuild-all@01.org, "John Stultz" <john.stultz@linaro.org>,
"Todd Kjos" <tkjos@google.com>,
"Arve Hjønnevåg" <arve@android.com>,
"Amit Pundir" <amit.pundir@linaro.org>,
"Arnd Bergmann" <arnd@arndb.de>,
LKML <linux-kernel@vger.kernel.org>,
"open list:ANDROID DRIVERS" <devel@driverdev.osuosl.org>,
"Martijn Coenen" <maco@google.com>,
geert@linux-m68k.org, linux-m68k@lists.linux-m68k.org
Subject: Re: [PATCH] ANDROID: binder: remove 32-bit binder interface.
Date: Mon, 14 May 2018 05:03:38 -0700 [thread overview]
Message-ID: <20180514120338.GA5265@infradead.org> (raw)
In-Reply-To: <CAB0TPYG-Q6Ki_FMM1u+i_g+0ykQgeUTRpm00qycAUVQOqVH6eQ@mail.gmail.com>
On Fri, May 11, 2018 at 09:57:52AM +0200, Martijn Coenen wrote:
> On Sat, May 5, 2018 at 2:10 PM, kbuild test robot <lkp@intel.com> wrote:
> > drivers/android/binder.o: In function `binder_thread_write':
> >>> binder.c:(.text+0x6a16): undefined reference to `__get_user_bad'
>
> Looks like m68k doesn't support 64-bit get_user(). I could just have
> binder depend on !CONFIG_M68K, but there may be other architectures
> still that don't support this. Another alternative would be to
> whitelist the architectures Android supports - eg arm, arm64, x86,
> x86_64. But I'm not sure if arch-limited drivers are considered bad
> form. Does anybody have suggestions for how to deal with this?
The proper fix is to just support 640bit get/put_user on m68k instead
of working around this.
next prev parent reply other threads:[~2018-05-14 12:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-04 19:57 [PATCH] ANDROID: binder: remove 32-bit binder interface Martijn Coenen
2018-05-05 21:10 ` kbuild test robot
2018-05-11 7:57 ` Martijn Coenen
2018-05-11 8:08 ` Greg KH
2018-05-11 8:17 ` Martijn Coenen
2018-05-14 12:03 ` Christoph Hellwig [this message]
2018-05-14 14:00 ` Geert Uytterhoeven
2018-05-14 14:00 ` Geert Uytterhoeven
2018-05-14 21:30 ` Martijn Coenen
2018-05-14 21:30 ` Martijn Coenen
2018-05-14 21:30 ` Martijn Coenen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180514120338.GA5265@infradead.org \
--to=hch@infradead.org \
--cc=amit.pundir@linaro.org \
--cc=arnd@arndb.de \
--cc=arve@android.com \
--cc=devel@driverdev.osuosl.org \
--cc=geert@linux-m68k.org \
--cc=gregkh@linuxfoundation.org \
--cc=john.stultz@linaro.org \
--cc=kbuild-all@01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=lkp@intel.com \
--cc=maco@android.com \
--cc=maco@google.com \
--cc=tkjos@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.