From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: ghes_edac: enable HIP08 platform edac driver From: Borislav Petkov Message-Id: <20180514164720.GH23049@pd.tnic> Date: Mon, 14 May 2018 18:47:20 +0200 To: James Morse Cc: Zhengqiang , mchehab@kernel.org, toshi.kani@hpe.com, linux-edac@vger.kernel.org, linuxarm@huawei.com, "linux-arm-kernel@lists.infradead.org" List-ID: T24gTW9uLCBNYXkgMTQsIDIwMTggYXQgMDQ6MTI6MDhQTSArMDEwMCwgSmFtZXMgTW9yc2Ugd3Jv dGU6Cj4gSSdtIGFmcmFpZCBJJ2QgbGlrZSB0byBrZWVwIGJvdGggZG9vcnMgb3Blbi4gS2VybmVs LWZpcnN0IGhhbmRsaW5nIHdpbGwgcmVxdWlyZQo+IHNvbWUgQUNQSS10YWJsZS9EVCBwcm9wZXJ0 eSBhcyBzb21lIGFzcGVjdHMgb2YgdGhlIENQVSBleHRlbnNpb25zIGFyZW4ndAo+IGRpc2NvdmVy LWFibGUuIENhbid0IHdlIHVzZSB0aGlzIHRvIHBpY2sgdXAgd2hldGhlciB0aGUgcGxhdGZvcm0g c3VwcG9ydHMKPiBmaXJtd2FyZS1maXJzdCAoSEVTVCBhbmQgR0hFUyBlbnRyaWVzKSBvciBrZXJu ZWwtZmlyc3QgdmlhIHNvbWUgYXMteWV0LXVuZGVmaW5lZAo+IEhFU1QgYml0cz8KClNvIGhvdyB5 b3UgZGV0ZWN0IHRob3NlIHBsYXRmb3JtcyBpcyBsYXJnZWx5IHVuZGVmaW5lZCBhcyB3ZSdyZSB3 YWxraW5nCm5ldyBncm91bmRzIGhlcmUgd2l0aCB0aGUgRkYgY3JhcCBvbiB0aGUgb25lIGhhbmQg YW5kIHBsYXRmb3JtLXNwZWNpZmljCmRyaXZlcnMgb24gdGhlIG90aGVyLiBTbyB3aGF0ZXZlciB3 b3JrcyBmb3IgeW91IGFuZCBhcyBsb25nIGFzIHRoZQp1Z2xpbmVzcyBpcyBuaWNlbHkgaGlkZGVu LiA6LSkKCj4gV2l0aG91dCBHSEVTIGVudHJpZXMgdGhpcyBjb2RlIHdvdWxkIG5ldmVyIGJlIHJ1 bi4gU28gd2UgJ2p1c3QnIG5lZWQgdG8gY2F0Y2gKPiBzeXN0ZW1zIHRoYXQgYXJlIGRlc2NyaWJp bmcgYm90aC4gKHdoaWNoIGNhbiBiZSB0aGUgcGxhdGZvcm0gc3BlY2lmaWMga2VybmVsCj4gZmly c3QgYml0cyBwcm9ibGVtIHRvIGRvKQoKU28gdGhlIHJlYXNvbiB3aHkgd2UncmUgZG9pbmcgdGhp cyBvbiB4ODYgaXMgdGhhdCB0aGUgbWFqb3JpdHkgb2YKR0hFUy1hZHZlcnRpemluZyBwbGF0Zm9y bXMgb3V0IHRoZXJlIGFyZSBhIHNlcmlvdXMgdHVyZCB3aGVuIGl0IGNvbWVzCnRvIGZ1bmN0aW9u aW5nIGZ3LgoKU28gd2UndmUgb3B0ZWQgZm9yIGtub3duLWdvb2QgcGxhdGZvcm1zIGxpc3Qgd2hl cmUgdGhlcmUncyBiYWNraW5nIGZyb20KdGhlIHZlbmRvciB0byBoYXZlIGZpcm13YXJlIHdoaWNo IGlzIGdldHRpbmcgZml4ZXMgYW5kIGlzIGJlaW5nIHRlc3RlZApwcm9wZXJseS4KCkFuZCBldmVy eXRoaW5nIGVsc2Ugd2UgYXNzdW1lIGlzIGNyYXAuIFRodXMgd2UgdXNlIHRoZSBwbGF0Zm9ybS1z cGVjaWZpYwpFREFDIGRyaXZlciB3aGljaCB3ZSBrbm93IGl0IHdvcmtzIGFuZCB3ZSBjYW4gZml4 IGlmIHRoZXJlJ3MgYW4gaXNzdWUuClZTIGZpcm13YXJlIHdoaWNoIHdlIGNhbid0LiAoSSBkb3Vi dCBhbnlvbmUgY2FuLCBmb3IgdGhhdCBtYXR0ZXIuIDopLi4uKQoKQW55d2F5LCB0aGlzIGlzIHRo ZSBzdG9yeSBpbiB4ODYgbGFuZC4gSkZZSSBndXlzIGluIGNhc2UgaXQgaGVscHMgbWFraW5nCnNv bWUgZGVjaXNpb25zLgoKVGh4Lgo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: bp@alien8.de (Borislav Petkov) Date: Mon, 14 May 2018 18:47:20 +0200 Subject: [PATCH] ghes_edac: enable HIP08 platform edac driver In-Reply-To: References: <1526039543-180996-1-git-send-email-zhengqiang10@huawei.com> <20180511121901.GA12705@pd.tnic> <5AF90C70.408@huawei.com> <20180514094709.GC23049@pd.tnic> Message-ID: <20180514164720.GH23049@pd.tnic> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Mon, May 14, 2018 at 04:12:08PM +0100, James Morse wrote: > I'm afraid I'd like to keep both doors open. Kernel-first handling will require > some ACPI-table/DT property as some aspects of the CPU extensions aren't > discover-able. Can't we use this to pick up whether the platform supports > firmware-first (HEST and GHES entries) or kernel-first via some as-yet-undefined > HEST bits? So how you detect those platforms is largely undefined as we're walking new grounds here with the FF crap on the one hand and platform-specific drivers on the other. So whatever works for you and as long as the ugliness is nicely hidden. :-) > Without GHES entries this code would never be run. So we 'just' need to catch > systems that are describing both. (which can be the platform specific kernel > first bits problem to do) So the reason why we're doing this on x86 is that the majority of GHES-advertizing platforms out there are a serious turd when it comes to functioning fw. So we've opted for known-good platforms list where there's backing from the vendor to have firmware which is getting fixes and is being tested properly. And everything else we assume is crap. Thus we use the platform-specific EDAC driver which we know it works and we can fix if there's an issue. VS firmware which we can't. (I doubt anyone can, for that matter. :)...) Anyway, this is the story in x86 land. JFYI guys in case it helps making some decisions. Thx. -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.