All of lore.kernel.org
 help / color / mirror / Atom feed
From: kbuild test robot <lkp@intel.com>
To: Connor McAdams <conmanx360@gmail.com>
Cc: kbuild-all@01.org, alsa-devel@alsa-project.org,
	"Takashi Iwai" <tiwai@suse.de>,
	"Takashi Sakamoto" <o-takashi@sakamocchi.jp>,
	"Jaroslav Kysela" <perex@perex.cz>,
	"Jérémy Lefaure" <jeremy.lefaure@lse.epita.fr>,
	linux-kernel@vger.kernel.org
Subject: [PATCH] ALSA: hda/ca0132: fix array_size.cocci warnings
Date: Tue, 15 May 2018 03:02:14 +0800	[thread overview]
Message-ID: <20180514190214.GA38036@athens> (raw)
In-Reply-To: <201805150307.Eek1tvZf%fengguang.wu@intel.com>

From: Fengguang Wu <fengguang.wu@intel.com>

sound/pci/hda/patch_ca0132.c:5062:50-51: WARNING: Use ARRAY_SIZE
sound/pci/hda/patch_ca0132.c:5092:50-51: WARNING: Use ARRAY_SIZE

 Use ARRAY_SIZE instead of dividing sizeof array with sizeof an element

Semantic patch information:
 This makes an effort to find cases where ARRAY_SIZE can be used such as
 where there is a division of sizeof the array by the sizeof its first
 element or by any indexed element or the element type. It replaces the
 division of the two sizeofs by ARRAY_SIZE.

Generated by: scripts/coccinelle/misc/array_size.cocci

Fixes: 47cdf76e44e8 ("ALSA: hda/ca0132: Add new control changes for SBZ + R3Di")
CC: Connor McAdams <conmanx360@gmail.com>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---

 patch_ca0132.c |    6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

--- a/sound/pci/hda/patch_ca0132.c
+++ b/sound/pci/hda/patch_ca0132.c
@@ -5059,8 +5059,7 @@ static int ca0132_alt_svm_setting_put(st
 static int ca0132_alt_eq_preset_info(struct snd_kcontrol *kcontrol,
 				 struct snd_ctl_elem_info *uinfo)
 {
-	unsigned int items = sizeof(ca0132_alt_eq_presets)
-				/ sizeof(struct ct_eq_preset);
+	unsigned int items = ARRAY_SIZE(ca0132_alt_eq_presets);
 
 	uinfo->type = SNDRV_CTL_ELEM_TYPE_ENUMERATED;
 	uinfo->count = 1;
@@ -5089,8 +5088,7 @@ static int ca0132_alt_eq_preset_put(stru
 	struct ca0132_spec *spec = codec->spec;
 	int i, err = 0;
 	int sel = ucontrol->value.enumerated.item[0];
-	unsigned int items = sizeof(ca0132_alt_eq_presets)
-				/ sizeof(struct ct_eq_preset);
+	unsigned int items = ARRAY_SIZE(ca0132_alt_eq_presets);
 
 	if (sel >= items)
 		return 0;

  reply	other threads:[~2018-05-14 19:02 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-14 19:02 [sound:for-next 62/68] sound/pci/hda/patch_ca0132.c:5062:50-51: WARNING: Use ARRAY_SIZE kbuild test robot
2018-05-14 19:02 ` kbuild test robot [this message]
2018-05-14 19:24   ` [PATCH] ALSA: hda/ca0132: fix array_size.cocci warnings Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180514190214.GA38036@athens \
    --to=lkp@intel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=conmanx360@gmail.com \
    --cc=jeremy.lefaure@lse.epita.fr \
    --cc=kbuild-all@01.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=o-takashi@sakamocchi.jp \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.