Re: [PATCH v5 2/2] leds: lm3601x: Introduce the lm3601x LED driver

[Pavel Machek <pavel@ucw.cz>]

[-- Attachment #1: Type: text/plain, Size: 1244 bytes --]

On Mon 2018-05-14 15:13:34, Dan Murphy wrote:
> Pavel
> 
> On 05/14/2018 03:05 PM, Pavel Machek wrote:
> > Hi!
> > 
> >>> OK.
> >>
> >> OK I looked at the max776973 driver and well if the flash-max-microamp and
> >> flash-max-timeout-us nodes are missing it sets a default value for each if the
> >> node is not present.
> >>
> >> So should we remove this code from the Max77693 driver too and fail probe as being asked
> >> in this driver?
> > 
> > Well, modifying driver without access to the hardware is tricky
> > :-(. If it does something stupid (like using other than minimum values
> > for the flash-max-microamp/flash-max-timeout-us), it needs to be
> > fixed.
> 
> Well we should be able to test the probe/parse dt node and reject the probe if the node is not
> present.  That can be done without HW the setup is done pretty early in the probe without even attempting to communicate
> with the hardware.
> 

Well, yes, you can do that.

But if someone is actively using board with DT w/o flash-max-microamp,
you'll make them unhappy.

Best regards,
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]