From: Serge Semin <fancer.lancer@gmail.com>
To: Logan Gunthorpe <logang@deltatee.com>
Cc: Atul Raut <araut@codeaurora.org>, linux-ntb@googlegroups.com
Subject: Re: [PATCH v2 0/4] NTB : Introduce message library
Date: Mon, 14 May 2018 23:40:36 +0300 [thread overview]
Message-ID: <20180514204036.GD24717@mobilestation> (raw)
In-Reply-To: <0f17dee9-9d68-642e-9fe0-6aaf31605cdf@deltatee.com>
On Fri, May 11, 2018 at 05:00:59PM -0600, Logan Gunthorpe <logang@deltatee.com> wrote:
> On 5/11/2018 4:39 PM, Serge Semin wrote:
> >Definitely I didn't tell you just to copy-and-paste the whole service functions
> >from ntb_perf. One of the ntb_perf driver purpose was to create an example of
> >possible cross-interface communication code, which turned to be the "service"
> >subsystem of the driver. My idea was to have it used as a proof of concept and
> >a stably working code for the future cross-iface library. The library is going
> >to be a part of the NTB API itself - a part of the generic interface for the
> >whole NTB subsystem, so I recommended to have the design discussed first, otherwise
> >you'd risk to face review requests which would cause a serious code refactoring.
> >As far as I can see, it turned out to be true.
>
> IMO, and in my experience, when working on APIs that have multiple users in
> the kernel you should *expect* to refactor and rewrite the code a couple
> times before we land on something that is clean enough to merge. I have
> patch sets that have gone through many *significant* changes and they are
> still works in progress. This is normal and don't expect discussion ahead of
> time to converge on the right answer right away.
I've got the same experience. But one thing I also got from it. If I knew a
maintainers notion about a change, I would have developed a code in accordance
with it. At least I'd try to understand the maintainer ideas and after discussions
we'd come up to some agreement. So if I had a way to chat with subsystem support
team, I would have used it without a doubt. Of course this doesn't mean that a
patchset would be accepted right after a first submit, but you must admit it would
lead to a code closer to acceptance than if it was created without the consultation.
-Sergey
> >Even though this more like a "philosophic" part, but this time Logan's opinion
> >happens to agree with the design we discussed a while ago with the rest of the
> >NTB maintainers:
>
> Glad we agree for a change ;)
>
> Logan
>
next prev parent reply other threads:[~2018-05-14 20:40 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-06 19:20 [PATCH v2 0/4] NTB : Introduce message library Atul Raut
2018-05-06 19:20 ` [PATCH v2 1/4] " Atul Raut
2018-05-07 5:29 ` Logan Gunthorpe
2018-05-10 2:10 ` Atul Raut
2018-05-10 4:35 ` Logan Gunthorpe
2018-05-10 18:13 ` Atul Raut
2018-05-11 22:40 ` Serge Semin
2018-05-06 19:20 ` [PATCH v2 2/4] NTB : Add message library NTB API Atul Raut
2018-05-11 22:44 ` Serge Semin
2018-05-11 23:11 ` Logan Gunthorpe
2018-05-14 20:25 ` Serge Semin
2018-05-14 20:59 ` Logan Gunthorpe
2018-05-14 21:39 ` Serge Semin
2018-05-14 22:04 ` Logan Gunthorpe
2018-05-13 0:25 ` Allen Hubbe
2018-05-13 0:31 ` Allen Hubbe
2018-05-14 23:16 ` Serge Semin
2018-05-15 14:21 ` Allen Hubbe
2018-05-31 22:27 ` Serge Semin
2018-05-06 19:20 ` [PATCH v2 3/4] NTB : Modification to ntb_perf module Atul Raut
2018-05-06 19:20 ` [PATCH v2 4/4] NTB : Add support to message registers based devices Atul Raut
2018-05-11 22:39 ` [PATCH v2 0/4] NTB : Introduce message library Serge Semin
2018-05-11 23:00 ` Logan Gunthorpe
2018-05-14 20:40 ` Serge Semin [this message]
2018-05-14 21:04 ` Logan Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180514204036.GD24717@mobilestation \
--to=fancer.lancer@gmail.com \
--cc=araut@codeaurora.org \
--cc=linux-ntb@googlegroups.com \
--cc=logang@deltatee.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.