From: Stephen Hemminger <stephen@networkplumber.org>
To: Luca Boccassi <bluca@debian.org>
Cc: netdev@vger.kernel.org, dsahern@gmail.com, luto@amacapital.net
Subject: Re: [PATCH iproute2] ip: do not drop capabilities if net_admin=i is set
Date: Mon, 14 May 2018 21:10:05 -0700 [thread overview]
Message-ID: <20180514211005.4f7cb98a@xeon-e3> (raw)
In-Reply-To: <20180511123956.5638-1-bluca@debian.org>
On Fri, 11 May 2018 13:39:56 +0100
Luca Boccassi <bluca@debian.org> wrote:
> Users have reported a regression due to ip now dropping capabilities
> unconditionally.
> zerotier-one VPN and VirtualBox use ambient capabilities in their
> binary and then fork out to ip to set routes and links, and this
> does not work anymore.
>
> As a workaround, do not drop caps if CAP_NET_ADMIN (the most common
> capability used by ip) is set with the INHERITABLE flag.
> Users that want ip vrf exec to work do not need to set INHERITABLE,
> which will then only set when the calling program had privileges to
> give itself the ambient capability.
>
> Fixes: ba2fc55b99f8 ("Drop capabilities if not running ip exec vrf with libcap")
>
> Signed-off-by: Luca Boccassi <bluca@debian.org>
Applied
prev parent reply other threads:[~2018-05-15 4:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-11 12:39 [PATCH iproute2] ip: do not drop capabilities if net_admin=i is set Luca Boccassi
2018-05-15 4:10 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180514211005.4f7cb98a@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=bluca@debian.org \
--cc=dsahern@gmail.com \
--cc=luto@amacapital.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.