From mboxrd@z Thu Jan 1 00:00:00 1970 From: Masami Hiramatsu Subject: Re: [PATCH 01/18] kernel: Use pr_fmt Date: Mon, 14 May 2018 22:38:33 +0900 Message-ID: <20180514223833.f3c2224e458e89949d3042d4@kernel.org> References: <28df5659605d7b2ace94deca3b831b462183303f.1525964381.git.joe@perches.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <28df5659605d7b2ace94deca3b831b462183303f.1525964381.git.joe@perches.com> Sender: linux-kernel-owner@vger.kernel.org To: Joe Perches Cc: Paul Moore , Eric Paris , Ananth N Mavinakayanahalli , Anil S Keshavamurthy , "David S. Miller" , Jessica Yu , Kees Cook , Andy Lutomirski , Will Drewry , Balbir Singh , Davidlohr Bueso , "Paul E. McKenney" , Josh Triplett , Tejun Heo , Lai Jiangshan , linux-kernel@vger.kernel.org, linux-audit@redhat.com List-Id: linux-audit@redhat.com On Thu, 10 May 2018 08:45:27 -0700 Joe Perches wrote: > Sometime in the future, it would be useful to convert pr_fmt from a > default simple define to use a default prefix with KBUILD_MODNAME. > > There are files in kernel/ that use pr_, some with an embedded > prefix, that also do not have a specific pr_fmt define. > > Add pr_fmt for those files. > > There are some differences in output as some messages are now prefixed > with their KBUILD_MODNAME. > > Miscellanea: > > o Align multiline statements to open parenthesis > o Wrap and realign arguments to 80 columns where sensible > o Coalesce formats > > Signed-off-by: Joe Perches Kprobes part looks good to me. Acked-by: Masami Hiramatsu Thanks! -- Masami Hiramatsu