From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [3/3] x86/MCE/AMD: Get address from already initialized block From: Johannes Hirte Message-Id: <20180515093953.GA1746@probook> Date: Tue, 15 May 2018 11:39:54 +0200 To: "Ghannam, Yazen" Cc: "linux-edac@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "bp@suse.de" , "tony.luck@intel.com" , "x86@kernel.org" List-ID: T24gMjAxOCBBcHIgMTcsIEdoYW5uYW0sIFlhemVuIHdyb3RlOgo+ID4gLS0tLS1PcmlnaW5hbCBN ZXNzYWdlLS0tLS0KPiA+IEZyb206IGxpbnV4LWVkYWMtb3duZXJAdmdlci5rZXJuZWwub3JnIDxs aW51eC1lZGFjLQo+ID4gb3duZXJAdmdlci5rZXJuZWwub3JnPiBPbiBCZWhhbGYgT2YgSm9oYW5u ZXMgSGlydGUKPiA+IFNlbnQ6IE1vbmRheSwgQXByaWwgMTYsIDIwMTggNzo1NiBBTQo+ID4gVG86 IEdoYW5uYW0sIFlhemVuIDxZYXplbi5HaGFubmFtQGFtZC5jb20+Cj4gPiBDYzogbGludXgtZWRh Y0B2Z2VyLmtlcm5lbC5vcmc7IGxpbnV4LWtlcm5lbEB2Z2VyLmtlcm5lbC5vcmc7IGJwQHN1c2Uu ZGU7Cj4gPiB0b255Lmx1Y2tAaW50ZWwuY29tOyB4ODZAa2VybmVsLm9yZwo+ID4gU3ViamVjdDog UmU6IFtQQVRDSCAzLzNdIHg4Ni9NQ0UvQU1EOiBHZXQgYWRkcmVzcyBmcm9tIGFscmVhZHkgaW5p dGlhbGl6ZWQKPiA+IGJsb2NrCj4gPiAKPiA+IE9uIDIwMTggQXByIDE0LCBKb2hhbm5lcyBIaXJ0 ZSB3cm90ZToKPiA+ID4gT24gMjAxOCBGZWIgMDEsIFlhemVuIEdoYW5uYW0gd3JvdGU6Cj4gPiA+ ID4gRnJvbTogWWF6ZW4gR2hhbm5hbSA8eWF6ZW4uZ2hhbm5hbUBhbWQuY29tPgo+ID4gPiA+Cj4g PiA+ID4gVGhlIGJsb2NrIGFkZHJlc3MgaXMgc2F2ZWQgYWZ0ZXIgdGhlIGJsb2NrIGlzIGluaXRp YWxpemVkIHdoZW4KPiA+ID4gPiB0aHJlc2hvbGRfaW5pdF9kZXZpY2UoKSBpcyBjYWxsZWQuCj4g PiA+ID4KPiA+ID4gPiBVc2UgdGhlIHNhdmVkIGJsb2NrIGFkZHJlc3MsIGlmIGF2YWlsYWJsZSwg cmF0aGVyIHRoYW4gdHJ5aW5nIHRvCj4gPiA+ID4gcmVkaXNjb3ZlciBpdC4KPiA+ID4gPgo+ID4g PiA+IFdlIGNhbiBhdm9pZCBzb21lICpvbl9jcHUoKSBjYWxscyBpbiB0aGUgaW5pdCBwYXRoIHRo YXQgd2lsbCBjYXVzZSBhCj4gPiA+ID4gY2FsbCB0cmFjZSB3aGVuIHJlc3VtaW5nIGZyb20gc3Vz cGVuZC4KPiA+ID4gPgo+ID4gPiA+IENjOiA8c3RhYmxlQHZnZXIua2VybmVsLm9yZz4gIyA0LjE0 LngKPiA+ID4gPiBTaWduZWQtb2ZmLWJ5OiBZYXplbiBHaGFubmFtIDx5YXplbi5naGFubmFtQGFt ZC5jb20+Cj4gPiA+ID4gLS0tCj4gPiA+ID4gIGFyY2gveDg2L2tlcm5lbC9jcHUvbWNoZWNrL21j ZV9hbWQuYyB8IDE1ICsrKysrKysrKysrKysrKwo+ID4gPiA+ICAxIGZpbGUgY2hhbmdlZCwgMTUg aW5zZXJ0aW9ucygrKQo+ID4gPiA+Cj4gPiA+ID4gZGlmZiAtLWdpdCBhL2FyY2gveDg2L2tlcm5l bC9jcHUvbWNoZWNrL21jZV9hbWQuYwo+ID4gYi9hcmNoL3g4Ni9rZXJuZWwvY3B1L21jaGVjay9t Y2VfYW1kLmMKPiA+ID4gPiBpbmRleCBiZjUzYjQ1NDlhMTcuLjhjNGY4ZjMwYzc3OSAxMDA2NDQK PiA+ID4gPiAtLS0gYS9hcmNoL3g4Ni9rZXJuZWwvY3B1L21jaGVjay9tY2VfYW1kLmMKPiA+ID4g PiArKysgYi9hcmNoL3g4Ni9rZXJuZWwvY3B1L21jaGVjay9tY2VfYW1kLmMKPiA+ID4gPiBAQCAt NDM2LDYgKzQzNiwyMSBAQCBzdGF0aWMgdTMyIGdldF9ibG9ja19hZGRyZXNzKHVuc2lnbmVkIGlu dCBjcHUsCj4gPiB1MzIgY3VycmVudF9hZGRyLCB1MzIgbG93LCB1MzIgaGkKPiA+ID4gPiAgewo+ ID4gPiA+ICAJdTMyIGFkZHIgPSAwLCBvZmZzZXQgPSAwOwo+ID4gPiA+Cj4gPiA+ID4gKwlpZiAo KGJhbmsgPj0gbWNhX2NmZy5iYW5rcykgfHwgKGJsb2NrID49IE5SX0JMT0NLUykpCj4gPiA+ID4g KwkJcmV0dXJuIGFkZHI7Cj4gPiA+ID4gKwo+ID4gPiA+ICsJLyogR2V0IGFkZHJlc3MgZnJvbSBh bHJlYWR5IGluaXRpYWxpemVkIGJsb2NrLiAqLwo+ID4gPiA+ICsJaWYgKHBlcl9jcHUodGhyZXNo b2xkX2JhbmtzLCBjcHUpKSB7Cj4gPiA+ID4gKwkJc3RydWN0IHRocmVzaG9sZF9iYW5rICpiYW5r cCA9IHBlcl9jcHUodGhyZXNob2xkX2JhbmtzLAo+ID4gY3B1KVtiYW5rXTsKPiA+ID4gPiArCj4g PiA+ID4gKwkJaWYgKGJhbmtwICYmIGJhbmtwLT5ibG9ja3MpIHsKPiA+ID4gPiArCQkJc3RydWN0 IHRocmVzaG9sZF9ibG9jayAqYmxvY2twID0gJmJhbmtwLQo+ID4gPmJsb2Nrc1tibG9ja107Cj4g PiA+ID4gKwo+ID4gPiA+ICsJCQlpZiAoYmxvY2twKQo+ID4gPiA+ICsJCQkJcmV0dXJuIGJsb2Nr cC0+YWRkcmVzczsKPiA+ID4gPiArCQl9Cj4gPiA+ID4gKwl9Cj4gPiA+ID4gKwo+ID4gPiA+ICAJ aWYgKG1jZV9mbGFncy5zbWNhKSB7Cj4gPiA+ID4gIAkJaWYgKHNtY2FfZ2V0X2JhbmtfdHlwZShi YW5rKSA9PSBTTUNBX1JFU0VSVkVEKQo+ID4gPiA+ICAJCQlyZXR1cm4gYWRkcjsKPiA+ID4gPiAt LQo+ID4gPiA+IDIuMTQuMQo+ID4gPgo+ID4gPiBJIGhhdmUgYSBLQVNBTjogc2xhYi1vdXQtb2Yt Ym91bmRzLCBhbmQgZ2l0IGJpc2VjdCBwb2ludHMgbWUgdG8gdGhpcwo+ID4gPiBjaGFuZ2U6Cj4g PiA+Cj4gPiA+IEFwciAxMyAwMDo0MDozMiBwcm9ib29rIGtlcm5lbDoKPiA+ID09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KPiA+ ID09Cj4gPiA+IEFwciAxMyAwMDo0MDozMiBwcm9ib29rIGtlcm5lbDogQlVHOiBLQVNBTjogc2xh Yi1vdXQtb2YtYm91bmRzIGluCj4gPiBnZXRfYmxvY2tfYWRkcmVzcy5pc3JhLjMrMHgxZTkvMHg1 MjAKPiA+ID4gQXByIDEzIDAwOjQwOjMyIHByb2Jvb2sga2VybmVsOiBSZWFkIG9mIHNpemUgNCBh dCBhZGRyIGZmZmY4ODAzZjE2NWRkZjQgYnkKPiA+IHRhc2sgc3dhcHBlci8wLzEKPiA+ID4gQXBy IDEzIDAwOjQwOjMyIHByb2Jvb2sga2VybmVsOgo+ID4gPiBBcHIgMTMgMDA6NDA6MzIgcHJvYm9v ayBrZXJuZWw6IENQVTogMSBQSUQ6IDEgQ29tbTogc3dhcHBlci8wIE5vdAo+ID4gdGFpbnRlZCA0 LjE2LjAtMTA3NTctZzRjYThiYTRjY2ZmOSAjNTMyCj4gPiA+IEFwciAxMyAwMDo0MDozMiBwcm9i b29rIGtlcm5lbDogSGFyZHdhcmUgbmFtZTogSFAgSFAgUHJvQm9vayA2NDUKPiA+IEcyLzgwRkUs IEJJT1MgTjc3IFZlci4gMDEuMTIgMTIvMTkvMjAxNwo+ID4gPiBBcHIgMTMgMDA6NDA6MzIgcHJv Ym9vayBrZXJuZWw6IENhbGwgVHJhY2U6Cj4gPiA+IEFwciAxMyAwMDo0MDozMiBwcm9ib29rIGtl cm5lbDogIGR1bXBfc3RhY2srMHg1Yi8weDhiCj4gPiA+IEFwciAxMyAwMDo0MDozMiBwcm9ib29r IGtlcm5lbDogID8gZ2V0X2Jsb2NrX2FkZHJlc3MuaXNyYS4zKzB4MWU5LzB4NTIwCj4gPiA+IEFw ciAxMyAwMDo0MDozMiBwcm9ib29rIGtlcm5lbDogIHByaW50X2FkZHJlc3NfZGVzY3JpcHRpb24r MHg2NS8weDI3MAo+ID4gPiBBcHIgMTMgMDA6NDA6MzIgcHJvYm9vayBrZXJuZWw6ICA/IGdldF9i bG9ja19hZGRyZXNzLmlzcmEuMysweDFlOS8weDUyMAo+ID4gPiBBcHIgMTMgMDA6NDA6MzIgcHJv Ym9vayBrZXJuZWw6ICBrYXNhbl9yZXBvcnQrMHgyMzIvMHgzNTAKPiA+ID4gQXByIDEzIDAwOjQw OjMyIHByb2Jvb2sga2VybmVsOiAgZ2V0X2Jsb2NrX2FkZHJlc3MuaXNyYS4zKzB4MWU5LzB4NTIw Cj4gPiA+IEFwciAxMyAwMDo0MDozMiBwcm9ib29rIGtlcm5lbDogID8ga29iamVjdF9pbml0X2Fu ZF9hZGQrMHhkZS8weDEzMAo+ID4gPiBBcHIgMTMgMDA6NDA6MzIgcHJvYm9vayBrZXJuZWw6ICA/ IGdldF9uYW1lKzB4MzkwLzB4MzkwCj4gPiA+IEFwciAxMyAwMDo0MDozMiBwcm9ib29rIGtlcm5l bDogID8ga2FzYW5fdW5wb2lzb25fc2hhZG93KzB4MzAvMHg0MAo+ID4gPiBBcHIgMTMgMDA6NDA6 MzIgcHJvYm9vayBrZXJuZWw6ICA/IGthc2FuX2ttYWxsb2MrMHhhMC8weGQwCj4gPiA+IEFwciAx MyAwMDo0MDozMiBwcm9ib29rIGtlcm5lbDogIGFsbG9jYXRlX3RocmVzaG9sZF9ibG9ja3MrMHgx MmMvMHhjNjAKPiA+ID4gQXByIDEzIDAwOjQwOjMyIHByb2Jvb2sga2VybmVsOiAgPyBrb2JqZWN0 X2FkZF9pbnRlcm5hbCsweDgwMC8weDgwMAo+ID4gPiBBcHIgMTMgMDA6NDA6MzIgcHJvYm9vayBr ZXJuZWw6ICA/IGdldF9ibG9ja19hZGRyZXNzLmlzcmEuMysweDUyMC8weDUyMAo+ID4gPiBBcHIg MTMgMDA6NDA6MzIgcHJvYm9vayBrZXJuZWw6ICA/IGthc2FuX2ttYWxsb2MrMHhhMC8weGQwCj4g PiA+IEFwciAxMyAwMDo0MDozMiBwcm9ib29rIGtlcm5lbDoKPiA+IG1jZV90aHJlc2hvbGRfY3Jl YXRlX2RldmljZSsweDM1Yi8weDk5MAo+ID4gPiBBcHIgMTMgMDA6NDA6MzIgcHJvYm9vayBrZXJu ZWw6ICA/IGluaXRfc3BlY2lhbF9pbm9kZSsweDFkMC8weDIzMAo+ID4gPiBBcHIgMTMgMDA6NDA6 MzIgcHJvYm9vayBrZXJuZWw6ICB0aHJlc2hvbGRfaW5pdF9kZXZpY2UrMHg5OC8weGE3Cj4gPiA+ IEFwciAxMyAwMDo0MDozMiBwcm9ib29rIGtlcm5lbDogID8KPiA+IG1jaGVja192ZW5kb3JfaW5p dF9zZXZlcml0eSsweDQzLzB4NDMKPiA+ID4gQXByIDEzIDAwOjQwOjMyIHByb2Jvb2sga2VybmVs OiAgZG9fb25lX2luaXRjYWxsKzB4NzYvMHgzMGMKPiA+ID4gQXByIDEzIDAwOjQwOjMyIHByb2Jv b2sga2VybmVsOiAgPwo+ID4gdHJhY2VfZXZlbnRfcmF3X2V2ZW50X2luaXRjYWxsX2ZpbmlzaCsw eDE5MC8weDE5MAo+ID4gPiBBcHIgMTMgMDA6NDA6MzIgcHJvYm9vayBrZXJuZWw6ICA/IGthc2Fu X3VucG9pc29uX3NoYWRvdysweGIvMHg0MAo+ID4gPiBBcHIgMTMgMDA6NDA6MzIgcHJvYm9vayBr ZXJuZWw6ICA/IGthc2FuX3VucG9pc29uX3NoYWRvdysweDMwLzB4NDAKPiA+ID4gQXByIDEzIDAw OjQwOjMyIHByb2Jvb2sga2VybmVsOiAga2VybmVsX2luaXRfZnJlZWFibGUrMHgzZDYvMHg0NzEK PiA+ID4gQXByIDEzIDAwOjQwOjMyIHByb2Jvb2sga2VybmVsOiAgPyByZXN0X2luaXQrMHhmMC8w eGYwCj4gPiA+IEFwciAxMyAwMDo0MDozMiBwcm9ib29rIGtlcm5lbDogIGtlcm5lbF9pbml0KzB4 YS8weDEyMAo+ID4gPiBBcHIgMTMgMDA6NDA6MzIgcHJvYm9vayBrZXJuZWw6ICA/IHJlc3RfaW5p dCsweGYwLzB4ZjAKPiA+ID4gQXByIDEzIDAwOjQwOjMyIHByb2Jvb2sga2VybmVsOiAgcmV0X2Zy b21fZm9yaysweDIyLzB4NDAKPiA+ID4gQXByIDEzIDAwOjQwOjMyIHByb2Jvb2sga2VybmVsOgo+ ID4gPiBBcHIgMTMgMDA6NDA6MzIgcHJvYm9vayBrZXJuZWw6IEFsbG9jYXRlZCBieSB0YXNrIDE6 Cj4gPiA+IEFwciAxMyAwMDo0MDozMiBwcm9ib29rIGtlcm5lbDogIGthc2FuX2ttYWxsb2MrMHhh MC8weGQwCj4gPiA+IEFwciAxMyAwMDo0MDozMiBwcm9ib29rIGtlcm5lbDogIGttZW1fY2FjaGVf YWxsb2NfdHJhY2UrMHhmMy8weDFmMAo+ID4gPiBBcHIgMTMgMDA6NDA6MzIgcHJvYm9vayBrZXJu ZWw6ICBhbGxvY2F0ZV90aHJlc2hvbGRfYmxvY2tzKzB4MWJjLzB4YzYwCj4gPiA+IEFwciAxMyAw MDo0MDozMiBwcm9ib29rIGtlcm5lbDoKPiA+IG1jZV90aHJlc2hvbGRfY3JlYXRlX2RldmljZSsw eDM1Yi8weDk5MAo+ID4gPiBBcHIgMTMgMDA6NDA6MzIgcHJvYm9vayBrZXJuZWw6ICB0aHJlc2hv bGRfaW5pdF9kZXZpY2UrMHg5OC8weGE3Cj4gPiA+IEFwciAxMyAwMDo0MDozMiBwcm9ib29rIGtl cm5lbDogIGRvX29uZV9pbml0Y2FsbCsweDc2LzB4MzBjCj4gPiA+IEFwciAxMyAwMDo0MDozMiBw cm9ib29rIGtlcm5lbDogIGtlcm5lbF9pbml0X2ZyZWVhYmxlKzB4M2Q2LzB4NDcxCj4gPiA+IEFw ciAxMyAwMDo0MDozMiBwcm9ib29rIGtlcm5lbDogIGtlcm5lbF9pbml0KzB4YS8weDEyMAo+ID4g PiBBcHIgMTMgMDA6NDA6MzIgcHJvYm9vayBrZXJuZWw6ICByZXRfZnJvbV9mb3JrKzB4MjIvMHg0 MAo+ID4gPiBBcHIgMTMgMDA6NDA6MzIgcHJvYm9vayBrZXJuZWw6Cj4gPiA+IEFwciAxMyAwMDo0 MDozMiBwcm9ib29rIGtlcm5lbDogRnJlZWQgYnkgdGFzayAwOgo+ID4gPiBBcHIgMTMgMDA6NDA6 MzIgcHJvYm9vayBrZXJuZWw6IChzdGFjayBpcyBub3QgYXZhaWxhYmxlKQo+ID4gPiBBcHIgMTMg MDA6NDA6MzIgcHJvYm9vayBrZXJuZWw6Cj4gPiA+IEFwciAxMyAwMDo0MDozMiBwcm9ib29rIGtl cm5lbDogVGhlIGJ1Z2d5IGFkZHJlc3MgYmVsb25ncyB0byB0aGUgb2JqZWN0IGF0Cj4gPiBmZmZm ODgwM2YxNjVkZDgwCj4gPiA+ICB3aGljaCBiZWxvbmdzIHRvIHRoZSBjYWNoZSBrbWFsbG9jLTEy OCBvZiBzaXplIDEyOAo+ID4gPiBBcHIgMTMgMDA6NDA6MzIgcHJvYm9vayBrZXJuZWw6IFRoZSBi dWdneSBhZGRyZXNzIGlzIGxvY2F0ZWQgMTE2IGJ5dGVzCj4gPiBpbnNpZGUgb2YKPiA+ID4gIDEy OC1ieXRlIHJlZ2lvbiBbZmZmZjg4MDNmMTY1ZGQ4MCwgZmZmZjg4MDNmMTY1ZGUwMCkKPiA+ID4g IEFwciAxMyAwMDo0MDozMiBwcm9ib29rIGtlcm5lbDogVGhlIGJ1Z2d5IGFkZHJlc3MgYmVsb25n cyB0byB0aGUgcGFnZToKPiA+ID4gQXByIDEzIDAwOjQwOjMyIHByb2Jvb2sga2VybmVsOiBwYWdl OmZmZmZlYTAwMGZjNTk3NDAgY291bnQ6MQo+ID4gbWFwY291bnQ6MCBtYXBwaW5nOjAwMDAwMDAw MDAwMDAwMDAgaW5kZXg6MHgwCj4gPiA+IEFwciAxMyAwMDo0MDozMiBwcm9ib29rIGtlcm5lbDog ZmxhZ3M6IDB4MjAwMDAwMDAwMDAwMDEwMChzbGFiKQo+ID4gPiBBcHIgMTMgMDA6NDA6MzIgcHJv Ym9vayBrZXJuZWw6IHJhdzogMjAwMDAwMDAwMDAwMDEwMAo+ID4gMDAwMDAwMDAwMDAwMDAwMCAw MDAwMDAwMDAwMDAwMDAwIDAwMDAwMDAxODAxNTAwMTUKPiA+ID4gQXByIDEzIDAwOjQwOjMyIHBy b2Jvb2sga2VybmVsOiByYXc6IGRlYWQwMDAwMDAwMDAxMDAKPiA+IGRlYWQwMDAwMDAwMDAyMDAg ZmZmZjg4MDNmMzQwMzM0MCAwMDAwMDAwMDAwMDAwMDAwCj4gPiA+IEFwciAxMyAwMDo0MDozMiBw cm9ib29rIGtlcm5lbDogcGFnZSBkdW1wZWQgYmVjYXVzZToga2FzYW46IGJhZCBhY2Nlc3MKPiA+ IGRldGVjdGVkCj4gPiA+IEFwciAxMyAwMDo0MDozMiBwcm9ib29rIGtlcm5lbDoKPiA+ID4gQXBy IDEzIDAwOjQwOjMyIHByb2Jvb2sga2VybmVsOiBNZW1vcnkgc3RhdGUgYXJvdW5kIHRoZSBidWdn eSBhZGRyZXNzOgo+ID4gPiBBcHIgMTMgMDA6NDA6MzIgcHJvYm9vayBrZXJuZWw6ICBmZmZmODgw M2YxNjVkYzgwOiBmYyBmYyBmYyBmYyBmYyBmYyBmYyBmYyAwMCAwMAo+ID4gMDAgMDAgMDAgMDAg MDAgMDAKPiA+ID4gQXByIDEzIDAwOjQwOjMyIHByb2Jvb2sga2VybmVsOiAgZmZmZjg4MDNmMTY1 ZGQwMDogMDAgMDAgMDAgMDAgMDAgMDAgMDAgZmMKPiA+IGZjIGZjIGZjIGZjIGZjIGZjIGZjIGZj Cj4gPiA+IEFwciAxMyAwMDo0MDozMiBwcm9ib29rIGtlcm5lbDogPmZmZmY4ODAzZjE2NWRkODA6 IDAwIDAwIDAwIDAwIDAwIDAwIDAwCj4gPiAwMCAwMCAwMCAwMCAwMCAwMCBmYyBmYyBmYwo+ID4g PiBBcHIgMTMgMDA6NDA6MzIgcHJvYm9vayBrZXJuZWw6ICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBeCj4gPiA+IEFwciAxMyAwMDo0 MDozMiBwcm9ib29rIGtlcm5lbDogIGZmZmY4ODAzZjE2NWRlMDA6IGZjIGZjIGZjIGZjIGZjIGZj IGZjIGZjIGZjIGZjCj4gPiBmYyBmYyBmYyBmYyBmYyBmYwo+ID4gPiBBcHIgMTMgMDA6NDA6MzIg cHJvYm9vayBrZXJuZWw6ICBmZmZmODgwM2YxNjVkZTgwOiBmYyBmYyBmYyBmYyBmYyBmYyBmYyBm YyBmYyBmYwo+ID4gZmMgZmMgZmMgZmMgZmMgZmMKPiA+ID4gQXByIDEzIDAwOjQwOjMyIHByb2Jv b2sga2VybmVsOgo+ID4gPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQo+ID4gPT0KPiA+ID4KPiA+IAo+ID4gUHV0dGluZyB0aGUg d2hvbGUgY2hhY2hpbmcgcGFydCB1bmRlciB0aGUKPiA+IAo+ID4gaWYgKG1jZV9mbGFncy5zbWNh KSB7Cj4gPiAKPiA+IHNvbHZlZCB0aGUgaXNzdWUgb24gbXkgQ2Fycml6by4KPiA+IAo+IAo+IFRo YW5rcyBmb3IgcmVwb3J0aW5nIHRoaXMuIEknbSBhYmxlIHRvIHJlcHJvZHVjZSB0aGlzIG9uIG15 IEZhbTE3aCBzeXN0ZW0uIFRoZQo+IGNhY2hpbmcgc2hvdWxkIHN0aWxsIGJlIHRoZSBzYW1lIG9u IG5vbi1TTUNBIHN5c3RlbXMuIFB1dHRpbmcgaXQgYWxsIHVuZGVyIHRoZQo+IFNNQ0EgZmxhZ3Mg ZWZmZWN0aXZlbHkgcmVtb3ZlcyBpdCBvbiBDYXJyaXpvLgo+IAo+IEhlcmUgYXJlIHdoZW4gZ2V0 X2Jsb2NrX2FkZHJlc3MoKSBpcyBjYWxsZWQ6Cj4gMSkgQm9vdCB0aW1lIE1DRSBpbml0LiBDYWxs ZWQgb24gZWFjaCBDUFUuIE5vIGNhY2hpbmcuCj4gMikgSW5pdCBvZiB0aGUgTUNFIGRldmljZS4g Q2FsbGVkIG9uIGEgc2luZ2xlIENQVS4gVmFsdWVzIGFyZSBjYWNoZWQgaGVyZS4KPiAzKSBDUFUg b24vb2ZmbGluZyB3aGljaCBjYWxscyBNQ0UgaW5pdC4gU2hvdWxkIHVzZSB0aGUgY2FjaGVkIHZh bHVlcy4KPiAKPiBJdCBzZWVtcyB0byBtZSB0aGF0IHRoZSBLQVNBTiBidWcgaXMgZGV0ZWN0ZWQg ZHVyaW5nICMyIHRob3VnaCBpdCdzIG5vdCB5ZXQgY2xlYXIKPiB0byBtZSB3aGF0IHRoZSBpc3N1 ZSBpcy4gSSBuZWVkIHRvIHJlYWQgdXAgb24gS0FTQU4gYW5kIGtlZXAgZGVidWdnaW5nLgoKVGhl IG91dC1vZi1ib3VuZCBhY2Nlc3MgaGFwcGVucyBpbiBnZXRfYmxvY2tfYWRkcmVzczoKCglpZiAo YmFua3AgJiYgYmFua3AtPmJsb2NrcykgewoJCXN0cnVjdCB0aHJlc2hvbGRfYmxvY2sgKmJsb2Nr cCBibG9ja3AgPSAmYmFua3AtPmJsb2Nrc1tibG9ja107Cgp3aXRoIGJsb2NrPTEuIFRoaXMgZG9l c24ndCBleGlzdHMuIEkgZG9uJ3QgZXZlbiBmaW5kIGFueSBhcnJheSBoZXJlLgpUaGVyZSBpcyBh IGxpbmtlZCBsaXN0LCBjcmVhdGVkIGluIGFsbG9jYXRlX3RocmVzaG9sZF9ibG9ja3MuIE9uIG15 CnN5c3RlbSBJIGdldCAxNyBsaXN0cyB3aXRoIG9uZSBlbGVtZW50IGVhY2guCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752620AbeEOJkU (ORCPT ); Tue, 15 May 2018 05:40:20 -0400 Received: from freki.datenkhaos.de ([81.7.17.101]:46022 "EHLO freki.datenkhaos.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752343AbeEOJkS (ORCPT ); Tue, 15 May 2018 05:40:18 -0400 Date: Tue, 15 May 2018 11:39:54 +0200 From: Johannes Hirte To: "Ghannam, Yazen" Cc: "linux-edac@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "bp@suse.de" , "tony.luck@intel.com" , "x86@kernel.org" Subject: Re: [PATCH 3/3] x86/MCE/AMD: Get address from already initialized block Message-ID: <20180515093953.GA1746@probook> References: <20180201184813.82253-1-Yazen.Ghannam@amd.com> <20180201184813.82253-3-Yazen.Ghannam@amd.com> <20180414004230.GA2033@probook> <20180416115624.GA1543@probook> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.5 (2018-04-13) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2018 Apr 17, Ghannam, Yazen wrote: > > -----Original Message----- > > From: linux-edac-owner@vger.kernel.org > owner@vger.kernel.org> On Behalf Of Johannes Hirte > > Sent: Monday, April 16, 2018 7:56 AM > > To: Ghannam, Yazen > > Cc: linux-edac@vger.kernel.org; linux-kernel@vger.kernel.org; bp@suse.de; > > tony.luck@intel.com; x86@kernel.org > > Subject: Re: [PATCH 3/3] x86/MCE/AMD: Get address from already initialized > > block > > > > On 2018 Apr 14, Johannes Hirte wrote: > > > On 2018 Feb 01, Yazen Ghannam wrote: > > > > From: Yazen Ghannam > > > > > > > > The block address is saved after the block is initialized when > > > > threshold_init_device() is called. > > > > > > > > Use the saved block address, if available, rather than trying to > > > > rediscover it. > > > > > > > > We can avoid some *on_cpu() calls in the init path that will cause a > > > > call trace when resuming from suspend. > > > > > > > > Cc: # 4.14.x > > > > Signed-off-by: Yazen Ghannam > > > > --- > > > > arch/x86/kernel/cpu/mcheck/mce_amd.c | 15 +++++++++++++++ > > > > 1 file changed, 15 insertions(+) > > > > > > > > diff --git a/arch/x86/kernel/cpu/mcheck/mce_amd.c > > b/arch/x86/kernel/cpu/mcheck/mce_amd.c > > > > index bf53b4549a17..8c4f8f30c779 100644 > > > > --- a/arch/x86/kernel/cpu/mcheck/mce_amd.c > > > > +++ b/arch/x86/kernel/cpu/mcheck/mce_amd.c > > > > @@ -436,6 +436,21 @@ static u32 get_block_address(unsigned int cpu, > > u32 current_addr, u32 low, u32 hi > > > > { > > > > u32 addr = 0, offset = 0; > > > > > > > > + if ((bank >= mca_cfg.banks) || (block >= NR_BLOCKS)) > > > > + return addr; > > > > + > > > > + /* Get address from already initialized block. */ > > > > + if (per_cpu(threshold_banks, cpu)) { > > > > + struct threshold_bank *bankp = per_cpu(threshold_banks, > > cpu)[bank]; > > > > + > > > > + if (bankp && bankp->blocks) { > > > > + struct threshold_block *blockp = &bankp- > > >blocks[block]; > > > > + > > > > + if (blockp) > > > > + return blockp->address; > > > > + } > > > > + } > > > > + > > > > if (mce_flags.smca) { > > > > if (smca_get_bank_type(bank) == SMCA_RESERVED) > > > > return addr; > > > > -- > > > > 2.14.1 > > > > > > I have a KASAN: slab-out-of-bounds, and git bisect points me to this > > > change: > > > > > > Apr 13 00:40:32 probook kernel: > > ================================================================ > > == > > > Apr 13 00:40:32 probook kernel: BUG: KASAN: slab-out-of-bounds in > > get_block_address.isra.3+0x1e9/0x520 > > > Apr 13 00:40:32 probook kernel: Read of size 4 at addr ffff8803f165ddf4 by > > task swapper/0/1 > > > Apr 13 00:40:32 probook kernel: > > > Apr 13 00:40:32 probook kernel: CPU: 1 PID: 1 Comm: swapper/0 Not > > tainted 4.16.0-10757-g4ca8ba4ccff9 #532 > > > Apr 13 00:40:32 probook kernel: Hardware name: HP HP ProBook 645 > > G2/80FE, BIOS N77 Ver. 01.12 12/19/2017 > > > Apr 13 00:40:32 probook kernel: Call Trace: > > > Apr 13 00:40:32 probook kernel: dump_stack+0x5b/0x8b > > > Apr 13 00:40:32 probook kernel: ? get_block_address.isra.3+0x1e9/0x520 > > > Apr 13 00:40:32 probook kernel: print_address_description+0x65/0x270 > > > Apr 13 00:40:32 probook kernel: ? get_block_address.isra.3+0x1e9/0x520 > > > Apr 13 00:40:32 probook kernel: kasan_report+0x232/0x350 > > > Apr 13 00:40:32 probook kernel: get_block_address.isra.3+0x1e9/0x520 > > > Apr 13 00:40:32 probook kernel: ? kobject_init_and_add+0xde/0x130 > > > Apr 13 00:40:32 probook kernel: ? get_name+0x390/0x390 > > > Apr 13 00:40:32 probook kernel: ? kasan_unpoison_shadow+0x30/0x40 > > > Apr 13 00:40:32 probook kernel: ? kasan_kmalloc+0xa0/0xd0 > > > Apr 13 00:40:32 probook kernel: allocate_threshold_blocks+0x12c/0xc60 > > > Apr 13 00:40:32 probook kernel: ? kobject_add_internal+0x800/0x800 > > > Apr 13 00:40:32 probook kernel: ? get_block_address.isra.3+0x520/0x520 > > > Apr 13 00:40:32 probook kernel: ? kasan_kmalloc+0xa0/0xd0 > > > Apr 13 00:40:32 probook kernel: > > mce_threshold_create_device+0x35b/0x990 > > > Apr 13 00:40:32 probook kernel: ? init_special_inode+0x1d0/0x230 > > > Apr 13 00:40:32 probook kernel: threshold_init_device+0x98/0xa7 > > > Apr 13 00:40:32 probook kernel: ? > > mcheck_vendor_init_severity+0x43/0x43 > > > Apr 13 00:40:32 probook kernel: do_one_initcall+0x76/0x30c > > > Apr 13 00:40:32 probook kernel: ? > > trace_event_raw_event_initcall_finish+0x190/0x190 > > > Apr 13 00:40:32 probook kernel: ? kasan_unpoison_shadow+0xb/0x40 > > > Apr 13 00:40:32 probook kernel: ? kasan_unpoison_shadow+0x30/0x40 > > > Apr 13 00:40:32 probook kernel: kernel_init_freeable+0x3d6/0x471 > > > Apr 13 00:40:32 probook kernel: ? rest_init+0xf0/0xf0 > > > Apr 13 00:40:32 probook kernel: kernel_init+0xa/0x120 > > > Apr 13 00:40:32 probook kernel: ? rest_init+0xf0/0xf0 > > > Apr 13 00:40:32 probook kernel: ret_from_fork+0x22/0x40 > > > Apr 13 00:40:32 probook kernel: > > > Apr 13 00:40:32 probook kernel: Allocated by task 1: > > > Apr 13 00:40:32 probook kernel: kasan_kmalloc+0xa0/0xd0 > > > Apr 13 00:40:32 probook kernel: kmem_cache_alloc_trace+0xf3/0x1f0 > > > Apr 13 00:40:32 probook kernel: allocate_threshold_blocks+0x1bc/0xc60 > > > Apr 13 00:40:32 probook kernel: > > mce_threshold_create_device+0x35b/0x990 > > > Apr 13 00:40:32 probook kernel: threshold_init_device+0x98/0xa7 > > > Apr 13 00:40:32 probook kernel: do_one_initcall+0x76/0x30c > > > Apr 13 00:40:32 probook kernel: kernel_init_freeable+0x3d6/0x471 > > > Apr 13 00:40:32 probook kernel: kernel_init+0xa/0x120 > > > Apr 13 00:40:32 probook kernel: ret_from_fork+0x22/0x40 > > > Apr 13 00:40:32 probook kernel: > > > Apr 13 00:40:32 probook kernel: Freed by task 0: > > > Apr 13 00:40:32 probook kernel: (stack is not available) > > > Apr 13 00:40:32 probook kernel: > > > Apr 13 00:40:32 probook kernel: The buggy address belongs to the object at > > ffff8803f165dd80 > > > which belongs to the cache kmalloc-128 of size 128 > > > Apr 13 00:40:32 probook kernel: The buggy address is located 116 bytes > > inside of > > > 128-byte region [ffff8803f165dd80, ffff8803f165de00) > > > Apr 13 00:40:32 probook kernel: The buggy address belongs to the page: > > > Apr 13 00:40:32 probook kernel: page:ffffea000fc59740 count:1 > > mapcount:0 mapping:0000000000000000 index:0x0 > > > Apr 13 00:40:32 probook kernel: flags: 0x2000000000000100(slab) > > > Apr 13 00:40:32 probook kernel: raw: 2000000000000100 > > 0000000000000000 0000000000000000 0000000180150015 > > > Apr 13 00:40:32 probook kernel: raw: dead000000000100 > > dead000000000200 ffff8803f3403340 0000000000000000 > > > Apr 13 00:40:32 probook kernel: page dumped because: kasan: bad access > > detected > > > Apr 13 00:40:32 probook kernel: > > > Apr 13 00:40:32 probook kernel: Memory state around the buggy address: > > > Apr 13 00:40:32 probook kernel: ffff8803f165dc80: fc fc fc fc fc fc fc fc 00 00 > > 00 00 00 00 00 00 > > > Apr 13 00:40:32 probook kernel: ffff8803f165dd00: 00 00 00 00 00 00 00 fc > > fc fc fc fc fc fc fc fc > > > Apr 13 00:40:32 probook kernel: >ffff8803f165dd80: 00 00 00 00 00 00 00 > > 00 00 00 00 00 00 fc fc fc > > > Apr 13 00:40:32 probook kernel: ^ > > > Apr 13 00:40:32 probook kernel: ffff8803f165de00: fc fc fc fc fc fc fc fc fc fc > > fc fc fc fc fc fc > > > Apr 13 00:40:32 probook kernel: ffff8803f165de80: fc fc fc fc fc fc fc fc fc fc > > fc fc fc fc fc fc > > > Apr 13 00:40:32 probook kernel: > > ================================================================ > > == > > > > > > > Putting the whole chaching part under the > > > > if (mce_flags.smca) { > > > > solved the issue on my Carrizo. > > > > Thanks for reporting this. I'm able to reproduce this on my Fam17h system. The > caching should still be the same on non-SMCA systems. Putting it all under the > SMCA flags effectively removes it on Carrizo. > > Here are when get_block_address() is called: > 1) Boot time MCE init. Called on each CPU. No caching. > 2) Init of the MCE device. Called on a single CPU. Values are cached here. > 3) CPU on/offling which calls MCE init. Should use the cached values. > > It seems to me that the KASAN bug is detected during #2 though it's not yet clear > to me what the issue is. I need to read up on KASAN and keep debugging. The out-of-bound access happens in get_block_address: if (bankp && bankp->blocks) { struct threshold_block *blockp blockp = &bankp->blocks[block]; with block=1. This doesn't exists. I don't even find any array here. There is a linked list, created in allocate_threshold_blocks. On my system I get 17 lists with one element each. -- Regards, Johannes