From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH 04/40] proc: introduce proc_create_seq{, _data} Date: Tue, 15 May 2018 16:42:44 +0200 Message-ID: <20180515144244.GA32583@lst.de> References: <20180425154827.32251-5-hch@lst.de> <20180425154827.32251-1-hch@lst.de> <26540.1525094365@warthog.procyon.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <26540.1525094365-S6HVgzuS8uM4Awkfq6JHfwNdhmdF6hFW@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: drbd-dev-bounces-cunTk1MwBs8qoQakbn7OcQ@public.gmane.org Errors-To: drbd-dev-bounces-cunTk1MwBs8qoQakbn7OcQ@public.gmane.org To: David Howells Cc: linux-rtc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Alessandro Zummo , Alexandre Belloni , devel-gWbeCf7V1WCQmaza687I9mD2FQJk+8+b@public.gmane.org, linux-scsi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-acpi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Greg Kroah-Hartman , Jiri Slaby , megaraidlinux.pdl-dY08KVG/lbpWk0Htik3J/w@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-afs-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-ide-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, netfilter-devel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Alexander Viro , netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Andrew Morton , linux-ext4-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, drbd-dev-cunTk1MwBs8qoQakbn7OcQ@public.gmane.org, Christoph Hellwig , jfs-discussion-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, Alexey Dobriyan List-Id: linux-acpi@vger.kernel.org On Mon, Apr 30, 2018 at 02:19:25PM +0100, David Howells wrote: > Christoph Hellwig wrote: > > > + > > +struct proc_dir_entry *proc_create_seq_data(const char *name, umode_t mode, > > + struct proc_dir_entry *parent, const struct seq_operations *ops, > > + void *data) > > +{ > > ... > > +EXPORT_SYMBOL(proc_create_seq_data); > > Please add documentation comments to exported functions when you add them. None of the base functions are document, and we really want people to not use procfs for new code anyway. But if I get some consensus from the maintainers and the list I can throw in another patch to document all proc_create* variants. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from verein.lst.de ([213.95.11.211]:42309 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752246AbeEOOi0 (ORCPT ); Tue, 15 May 2018 10:38:26 -0400 Date: Tue, 15 May 2018 16:42:44 +0200 From: Christoph Hellwig To: David Howells Cc: Christoph Hellwig , Andrew Morton , Alexander Viro , linux-rtc@vger.kernel.org, Alessandro Zummo , Alexandre Belloni , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, linux-ide@vger.kernel.org, Greg Kroah-Hartman , jfs-discussion@lists.sourceforge.net, linux-afs@lists.infradead.org, linux-acpi@vger.kernel.org, netdev@vger.kernel.org, netfilter-devel@vger.kernel.org, Jiri Slaby , linux-ext4@vger.kernel.org, Alexey Dobriyan , megaraidlinux.pdl@broadcom.com, drbd-dev@lists.linbit.com Subject: Re: [PATCH 04/40] proc: introduce proc_create_seq{,_data} Message-ID: <20180515144244.GA32583@lst.de> References: <20180425154827.32251-5-hch@lst.de> <20180425154827.32251-1-hch@lst.de> <26540.1525094365@warthog.procyon.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <26540.1525094365@warthog.procyon.org.uk> Sender: linux-rtc-owner@vger.kernel.org List-ID: On Mon, Apr 30, 2018 at 02:19:25PM +0100, David Howells wrote: > Christoph Hellwig wrote: > > > + > > +struct proc_dir_entry *proc_create_seq_data(const char *name, umode_t mode, > > + struct proc_dir_entry *parent, const struct seq_operations *ops, > > + void *data) > > +{ > > ... > > +EXPORT_SYMBOL(proc_create_seq_data); > > Please add documentation comments to exported functions when you add them. None of the base functions are document, and we really want people to not use procfs for new code anyway. But if I get some consensus from the maintainers and the list I can throw in another patch to document all proc_create* variants. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from newverein.lst.de (verein.lst.de [213.95.11.211]) by mail09.linbit.com (LINBIT Mail Daemon) with ESMTP id 38ACC1057315 for ; Tue, 15 May 2018 16:38:24 +0200 (CEST) Date: Tue, 15 May 2018 16:42:44 +0200 From: Christoph Hellwig To: David Howells Message-ID: <20180515144244.GA32583@lst.de> References: <20180425154827.32251-5-hch@lst.de> <20180425154827.32251-1-hch@lst.de> <26540.1525094365@warthog.procyon.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <26540.1525094365@warthog.procyon.org.uk> Cc: linux-rtc@vger.kernel.org, Alessandro Zummo , Alexandre Belloni , devel@driverdev.osuosl.org, linux-scsi@vger.kernel.org, linux-acpi@vger.kernel.org, Greg Kroah-Hartman , Jiri Slaby , megaraidlinux.pdl@broadcom.com, linux-kernel@vger.kernel.org, linux-afs@lists.infradead.org, linux-ide@vger.kernel.org, netfilter-devel@vger.kernel.org, Alexander Viro , netdev@vger.kernel.org, Andrew Morton , linux-ext4@vger.kernel.org, drbd-dev@lists.linbit.com, Christoph Hellwig , jfs-discussion@lists.sourceforge.net, Alexey Dobriyan Subject: Re: [Drbd-dev] [PATCH 04/40] proc: introduce proc_create_seq{, _data} List-Id: "*Coordination* of development, patches, contributions -- *Questions* \(even to developers\) go to drbd-user, please." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Mon, Apr 30, 2018 at 02:19:25PM +0100, David Howells wrote: > Christoph Hellwig wrote: > > > + > > +struct proc_dir_entry *proc_create_seq_data(const char *name, umode_t mode, > > + struct proc_dir_entry *parent, const struct seq_operations *ops, > > + void *data) > > +{ > > ... > > +EXPORT_SYMBOL(proc_create_seq_data); > > Please add documentation comments to exported functions when you add them. None of the base functions are document, and we really want people to not use procfs for new code anyway. But if I get some consensus from the maintainers and the list I can throw in another patch to document all proc_create* variants.