From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Tue, 15 May 2018 13:01:29 -0400 Subject: [U-Boot] [PATCH v4 26/32] tpm: add the possibility to reset the chip with a gpio In-Reply-To: <20180515183243.674e80d1@xps13> References: <20180515095728.16572-1-miquel.raynal@bootlin.com> <20180515095728.16572-27-miquel.raynal@bootlin.com> <20180515183243.674e80d1@xps13> Message-ID: <20180515170129.GT3424@bill-the-cat.ec.rr.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Tue, May 15, 2018 at 06:32:43PM +0200, Miquel Raynal wrote: > Simon, Tom, > > On Wed, 16 May 2018 02:05:01 +1000, Simon Glass > wrote: > > > On 15 May 2018 at 19:57, Miquel Raynal wrote: > > > On some designs, the reset line could not be connected to the SoC reset > > > line, in this case, request the GPIO and ensure the chip gets reset. > > > > > > Signed-off-by: Miquel Raynal > > > --- > > > drivers/tpm/tpm2_tis_spi.c | 17 +++++++++++++++++ > > > 1 file changed, 17 insertions(+) > > > > Reviewed-by: Simon Glass > > > > Question below > > > > > > > > diff --git a/drivers/tpm/tpm2_tis_spi.c b/drivers/tpm/tpm2_tis_spi.c > > > index 6a4d5284c9..1c7f8f3673 100644 > > > --- a/drivers/tpm/tpm2_tis_spi.c > > > +++ b/drivers/tpm/tpm2_tis_spi.c > > > @@ -24,6 +24,9 @@ > > > #include > > > #include > > > #include > > > +#ifdef CONFIG_DM_GPIO > > > +#include > > > +#endif > > > > > > #include "tpm_tis.h" > > > #include "tpm_internal.h" > > > @@ -574,6 +577,20 @@ static int tpm_tis_spi_probe(struct udevice *dev) > > > struct tpm_chip_priv *priv = dev_get_uclass_priv(dev); > > > struct tpm_chip *chip = dev_get_priv(dev); > > > int ret; > > > +#ifdef CONFIG_DM_GPIO > > > > Can this use if (IS_ENABLED(CONFIG_DM_GPIO)) ? > > > > It helps to improve build coverage. > > > > Sure! > > Tom, I guess the series needs the following changes: > - update the old license identifiers > - two occurrences of "#ifdef CONFIG_DM_GPIO" in this patch to be > replaced by "#if (IS_ENABLED(CONFIG_DM_GPIO))" > > I can either repost a new iteration of the whole series/just this patch > or let you make the changes. Let me know what is best for you. > > Thanks you very much, both of you, for your guidance. Just this patch is fine and thanks for iterating over it all! -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: not available URL: