From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from aserp2130.oracle.com ([141.146.126.79]) by Galois.linutronix.de with esmtps (TLS1.2:RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1fInIf-0003fc-I6 for speck@linutronix.de; Wed, 16 May 2018 05:40:26 +0200 Received: from pps.filterd (aserp2130.oracle.com [127.0.0.1]) by aserp2130.oracle.com (8.16.0.22/8.16.0.22) with SMTP id w4G3afif098242 for ; Wed, 16 May 2018 03:40:18 GMT Received: from userv0022.oracle.com (userv0022.oracle.com [156.151.31.74]) by aserp2130.oracle.com with ESMTP id 2hxpvcsj5e-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Wed, 16 May 2018 03:40:18 +0000 Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by userv0022.oracle.com (8.14.4/8.14.4) with ESMTP id w4G3eH2M021133 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Wed, 16 May 2018 03:40:17 GMT Received: from abhmp0014.oracle.com (abhmp0014.oracle.com [141.146.116.20]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id w4G3eH4v025642 for ; Wed, 16 May 2018 03:40:17 GMT Date: Tue, 15 May 2018 23:40:11 -0400 From: Konrad Rzeszutek Wilk Subject: [MODERATED] Re: [patch 12/15] Hidden 12 Message-ID: <20180516034010.GC26939@char.us.oracle.com> References: <20180513140048.543641807@linutronix.de> <20180513140539.223630033@linutronix.de> MIME-Version: 1.0 In-Reply-To: <20180513140539.223630033@linutronix.de> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit To: speck@linutronix.de List-ID: On Sun, May 13, 2018 at 04:01:00PM +0200, speck for Thomas Gleixner wrote: > Subject: [patch 12/15] x86/bugs: Remove x86_spec_ctrl_set() > From: Thomas Gleixner > > x86_spec_ctrl_set() is only used in bugs.c and the extra mask checks there > provide no real value as both call sites can just write x86_spec_ctrl_base > to MSR_SPEC_CTRL. x86_spec_ctrl_base is valid and does not need any extra > masking or checking. Reviewed-by: Konrad Rzeszutek Wilk Thank you!