From: Sahitya Tummala <stummala@codeaurora.org>
To: Chao Yu <yuchao0@huawei.com>
Cc: Jaegeuk Kim <jaegeuk@kernel.org>,
linux-f2fs-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] f2fs: Fix deadlock in shutdown ioctl
Date: Wed, 16 May 2018 13:02:02 +0530 [thread overview]
Message-ID: <20180516073202.GB6293@codeaurora.org> (raw)
In-Reply-To: <67bd2926-6851-0544-c24a-85dfa72aa70f@huawei.com>
On Wed, May 16, 2018 at 02:48:42PM +0800, Chao Yu wrote:
> >
> > Thanks, I thought about it too but then I checked that XFS shutdown ioctl is
> > not taking any lock for this ioctl. Hence, I followed the same in F2FS.
> > Do you know why XFS is not taking any lock?
>
> I don't know. :(
No problem :)
>
> > Is it really needed in shutdown ioctl?
>
> IMO, yes, we should keep freeze and remount be aware of the shutdown operation.
Thanks for your inputs. I will send the updated patch set.
--
Sent by a consultant of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
prev parent reply other threads:[~2018-05-16 7:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-10 13:20 [PATCH] f2fs: Fix deadlock in shutdown ioctl Sahitya Tummala
2018-05-14 3:39 ` Chao Yu
2018-05-14 3:39 ` Chao Yu
2018-05-15 7:57 ` Sahitya Tummala
2018-05-16 6:48 ` Chao Yu
2018-05-16 6:48 ` Chao Yu
2018-05-16 7:32 ` Sahitya Tummala [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180516073202.GB6293@codeaurora.org \
--to=stummala@codeaurora.org \
--cc=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=yuchao0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.