[meta-oe][PATCH] grpc: switch away from github archive

[meta-oe][PATCH] grpc: switch away from github archive

[Trevor Woerner]

Since we know that github archives which are automatically generated have a
tendency to change their checksums[1], switch to using a git clone.

[1] http://lists.openembedded.org/pipermail/openembedded-devel/2017-September/114916.html

Signed-off-by: Trevor Woerner <twoerner@gmail.com>
---
 meta-oe/recipes-devtools/grpc/grpc_1.8.5.bb | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/meta-oe/recipes-devtools/grpc/grpc_1.8.5.bb b/meta-oe/recipes-devtools/grpc/grpc_1.8.5.bb
index 0883ec176b..a0c943d114 100644
--- a/meta-oe/recipes-devtools/grpc/grpc_1.8.5.bb
+++ b/meta-oe/recipes-devtools/grpc/grpc_1.8.5.bb
@@ -10,13 +10,13 @@ DEPENDS_append_class-target = " gtest grpc-native "
 
 LIC_FILES_CHKSUM = "file://LICENSE;md5=3b83ef96387f14655fc854ddc3c6bd57"
 
-SRC_URI = "https://github.com/grpc/grpc/archive/v${PV}.tar.gz \
+S = "${WORKDIR}/git"
+SRCREV = "db68cb3652cc7697647e9934b5316d98a6ba04d1"
+BRANCH = "v1.8.x"
+SRC_URI = "git://github.com/grpc/grpc.git;protocol=https;branch=${BRANCH} \
            file://0001-CMakeLists.txt-Fix-libraries-installation-for-Linux.patch \
            file://0004-CMakeLists.txt-Find-c-ares-in-target-sysroot-alone.patch \
            "
-SRC_URI[md5sum] = "b565fa6787e42f4969395870c2ad436e"
-SRC_URI[sha256sum] = "df9168da760fd2ee970c74c9d1b63377e0024be248deaa844e784d0df47599de"
-
 SRC_URI_append_class-target = " file://0001-CMakeLists.txt-Fix-grpc_cpp_plugin-path-during-cross.patch"
 
 inherit cmake
-- 
2.17.0.rc2.3.gc2a499e6c

Re: [meta-oe][PATCH] grpc: switch away from github archive

[akuster808]

On 05/16/2018 10:19 AM, Trevor Woerner wrote:
> Since we know that github archives which are automatically generated have a
> tendency to change their checksums[1], switch to using a git clone.
>
> [1] http://lists.openembedded.org/pipermail/openembedded-devel/2017-September/114916.html

This recipe is in the middle of moving to meta-networking ie in
master-next not yet merged to master.

either the meta-networking maintainer will integrate or maybe a rebase
on master-next would be helpful??

thanks for the patch.
Armin
>
> Signed-off-by: Trevor Woerner <twoerner@gmail.com>
> ---
>  meta-oe/recipes-devtools/grpc/grpc_1.8.5.bb | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/meta-oe/recipes-devtools/grpc/grpc_1.8.5.bb b/meta-oe/recipes-devtools/grpc/grpc_1.8.5.bb
> index 0883ec176b..a0c943d114 100644
> --- a/meta-oe/recipes-devtools/grpc/grpc_1.8.5.bb
> +++ b/meta-oe/recipes-devtools/grpc/grpc_1.8.5.bb
> @@ -10,13 +10,13 @@ DEPENDS_append_class-target = " gtest grpc-native "
>  
>  LIC_FILES_CHKSUM = "file://LICENSE;md5=3b83ef96387f14655fc854ddc3c6bd57"
>  
> -SRC_URI = "https://github.com/grpc/grpc/archive/v${PV}.tar.gz \
> +S = "${WORKDIR}/git"
> +SRCREV = "db68cb3652cc7697647e9934b5316d98a6ba04d1"
> +BRANCH = "v1.8.x"
> +SRC_URI = "git://github.com/grpc/grpc.git;protocol=https;branch=${BRANCH} \
>             file://0001-CMakeLists.txt-Fix-libraries-installation-for-Linux.patch \
>             file://0004-CMakeLists.txt-Find-c-ares-in-target-sysroot-alone.patch \
>             "
> -SRC_URI[md5sum] = "b565fa6787e42f4969395870c2ad436e"
> -SRC_URI[sha256sum] = "df9168da760fd2ee970c74c9d1b63377e0024be248deaa844e784d0df47599de"
> -
>  SRC_URI_append_class-target = " file://0001-CMakeLists.txt-Fix-grpc_cpp_plugin-path-during-cross.patch"
>  
>  inherit cmake

Re: [meta-oe][PATCH] grpc: switch away from github archive

[Trevor Woerner]

On Wed, May 16, 2018 at 3:37 PM, akuster808 <akuster808@gmail.com> wrote:

>
>
> On 05/16/2018 10:19 AM, Trevor Woerner wrote:
> > Since we know that github archives which are automatically generated
> have a
> > tendency to change their checksums[1], switch to using a git clone.
> >
> > [1] http://lists.openembedded.org/pipermail/openembedded-devel/
> 2017-September/114916.html
>
> This recipe is in the middle of moving to meta-networking ie in
> master-next not yet merged to master.
>
> either the meta-networking maintainer will integrate or maybe a rebase
> on master-next would be helpful??
>

Sure, I can send a v2 rebased on master-next.

Now that you've started a build test of master, maybe the rest of this
janitorial cleanup should be done relative to master-next?


>
> thanks for the patch.
>

no problem! :-D