All of lore.kernel.org
 help / color / mirror / Atom feed
From: Trevor Woerner <twoerner@gmail.com>
To: Khem Raj <raj.khem@gmail.com>
Cc: openembeded-devel <openembedded-devel@lists.openembedded.org>
Subject: Re: [meta-multimedia][PATCH v2 1/2] openh264: fix build for 32-bit intel arch
Date: Wed, 16 May 2018 13:40:31 -0400	[thread overview]
Message-ID: <20180516174031.GA19844@linux-uys3> (raw)
In-Reply-To: <CAHUNapSxvc4LhyfuR-VNeAaApxv0ujRddwavFCdpH59LLb+0qA@mail.gmail.com>

On Wed 2018-05-16 @ 01:32:53 PM, Trevor Woerner wrote:
> > >  EXTRA_OEMAKE_armv7a = "ARCH=arm"
> > >  EXTRA_OEMAKE_aarch64 = "ARCH=arm64"
> > > -EXTRA_OEMAKE_i386 = "ARCH=i386"
> > > +EXTRA_OEMAKE_x86 = "ARCH=i386"
> >
> > can you take another look if there are other options eg. i686 ?
> > if in literal sense it means i386 then we should not be using it
> > for newer i*86 arches.

According to the README
(https://github.com/cisco/openh264/blob/openh264v1.7/README.md#for-all-platforms)
specifying "ARCH=i386" is this project's generic way of saying "32-bit x86
builds" (which is why the recipe needs to "translate" between x86 and i386).

I'll send an updated v4 (this was actually supposed to be v3, oops!) with the
+= replaced with an _appends.

thanks for reviewing! :-)


      reply	other threads:[~2018-05-16 17:40 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-16 17:06 [meta-multimedia][PATCH v2 1/2] openh264: fix build for 32-bit intel arch Trevor Woerner
2018-05-16 17:06 ` [meta-multimedia][PATCH v2 2/2] openh264: switch away from github archive Trevor Woerner
2018-05-16 17:10 ` [meta-multimedia][PATCH v2 1/2] openh264: fix build for 32-bit intel arch Khem Raj
2018-05-16 17:32   ` Trevor Woerner
2018-05-16 17:40     ` Trevor Woerner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180516174031.GA19844@linux-uys3 \
    --to=twoerner@gmail.com \
    --cc=openembedded-devel@lists.openembedded.org \
    --cc=raj.khem@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.