From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Subject: [PATCH] drm/amd/pp: missing curly braces in smu7_enable_sclk_mclk_dpm() Date: Thu, 17 May 2018 15:56:05 +0300 Message-ID: <20180517125604.GA10930@mwanda> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: Alex Deucher , Eric Huang Cc: "David (ChunMing) Zhou" , David Airlie , kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, Evan Quan , Rex Zhu , Christian =?iso-8859-1?Q?K=F6nig?= V2UgYWRkZWQgc29tZSBtb3JlIGxpbmVzIG9mIGNvZGUgdG8gdGhpcyBpZiBzdGF0ZW1lbnQgYnV0 IGZvcmdvdCB0byBhZGQKY3VybHkgYnJhY2VzLgoKRml4ZXM6IDBjMjRlN2VmMjMzYiAoImRybS9h bWQvcG93ZXJwbGF5OiBhZGQgc3BlY2lmaWMgY2hhbmdlcyBmb3IgVkVHQU0gaW4gc211N19od21n ci5jIikKU2lnbmVkLW9mZi1ieTogRGFuIENhcnBlbnRlciA8ZGFuLmNhcnBlbnRlckBvcmFjbGUu Y29tPgoKZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9hbWQvcG93ZXJwbGF5L2h3bWdyL3Nt dTdfaHdtZ3IuYyBiL2RyaXZlcnMvZ3B1L2RybS9hbWQvcG93ZXJwbGF5L2h3bWdyL3NtdTdfaHdt Z3IuYwppbmRleCA4ZWIzZjUxNzY2NDYuLjY0NmM5ZTliZjY4MSAxMDA2NDQKLS0tIGEvZHJpdmVy cy9ncHUvZHJtL2FtZC9wb3dlcnBsYXkvaHdtZ3Ivc211N19od21nci5jCisrKyBiL2RyaXZlcnMv Z3B1L2RybS9hbWQvcG93ZXJwbGF5L2h3bWdyL3NtdTdfaHdtZ3IuYwpAQCAtMTAxOCw3ICsxMDE4 LDcgQEAgc3RhdGljIGludCBzbXU3X2VuYWJsZV9zY2xrX21jbGtfZHBtKHN0cnVjdCBwcF9od21n ciAqaHdtZ3IpCiAJc3RydWN0IHNtdTdfaHdtZ3IgKmRhdGEgPSAoc3RydWN0IHNtdTdfaHdtZ3Ig KikoaHdtZ3ItPmJhY2tlbmQpOwogCiAJLyogZW5hYmxlIFNDTEsgZHBtICovCi0JaWYgKCFkYXRh LT5zY2xrX2RwbV9rZXlfZGlzYWJsZWQpCisJaWYgKCFkYXRhLT5zY2xrX2RwbV9rZXlfZGlzYWJs ZWQpIHsKIAkJaWYgKGh3bWdyLT5jaGlwX2lkID09IENISVBfVkVHQU0pCiAJCQlzbXU3X2Rpc2Fi bGVfc2Nsa192Y2VfaGFuZHNoYWtlKGh3bWdyKTsKIApAQCAtMTAyNiw2ICsxMDI2LDcgQEAgc3Rh dGljIGludCBzbXU3X2VuYWJsZV9zY2xrX21jbGtfZHBtKHN0cnVjdCBwcF9od21nciAqaHdtZ3Ip CiAJCSgwID09IHNtdW1fc2VuZF9tc2dfdG9fc21jKGh3bWdyLCBQUFNNQ19NU0dfRFBNX0VuYWJs ZSkpLAogCQkiRmFpbGVkIHRvIGVuYWJsZSBTQ0xLIERQTSBkdXJpbmcgRFBNIFN0YXJ0IEZ1bmN0 aW9uISIsCiAJCXJldHVybiAtRUlOVkFMKTsKKwl9CiAKIAkvKiBlbmFibGUgTUNMSyBkcG0gKi8K IAlpZiAoMCA9PSBkYXRhLT5tY2xrX2RwbV9rZXlfZGlzYWJsZWQpIHsKX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KYW1kLWdmeCBtYWlsaW5nIGxpc3QKYW1k LWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcv bWFpbG1hbi9saXN0aW5mby9hbWQtZ2Z4Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Date: Thu, 17 May 2018 12:56:05 +0000 Subject: [PATCH] drm/amd/pp: missing curly braces in smu7_enable_sclk_mclk_dpm() Message-Id: <20180517125604.GA10930@mwanda> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Alex Deucher , Eric Huang Cc: "David (ChunMing) Zhou" , David Airlie , kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, Evan Quan , Rex Zhu , Christian =?iso-8859-1?Q?K=F6nig?= We added some more lines of code to this if statement but forgot to add curly braces. Fixes: 0c24e7ef233b ("drm/amd/powerplay: add specific changes for VEGAM in smu7_hwmgr.c") Signed-off-by: Dan Carpenter diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c b/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c index 8eb3f5176646..646c9e9bf681 100644 --- a/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c +++ b/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c @@ -1018,7 +1018,7 @@ static int smu7_enable_sclk_mclk_dpm(struct pp_hwmgr *hwmgr) struct smu7_hwmgr *data = (struct smu7_hwmgr *)(hwmgr->backend); /* enable SCLK dpm */ - if (!data->sclk_dpm_key_disabled) + if (!data->sclk_dpm_key_disabled) { if (hwmgr->chip_id = CHIP_VEGAM) smu7_disable_sclk_vce_handshake(hwmgr); @@ -1026,6 +1026,7 @@ static int smu7_enable_sclk_mclk_dpm(struct pp_hwmgr *hwmgr) (0 = smum_send_msg_to_smc(hwmgr, PPSMC_MSG_DPM_Enable)), "Failed to enable SCLK DPM during DPM Start Function!", return -EINVAL); + } /* enable MCLK dpm */ if (0 = data->mclk_dpm_key_disabled) {