Re: [Qemu-devel] [PATCH] ui: add x_keymap.o to modules

["Daniel P. Berrangé" <berrange@redhat.com>]

On Thu, May 17, 2018 at 02:50:04PM +0200, Paolo Bonzini wrote:
> On 17/05/2018 14:44, Daniel P. Berrangé wrote:
> >> +ifeq ($(CONFIG_X11),y)
> >> +sdl.mo-objs += x_keymap.o
> >> +gtk.mo-objs += x_keymap.o
> > Would this cause symbol clash if both sdl & gtk modules are loaded
> > at the same time, or have we used linker scripts to limit what symbols
> > each module exposes ?
> > 
> 
> We don't, but: 1) the file has only functions and no data; 2) in any
> case the symbols are the same, so it is not a real clash.

Ok, as long as dlopen() doesn't whine its fine with me.

> Adding linker scripts would be a nice improvement, but it is not
> necessary for this patch.

Agreed.

> Another possibility would be to include x_keymap.c in the files that use
> it and make qemu_xkeymap_mapping_table static, but I think it would be
> the worst.

It isn't worth trying to be too clever since we're deleting SDL1 in
the 2.14 dev cycle.

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|