From mboxrd@z Thu Jan  1 00:00:00 1970
From: Adrien Mazarguil <adrien.mazarguil@6wind.com>
Subject: Re: [dpdk-stable] [PATCH] maintainers: fix
 responsibility of flow API bits
Date: Thu, 17 May 2018 17:50:38 +0200
Message-ID: <20180517155038.GJ6497@6wind.com>
References: <1525944544-13513-1-git-send-email-bernard.iremonger@intel.com>
 <20180515162211.7030-1-adrien.mazarguil@6wind.com>
 <8CEF83825BEC744B83065625E567D7C24E0CD20F@IRSMSX108.ger.corp.intel.com>
 <20180516143517.GA6497@6wind.com>
 <8CEF83825BEC744B83065625E567D7C24E0CD818@IRSMSX108.ger.corp.intel.com>
 <20180517112045.GE6497@6wind.com>
 <8CEF83825BEC744B83065625E567D7C24E0CD93C@IRSMSX108.ger.corp.intel.com>
 <7431a0f3-e87e-6b8b-04ae-9fd6e919a699@intel.com>
 <8CEF83825BEC744B83065625E567D7C24E0CDB76@IRSMSX108.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: "Yigit, Ferruh" <ferruh.yigit@intel.com>, "dev@dpdk.org" <dev@dpdk.org>,
 "stable@dpdk.org" <stable@dpdk.org>
To: "Iremonger, Bernard" <bernard.iremonger@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f66.google.com (mail-wm0-f66.google.com [74.125.82.66])
 by dpdk.org (Postfix) with ESMTP id 5604E7CD9
 for <dev@dpdk.org>; Thu, 17 May 2018 17:50:54 +0200 (CEST)
Received: by mail-wm0-f66.google.com with SMTP id w194-v6so9267260wmf.2
 for <dev@dpdk.org>; Thu, 17 May 2018 08:50:54 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <8CEF83825BEC744B83065625E567D7C24E0CDB76@IRSMSX108.ger.corp.intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Thu, May 17, 2018 at 02:51:43PM +0000, Iremonger, Bernard wrote:
> Hi Adrien, Ferruh,
> 
> <snip>
>  
> > (Another patch will separate testpmd_flow.rst? and add maintainership for it)
> 
> There is also a lot of flow related code in dpdk/app/test-pmd/config.c (lines 985 to 1623), maybe this should be moved to a separate file also, with maintainership added for the new file?

I will consider it also, although the majority of that code is a copy of
rte_flow_copy(), which was added later for failsafe PMD needs.

Testpmd was supposed to use the public version but I wanted to replace
rte_flow_copy() with the more flexible rte_flow_conv() first [1][2].

[1] "[PATCH v1 2/7] ethdev: replace flow API object copy function"
    http://dpdk.org/ml/archives/dev/2017-October/077553.html
[2] "[PATCH v1 4/7] app/testpmd: rely on flow API conversion function"
    http://dpdk.org/ml/archives/dev/2017-October/077555.html

-- 
Adrien Mazarguil
6WIND