From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 1/5] drm/i915: Clean up ADPA pipe select bits Date: Thu, 17 May 2018 20:03:15 +0300 Message-ID: <20180517170315.GM23723@intel.com> References: <20180514172423.9302-1-ville.syrjala@linux.intel.com> <87bmdezkz4.fsf@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id A538E6EAF1 for ; Thu, 17 May 2018 17:03:18 +0000 (UTC) Content-Disposition: inline In-Reply-To: <87bmdezkz4.fsf@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Jani Nikula Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCBNYXkgMTcsIDIwMTggYXQgMTI6MzE6NTlQTSArMDMwMCwgSmFuaSBOaWt1bGEgd3Jv dGU6Cj4gT24gTW9uLCAxNCBNYXkgMjAxOCwgVmlsbGUgU3lyamFsYSA8dmlsbGUuc3lyamFsYUBs aW51eC5pbnRlbC5jb20+IHdyb3RlOgo+ID4gRnJvbTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5z eXJqYWxhQGxpbnV4LmludGVsLmNvbT4KPiA+Cj4gPiBDbGVhbiB1cCB0aGUgQURQQSBwaXBlIHNl bGVjdCBiaXRzLiBUbyBtYWtlIHRoZSB3aG9sZSBzaXR1YXRpb24gYSBiaXQKPiA+IGxlc3MgdWds eSB3ZSdsbCBzdGFydCB0byBzaGFyZSB0aGUgc2FtZSBjb2RlIGJldHdlZW4gLmdldF9od19zdGF0 ZSgpCj4gPiBhbmQgdGhlIHBvcnQgc3RhdGUgYXNzZXJ0cy4KPiA+Cj4gPiB2MjogT3JkZXIgdGhl IGRlZmluZXMgc2hpZnQsbWFzayx2YWx1ZSAoSmFuaSkKPiA+Cj4gPiBSZXZpZXdlZC1ieTogSmFu aSBOaWt1bGEgPGphbmkubmlrdWxhQGludGVsLmNvbT4KPiAKPiBZdXAsIHRoZSBzZXJpZXMgbG9v a3MgZ29vZC4KCkNvb2wuIFB1c2hlZCB0byBkaW5xLgoKPiAKPiBCUiwKPiBKYW5pLgo+IAo+ID4g U2lnbmVkLW9mZi1ieTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVs LmNvbT4KPiA+IC0tLQo+ID4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfcmVnLmggICAgICB8 IDExICsrKysrLS0tLS0KPiA+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9jcnQuYyAgICAg fCA0MCArKysrKysrKysrKysrKysrKystLS0tLS0tLS0tLS0tLS0tLS0KPiA+ICBkcml2ZXJzL2dw dS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMgfCAyNCArKysrKy0tLS0tLS0tLS0tLS0tLS0tCj4g PiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHJ2LmggICAgIHwgIDIgKysKPiA+ICA0IGZp bGVzIGNoYW5nZWQsIDMzIGluc2VydGlvbnMoKyksIDQ0IGRlbGV0aW9ucygtKQo+ID4KPiA+IGRp ZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3JlZy5oIGIvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaTkxNV9yZWcuaAo+ID4gaW5kZXggZjExYmIyMTNlYzA3Li5hZTNjMjYyMTY5OTYg MTAwNjQ0Cj4gPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3JlZy5oCj4gPiArKysg Yi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3JlZy5oCj4gPiBAQCAtNDEzMywxMSArNDEzMywx MiBAQCBlbnVtIHsKPiA+ICAKPiA+ICAjZGVmaW5lICAgQURQQV9EQUNfRU5BQkxFCSgxPDwzMSkK PiA+ICAjZGVmaW5lICAgQURQQV9EQUNfRElTQUJMRQkwCj4gPiAtI2RlZmluZSAgIEFEUEFfUElQ RV9TRUxFQ1RfTUFTSwkoMTw8MzApCj4gPiAtI2RlZmluZSAgIEFEUEFfUElQRV9BX1NFTEVDVAkw Cj4gPiAtI2RlZmluZSAgIEFEUEFfUElQRV9CX1NFTEVDVAkoMTw8MzApCj4gPiAtI2RlZmluZSAg IEFEUEFfUElQRV9TRUxFQ1QocGlwZSkgKChwaXBlKSA8PCAzMCkKPiA+IC0vKiBDUFQgdXNlcyBi aXRzIDI5OjMwIGZvciBwY2ggdHJhbnNjb2RlciBzZWxlY3QgKi8KPiA+ICsjZGVmaW5lICAgQURQ QV9QSVBFX1NFTF9TSElGVAkJMzAKPiA+ICsjZGVmaW5lICAgQURQQV9QSVBFX1NFTF9NQVNLCQko MTw8MzApCj4gPiArI2RlZmluZSAgIEFEUEFfUElQRV9TRUwocGlwZSkJCSgocGlwZSkgPDwgMzAp Cj4gPiArI2RlZmluZSAgIEFEUEFfUElQRV9TRUxfU0hJRlRfQ1BUCTI5Cj4gPiArI2RlZmluZSAg IEFEUEFfUElQRV9TRUxfTUFTS19DUFQJKDM8PDI5KQo+ID4gKyNkZWZpbmUgICBBRFBBX1BJUEVf U0VMX0NQVChwaXBlKQkoKHBpcGUpIDw8IDI5KQo+ID4gICNkZWZpbmUgICBBRFBBX0NSVF9IT1RQ TFVHX01BU0sgIDB4MDNmZjAwMDAgLyogYml0IDI1LTE2ICovCj4gPiAgI2RlZmluZSAgIEFEUEFf Q1JUX0hPVFBMVUdfTU9OSVRPUl9OT05FICAoMDw8MjQpCj4gPiAgI2RlZmluZSAgIEFEUEFfQ1JU X0hPVFBMVUdfTU9OSVRPUl9NQVNLICAoMzw8MjQpCj4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9n cHUvZHJtL2k5MTUvaW50ZWxfY3J0LmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9jcnQu Ywo+ID4gaW5kZXggZGUwZTIyMzIyYzc2Li4yMTFkNjAxY2QxYjEgMTAwNjQ0Cj4gPiAtLS0gYS9k cml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9jcnQuYwo+ID4gKysrIGIvZHJpdmVycy9ncHUvZHJt L2k5MTUvaW50ZWxfY3J0LmMKPiA+IEBAIC02MywzMyArNjMsMzUgQEAgc3RhdGljIHN0cnVjdCBp bnRlbF9jcnQgKmludGVsX2F0dGFjaGVkX2NydChzdHJ1Y3QgZHJtX2Nvbm5lY3RvciAqY29ubmVj dG9yKQo+ID4gIAlyZXR1cm4gaW50ZWxfZW5jb2Rlcl90b19jcnQoaW50ZWxfYXR0YWNoZWRfZW5j b2Rlcihjb25uZWN0b3IpKTsKPiA+ICB9Cj4gPiAgCj4gPiArYm9vbCBpbnRlbF9jcnRfcG9ydF9l bmFibGVkKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPiA+ICsJCQkgICAgaTkx NV9yZWdfdCBhZHBhX3JlZywgZW51bSBwaXBlICpwaXBlKQo+ID4gK3sKPiA+ICsJdTMyIHZhbDsK PiA+ICsKPiA+ICsJdmFsID0gSTkxNV9SRUFEKGFkcGFfcmVnKTsKPiA+ICsKPiA+ICsJLyogYXNz ZXJ0cyB3YW50IHRvIGtub3cgdGhlIHBpcGUgZXZlbiBpZiB0aGUgcG9ydCBpcyBkaXNhYmxlZCAq Lwo+ID4gKwlpZiAoSEFTX1BDSF9DUFQoZGV2X3ByaXYpKQo+ID4gKwkJKnBpcGUgPSAodmFsICYg QURQQV9QSVBFX1NFTF9NQVNLX0NQVCkgPj4gQURQQV9QSVBFX1NFTF9TSElGVF9DUFQ7Cj4gPiAr CWVsc2UKPiA+ICsJCSpwaXBlID0gKHZhbCAmIEFEUEFfUElQRV9TRUxfTUFTSykgPj4gQURQQV9Q SVBFX1NFTF9TSElGVDsKPiA+ICsKPiA+ICsJcmV0dXJuIHZhbCAmIEFEUEFfREFDX0VOQUJMRTsK PiA+ICt9Cj4gPiArCj4gPiAgc3RhdGljIGJvb2wgaW50ZWxfY3J0X2dldF9od19zdGF0ZShzdHJ1 Y3QgaW50ZWxfZW5jb2RlciAqZW5jb2RlciwKPiA+ICAJCQkJICAgZW51bSBwaXBlICpwaXBlKQo+ ID4gIHsKPiA+IC0Jc3RydWN0IGRybV9kZXZpY2UgKmRldiA9IGVuY29kZXItPmJhc2UuZGV2Owo+ ID4gLQlzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPSB0b19pOTE1KGRldik7Cj4g PiArCXN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IHRvX2k5MTUoZW5jb2Rlci0+ YmFzZS5kZXYpOwo+ID4gIAlzdHJ1Y3QgaW50ZWxfY3J0ICpjcnQgPSBpbnRlbF9lbmNvZGVyX3Rv X2NydChlbmNvZGVyKTsKPiA+IC0JdTMyIHRtcDsKPiA+ICAJYm9vbCByZXQ7Cj4gPiAgCj4gPiAg CWlmICghaW50ZWxfZGlzcGxheV9wb3dlcl9nZXRfaWZfZW5hYmxlZChkZXZfcHJpdiwKPiA+ICAJ CQkJCQllbmNvZGVyLT5wb3dlcl9kb21haW4pKQo+ID4gIAkJcmV0dXJuIGZhbHNlOwo+ID4gIAo+ ID4gLQlyZXQgPSBmYWxzZTsKPiA+IC0KPiA+IC0JdG1wID0gSTkxNV9SRUFEKGNydC0+YWRwYV9y ZWcpOwo+ID4gLQo+ID4gLQlpZiAoISh0bXAgJiBBRFBBX0RBQ19FTkFCTEUpKQo+ID4gLQkJZ290 byBvdXQ7Cj4gPiArCXJldCA9IGludGVsX2NydF9wb3J0X2VuYWJsZWQoZGV2X3ByaXYsIGNydC0+ YWRwYV9yZWcsIHBpcGUpOwo+ID4gIAo+ID4gLQlpZiAoSEFTX1BDSF9DUFQoZGV2X3ByaXYpKQo+ ID4gLQkJKnBpcGUgPSBQT1JUX1RPX1BJUEVfQ1BUKHRtcCk7Cj4gPiAtCWVsc2UKPiA+IC0JCSpw aXBlID0gUE9SVF9UT19QSVBFKHRtcCk7Cj4gPiAtCj4gPiAtCXJldCA9IHRydWU7Cj4gPiAtb3V0 Ogo+ID4gIAlpbnRlbF9kaXNwbGF5X3Bvd2VyX3B1dChkZXZfcHJpdiwgZW5jb2Rlci0+cG93ZXJf ZG9tYWluKTsKPiA+ICAKPiA+ICAJcmV0dXJuIHJldDsKPiA+IEBAIC0xNjgsMTEgKzE3MCw5IEBA IHN0YXRpYyB2b2lkIGludGVsX2NydF9zZXRfZHBtcyhzdHJ1Y3QgaW50ZWxfZW5jb2RlciAqZW5j b2RlciwKPiA+ICAJaWYgKEhBU19QQ0hfTFBUKGRldl9wcml2KSkKPiA+ICAJCTsgLyogVGhvc2Ug Yml0cyBkb24ndCBleGlzdCBoZXJlICovCj4gPiAgCWVsc2UgaWYgKEhBU19QQ0hfQ1BUKGRldl9w cml2KSkKPiA+IC0JCWFkcGEgfD0gUE9SVF9UUkFOU19TRUxfQ1BUKGNydGMtPnBpcGUpOwo+ID4g LQllbHNlIGlmIChjcnRjLT5waXBlID09IDApCj4gPiAtCQlhZHBhIHw9IEFEUEFfUElQRV9BX1NF TEVDVDsKPiA+ICsJCWFkcGEgfD0gQURQQV9QSVBFX1NFTF9DUFQoY3J0Yy0+cGlwZSk7Cj4gPiAg CWVsc2UKPiA+IC0JCWFkcGEgfD0gQURQQV9QSVBFX0JfU0VMRUNUOwo+ID4gKwkJYWRwYSB8PSBB RFBBX1BJUEVfU0VMKGNydGMtPnBpcGUpOwo+ID4gIAo+ID4gIAlpZiAoIUhBU19QQ0hfU1BMSVQo ZGV2X3ByaXYpKQo+ID4gIAkJSTkxNV9XUklURShCQ0xSUEFUKGNydGMtPnBpcGUpLCAwKTsKPiA+ IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMgYi9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPiA+IGluZGV4IGFkNTg4ZDU2NDE5OC4u NmRhYThkOTdhMGFhIDEwMDY0NAo+ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf ZGlzcGxheS5jCj4gPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMK PiA+IEBAIC0xMzYwLDIxICsxMzYwLDYgQEAgc3RhdGljIGJvb2wgbHZkc19waXBlX2VuYWJsZWQo c3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+ID4gIAlyZXR1cm4gdHJ1ZTsKPiA+ ICB9Cj4gPiAgCj4gPiAtc3RhdGljIGJvb2wgYWRwYV9waXBlX2VuYWJsZWQoc3RydWN0IGRybV9p OTE1X3ByaXZhdGUgKmRldl9wcml2LAo+ID4gLQkJCSAgICAgIGVudW0gcGlwZSBwaXBlLCB1MzIg dmFsKQo+ID4gLXsKPiA+IC0JaWYgKCh2YWwgJiBBRFBBX0RBQ19FTkFCTEUpID09IDApCj4gPiAt CQlyZXR1cm4gZmFsc2U7Cj4gPiAtCWlmIChIQVNfUENIX0NQVChkZXZfcHJpdikpIHsKPiA+IC0J CWlmICgodmFsICYgUE9SVF9UUkFOU19TRUxfTUFTSykgIT0gUE9SVF9UUkFOU19TRUxfQ1BUKHBp cGUpKQo+ID4gLQkJCXJldHVybiBmYWxzZTsKPiA+IC0JfSBlbHNlIHsKPiA+IC0JCWlmICgodmFs ICYgQURQQV9QSVBFX1NFTEVDVF9NQVNLKSAhPSBBRFBBX1BJUEVfU0VMRUNUKHBpcGUpKQo+ID4g LQkJCXJldHVybiBmYWxzZTsKPiA+IC0JfQo+ID4gLQlyZXR1cm4gdHJ1ZTsKPiA+IC19Cj4gPiAt Cj4gPiAgc3RhdGljIHZvaWQgYXNzZXJ0X3BjaF9kcF9kaXNhYmxlZChzdHJ1Y3QgZHJtX2k5MTVf cHJpdmF0ZSAqZGV2X3ByaXYsCj4gPiAgCQkJCSAgIGVudW0gcGlwZSBwaXBlLCBpOTE1X3JlZ190 IHJlZywKPiA+ICAJCQkJICAgdTMyIHBvcnRfc2VsKQo+ID4gQEAgLTE0MDUsMTYgKzEzOTAsMTcg QEAgc3RhdGljIHZvaWQgYXNzZXJ0X3BjaF9oZG1pX2Rpc2FibGVkKHN0cnVjdCBkcm1faTkxNV9w cml2YXRlICpkZXZfcHJpdiwKPiA+ICBzdGF0aWMgdm9pZCBhc3NlcnRfcGNoX3BvcnRzX2Rpc2Fi bGVkKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPiA+ICAJCQkJICAgICAgZW51 bSBwaXBlIHBpcGUpCj4gPiAgewo+ID4gKwllbnVtIHBpcGUgcG9ydF9waXBlOwo+ID4gIAl1MzIg dmFsOwo+ID4gIAo+ID4gIAlhc3NlcnRfcGNoX2RwX2Rpc2FibGVkKGRldl9wcml2LCBwaXBlLCBQ Q0hfRFBfQiwgVFJBTlNfRFBfUE9SVF9TRUxfQik7Cj4gPiAgCWFzc2VydF9wY2hfZHBfZGlzYWJs ZWQoZGV2X3ByaXYsIHBpcGUsIFBDSF9EUF9DLCBUUkFOU19EUF9QT1JUX1NFTF9DKTsKPiA+ICAJ YXNzZXJ0X3BjaF9kcF9kaXNhYmxlZChkZXZfcHJpdiwgcGlwZSwgUENIX0RQX0QsIFRSQU5TX0RQ X1BPUlRfU0VMX0QpOwo+ID4gIAo+ID4gLQl2YWwgPSBJOTE1X1JFQUQoUENIX0FEUEEpOwo+ID4g LQlJOTE1X1NUQVRFX1dBUk4oYWRwYV9waXBlX2VuYWJsZWQoZGV2X3ByaXYsIHBpcGUsIHZhbCks Cj4gPiAtCSAgICAgIlBDSCBWR0EgZW5hYmxlZCBvbiB0cmFuc2NvZGVyICVjLCBzaG91bGQgYmUg ZGlzYWJsZWRcbiIsCj4gPiAtCSAgICAgcGlwZV9uYW1lKHBpcGUpKTsKPiA+ICsJSTkxNV9TVEFU RV9XQVJOKGludGVsX2NydF9wb3J0X2VuYWJsZWQoZGV2X3ByaXYsIFBDSF9BRFBBLCAmcG9ydF9w aXBlKSAmJgo+ID4gKwkJCXBvcnRfcGlwZSA9PSBwaXBlLAo+ID4gKwkJCSJQQ0ggVkdBIGVuYWJs ZWQgb24gdHJhbnNjb2RlciAlYywgc2hvdWxkIGJlIGRpc2FibGVkXG4iLAo+ID4gKwkJCXBpcGVf bmFtZShwaXBlKSk7Cj4gPiAgCj4gPiAgCXZhbCA9IEk5MTVfUkVBRChQQ0hfTFZEUyk7Cj4gPiAg CUk5MTVfU1RBVEVfV0FSTihsdmRzX3BpcGVfZW5hYmxlZChkZXZfcHJpdiwgcGlwZSwgdmFsKSwK PiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcnYuaCBiL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rydi5oCj4gPiBpbmRleCBkN2RiY2ExYWFiZmYuLjQyMzc5 NTA1MDk3MCAxMDA2NDQKPiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rydi5o Cj4gPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcnYuaAo+ID4gQEAgLTEzNzcs NiArMTM3Nyw4IEBAIHZvaWQgZ2VuOV9lbmFibGVfZ3VjX2ludGVycnVwdHMoc3RydWN0IGRybV9p OTE1X3ByaXZhdGUgKmRldl9wcml2KTsKPiA+ICB2b2lkIGdlbjlfZGlzYWJsZV9ndWNfaW50ZXJy dXB0cyhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpOwo+ID4gIAo+ID4gIC8qIGlu dGVsX2NydC5jICovCj4gPiArYm9vbCBpbnRlbF9jcnRfcG9ydF9lbmFibGVkKHN0cnVjdCBkcm1f aTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPiA+ICsJCQkgICAgaTkxNV9yZWdfdCBhZHBhX3JlZywg ZW51bSBwaXBlICpwaXBlKTsKPiA+ICB2b2lkIGludGVsX2NydF9pbml0KHN0cnVjdCBkcm1faTkx NV9wcml2YXRlICpkZXZfcHJpdik7Cj4gPiAgdm9pZCBpbnRlbF9jcnRfcmVzZXQoc3RydWN0IGRy bV9lbmNvZGVyICplbmNvZGVyKTsKPiAKPiAtLSAKPiBKYW5pIE5pa3VsYSwgSW50ZWwgT3BlbiBT b3VyY2UgVGVjaG5vbG9neSBDZW50ZXIKCi0tIApWaWxsZSBTeXJqw6Rsw6QKSW50ZWwKX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxp bmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJl ZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==