From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47356) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fJKnf-00089f-8n for qemu-devel@nongnu.org; Thu, 17 May 2018 11:26:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fJKnZ-0001wt-SI for qemu-devel@nongnu.org; Thu, 17 May 2018 11:26:39 -0400 Date: Thu, 17 May 2018 17:26:28 +0200 From: Cornelia Huck Message-ID: <20180517172628.61cf46ba.cohuck@redhat.com> In-Reply-To: <20180516132757.68558-1-pasic@linux.ibm.com> References: <20180516132757.68558-1-pasic@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/1] virtio-ccw: clean up notify List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Halil Pasic Cc: Richard Henderson , Alexander Graf , David Hildenbrand , Peter Maydell , Dong Jia Shi , qemu-s390x@nongnu.org, qemu-devel@nongnu.org On Wed, 16 May 2018 15:27:57 +0200 Halil Pasic wrote: > Coverity recently started complaining about virtio_ccw_notify(). Turns > out, there is a couple of things that can be cleaned up. Let's clean! Changes look good to me. I wanted to come up with a better patch description, but failed (well, I did not try much.) So I'm inclined to merge this as-is. > > Reported-by: Peter Maydell > Fixes: CID 1390619 > Signed-off-by: Halil Pasic > --- > hw/s390x/virtio-ccw.c | 13 +++++++++---- > 1 file changed, 9 insertions(+), 4 deletions(-)