From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Nul-terminate legacy debug string
Date: Thu, 17 May 2018 22:06:28 +0300 [thread overview]
Message-ID: <20180517190628.GP23723@intel.com> (raw)
In-Reply-To: <20180517152824.11619-1-chris@chris-wilson.co.uk>
On Thu, May 17, 2018 at 04:28:24PM +0100, Chris Wilson wrote:
> Make sure that when we don't have any scheduler attributes for the
> request the string is terminated.
>
> Fixes: 247870ac8ea7 ("drm/i915: Build request info on stack before printk")
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> drivers/gpu/drm/i915/intel_engine_cs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_engine_cs.c b/drivers/gpu/drm/i915/intel_engine_cs.c
> index d4e159ae65a6..e78c6e769e8c 100644
> --- a/drivers/gpu/drm/i915/intel_engine_cs.c
> +++ b/drivers/gpu/drm/i915/intel_engine_cs.c
> @@ -1143,7 +1143,7 @@ static void print_request(struct drm_printer *m,
> const char *prefix)
> {
> const char *name = rq->fence.ops->get_timeline_name(&rq->fence);
> - char buf[80];
> + char buf[80] = "";
> int x = 0;
>
> x = print_sched_attr(rq->i915, &rq->sched.attr, buf, x, sizeof(buf));
> --
> 2.17.0
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2018-05-17 19:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-17 15:28 [PATCH] drm/i915: Nul-terminate legacy debug string Chris Wilson
2018-05-17 15:58 ` ✓ Fi.CI.BAT: success for " Patchwork
2018-05-17 19:02 ` ✓ Fi.CI.IGT: " Patchwork
2018-05-17 19:06 ` Ville Syrjälä [this message]
2018-05-17 21:14 ` [PATCH] " Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180517190628.GP23723@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.