From: Daniel Henrique Barboza <danielhb@linux.ibm.com>
To: qemu-devel@nongnu.org
Cc: armbru@redhat.com, mdroth@linux.vnet.ibm.com, eblake@redhat.com,
dgilbert@redhat.com,
Daniel Henrique Barboza <danielhb@linux.ibm.com>
Subject: [Qemu-devel] [PATCH v7 2/3] qga: update guest-suspend-ram and guest-suspend-hybrid descriptions
Date: Thu, 17 May 2018 16:23:24 -0300 [thread overview]
Message-ID: <20180517192325.8335-3-danielhb@linux.ibm.com> (raw)
In-Reply-To: <20180517192325.8335-1-danielhb@linux.ibm.com>
This patch updates the descriptions of 'guest-suspend-ram' and
'guest-suspend-hybrid' to mention that both commands relies now
on the proper support for wake up from suspend, retrieved by the
'wakeup-suspend-support' attribute of the 'query-target' QMP
command.
Reported-by: Balamuruhan S <bala24@linux.vnet.ibm.com>
Signed-off-by: Daniel Henrique Barboza <danielhb@linux.ibm.com>
Reviewed-by: Michael Roth <mdroth@linux.vnet.ibm.com>
---
qga/qapi-schema.json | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/qga/qapi-schema.json b/qga/qapi-schema.json
index 17884c7c70..bc46c2d0f0 100644
--- a/qga/qapi-schema.json
+++ b/qga/qapi-schema.json
@@ -565,9 +565,9 @@
# For the best results it's strongly recommended to have the pm-utils
# package installed in the guest.
#
-# IMPORTANT: guest-suspend-ram requires QEMU to support the 'system_wakeup'
-# command. Thus, it's *required* to query QEMU for the presence of the
-# 'system_wakeup' command before issuing guest-suspend-ram.
+# IMPORTANT: guest-suspend-ram requires working wakeup support in
+# QEMU. You *must* check QMP command query-target returns
+# wakeup-suspend-support: true before issuing this command.
#
# This command does NOT return a response on success. There are two options
# to check for success:
@@ -592,9 +592,9 @@
#
# This command requires the pm-utils package to be installed in the guest.
#
-# IMPORTANT: guest-suspend-hybrid requires QEMU to support the 'system_wakeup'
-# command. Thus, it's *required* to query QEMU for the presence of the
-# 'system_wakeup' command before issuing guest-suspend-hybrid.
+# IMPORTANT: guest-suspend-hybrid requires working wakeup support in
+# QEMU. You *must* check QMP command query-target returns
+# wakeup-suspend-support: true before issuing this command.
#
# This command does NOT return a response on success. There are two options
# to check for success:
--
2.14.3
next prev parent reply other threads:[~2018-05-17 19:23 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-17 19:23 [Qemu-devel] [PATCH v7 0/3] wakeup-from-suspend and system_wakeup changes Daniel Henrique Barboza
2018-05-17 19:23 ` [Qemu-devel] [PATCH v7 1/3] qmp: adding 'wakeup-suspend-support' in query-target Daniel Henrique Barboza
2018-05-18 8:48 ` Markus Armbruster
2018-05-21 18:14 ` Eduardo Habkost
2018-05-21 19:46 ` Daniel Henrique Barboza
2018-05-21 20:26 ` Eduardo Habkost
2018-05-23 9:17 ` Markus Armbruster
2018-05-23 12:27 ` Eduardo Habkost
2018-05-23 14:11 ` Daniel Henrique Barboza
2018-05-23 15:53 ` Markus Armbruster
2018-05-24 18:57 ` Eduardo Habkost
2018-05-25 6:30 ` Markus Armbruster
2018-05-25 20:30 ` Eduardo Habkost
2018-05-28 7:23 ` Markus Armbruster
2018-05-29 14:55 ` Eduardo Habkost
2018-06-19 20:29 ` Daniel Henrique Barboza
2018-06-20 7:09 ` Markus Armbruster
2018-05-17 19:23 ` Daniel Henrique Barboza [this message]
2018-05-17 19:23 ` [Qemu-devel] [PATCH v7 3/3] qmp.c: system_wakeup: runstate and wake-up support check Daniel Henrique Barboza
2018-05-18 8:48 ` Markus Armbruster
2018-05-18 12:52 ` Daniel Henrique Barboza
2018-05-18 15:00 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180517192325.8335-3-danielhb@linux.ibm.com \
--to=danielhb@linux.ibm.com \
--cc=armbru@redhat.com \
--cc=dgilbert@redhat.com \
--cc=eblake@redhat.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.