From: Ingo Molnar <mingo@kernel.org>
To: Richard Guy Briggs <rgb@redhat.com>
Cc: Linux-Audit Mailing List <linux-audit@redhat.com>,
LKML <linux-kernel@vger.kernel.org>,
Eric Paris <eparis@redhat.com>, Paul Moore <paul@paul-moore.com>,
Steve Grubb <sgrubb@redhat.com>, Ingo Molnar <mingo@redhat.com>
Subject: Re: [PATCH ghak81 V3a] fixup! audit: collect audit task parameters
Date: Fri, 18 May 2018 08:02:33 +0200 [thread overview]
Message-ID: <20180518060233.GA23531@gmail.com> (raw)
In-Reply-To: <03014913acdc9dc6fbbee0e16c937170fea86b06.1526577485.git.rgb@redhat.com>
* Richard Guy Briggs <rgb@redhat.com> wrote:
> Enable fork.c compilation with audit disabled.
>
> Signed-off-by: Richard Guy Briggs <rgb@redhat.com>
> ---
> Hi Paul, this one got caught by the 0-day kbuildbot. Can you squash it
> down if you haven't merged it yet?
> ---
> kernel/fork.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/kernel/fork.c b/kernel/fork.c
> index 92ab849..ff82928 100644
> --- a/kernel/fork.c
> +++ b/kernel/fork.c
> @@ -1713,7 +1713,9 @@ static __latent_entropy struct task_struct *copy_process(
> p->start_time = ktime_get_ns();
> p->real_start_time = ktime_get_boot_ns();
> p->io_context = NULL;
> +#ifdef CONFIG_AUDITSYSCALL
> p->audit = NULL;
> +#endif /* CONFIG_AUDITSYSCALL */
Please, simply use:
#endif
the comment is used for (much) larger blocks, to make it clear which block ends
there if the top is not visible.
Thanks,
Ingo
prev parent reply other threads:[~2018-05-18 6:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-17 17:20 [PATCH ghak81 V3a] fixup! audit: collect audit task parameters Richard Guy Briggs
2018-05-18 0:29 ` Paul Moore
2018-05-18 6:02 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180518060233.GA23531@gmail.com \
--to=mingo@kernel.org \
--cc=eparis@redhat.com \
--cc=linux-audit@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=paul@paul-moore.com \
--cc=rgb@redhat.com \
--cc=sgrubb@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.