From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com ([66.111.4.25]:52177 "EHLO out1-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750882AbeERGnp (ORCPT ); Fri, 18 May 2018 02:43:45 -0400 Date: Fri, 18 May 2018 08:43:27 +0200 From: Greg KH To: Daniel Sangorrin Cc: stable@vger.kernel.org, mtk.manpages@gmail.com, viro@zeniv.linux.org.uk Subject: Re: Backport of pipe.c patch to 4.4.y that fixes LTP fcntl35 test error Message-ID: <20180518064327.GA12930@kroah.com> References: <000d01d3ee46$292bbcd0$7b833670$@toshiba.co.jp> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <000d01d3ee46$292bbcd0$7b833670$@toshiba.co.jp> Sender: stable-owner@vger.kernel.org List-ID: On Fri, May 18, 2018 at 10:18:42AM +0900, Daniel Sangorrin wrote: > Oops sorry, I failed to write the subject. It should been something like the subject of this e-mail. > > > -----Original Message----- > > From: stable-owner@vger.kernel.org [mailto:stable-owner@vger.kernel.org] On > > Behalf Of Daniel Sangorrin > > Sent: Friday, May 18, 2018 9:59 AM > > To: stable@vger.kernel.org > > Cc: mtk.manpages@gmail.com; viro@zeniv.linux.org.uk > > Subject: > > > > Hello Greg, > > > > After running LTP with Fuego on the LTS kernel 4.4.y, there were > > a few test cases failing that I thought needed some investigation. > > > > I reviewed the first one (fcntl35 and fcntl35_64) so far. According to the > > comments on LTP's fcntl35.c file (by Xiao Yang ) > > the bug tested by this test case was fixed by: > > pipe: cap initial pipe capacity according to pipe-max-size > > commit 086e774a57fba4695f14383c0818994c0b31da7c > > Author: Michael Kerrisk (man-pages) > > Date: Tue Oct 11 13:53:43 2016 -0700 > > > > I backported that patch (see next e-mail), tested again and confirmed that > > the patch fixed the bug (or at least the error message in LTP's test). > > > > Before: > > fcntl35.c:98: FAIL: an unprivileged user init the capacity of a pipe to 65536 > > unexpectedly, expected 4096 > > After: > > fcntl35.c:101: PASS: an unprivileged user init the capacity of a pipe to 4096 > > successfully Looks great, thanks, I've queued this up now. greg k-h