From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Date: Fri, 18 May 2018 08:04:45 +0000 Subject: [PATCH] drm/exynos: fimc: signedness bug in fimc_setup_clocks() Message-Id: <20180518080445.GB28335@mwanda> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Inki Dae , Marek Szyprowski Cc: linux-samsung-soc@vger.kernel.org, David Airlie , kernel-janitors@vger.kernel.org, Seung-Woo Kim , Krzysztof Kozlowski , Kyungmin Park , Kukjin Kim , dri-devel@lists.freedesktop.org "id" needs to be signed for the error handling to work. Fixes: 7a2d5c77c558 ("drm/exynos: fimc: Convert driver to IPP v2 core API") Signed-off-by: Dan Carpenter diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimc.c b/drivers/gpu/drm/exynos/exynos_drm_fimc.c index 4dfbfc7f3b84..5ce84025d1cb 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_fimc.c +++ b/drivers/gpu/drm/exynos/exynos_drm_fimc.c @@ -1200,7 +1200,7 @@ static int fimc_setup_clocks(struct fimc_context *ctx) int exynos_drm_check_fimc_device(struct device *dev) { - unsigned int id = of_alias_get_id(dev->of_node, "fimc"); + int id = of_alias_get_id(dev->of_node, "fimc"); if (id >= 0 && (BIT(id) & fimc_mask)) return 0; From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Subject: [PATCH] drm/exynos: fimc: signedness bug in fimc_setup_clocks() Date: Fri, 18 May 2018 01:04:45 -0700 (PDT) Message-ID: <20180518080445.GB28335@mwanda> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Inki Dae , Marek Szyprowski Cc: linux-samsung-soc@vger.kernel.org, David Airlie , kernel-janitors@vger.kernel.org, Seung-Woo Kim , Krzysztof Kozlowski , Kyungmin Park , Kukjin Kim , dri-devel@lists.freedesktop.org List-Id: linux-samsung-soc@vger.kernel.org ImlkIiBuZWVkcyB0byBiZSBzaWduZWQgZm9yIHRoZSBlcnJvciBoYW5kbGluZyB0byB3b3JrLgoK Rml4ZXM6IDdhMmQ1Yzc3YzU1OCAoImRybS9leHlub3M6IGZpbWM6IENvbnZlcnQgZHJpdmVyIHRv IElQUCB2MiBjb3JlIEFQSSIpClNpZ25lZC1vZmYtYnk6IERhbiBDYXJwZW50ZXIgPGRhbi5jYXJw ZW50ZXJAb3JhY2xlLmNvbT4KCmRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vZXh5bm9zL2V4 eW5vc19kcm1fZmltYy5jIGIvZHJpdmVycy9ncHUvZHJtL2V4eW5vcy9leHlub3NfZHJtX2ZpbWMu YwppbmRleCA0ZGZiZmM3ZjNiODQuLjVjZTg0MDI1ZDFjYiAxMDA2NDQKLS0tIGEvZHJpdmVycy9n cHUvZHJtL2V4eW5vcy9leHlub3NfZHJtX2ZpbWMuYworKysgYi9kcml2ZXJzL2dwdS9kcm0vZXh5 bm9zL2V4eW5vc19kcm1fZmltYy5jCkBAIC0xMjAwLDcgKzEyMDAsNyBAQCBzdGF0aWMgaW50IGZp bWNfc2V0dXBfY2xvY2tzKHN0cnVjdCBmaW1jX2NvbnRleHQgKmN0eCkKIAogaW50IGV4eW5vc19k cm1fY2hlY2tfZmltY19kZXZpY2Uoc3RydWN0IGRldmljZSAqZGV2KQogewotCXVuc2lnbmVkIGlu dCBpZCA9IG9mX2FsaWFzX2dldF9pZChkZXYtPm9mX25vZGUsICJmaW1jIik7CisJaW50IGlkID0g b2ZfYWxpYXNfZ2V0X2lkKGRldi0+b2Zfbm9kZSwgImZpbWMiKTsKIAogCWlmIChpZCA+PSAwICYm IChCSVQoaWQpICYgZmltY19tYXNrKSkKIAkJcmV0dXJuIDA7Cl9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRl dmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9t YWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=